From: Jens Axboe <axboe@kernel.dk>
To: Yufen Yu <yuyufen@huawei.com>
Cc: linux-block@vger.kernel.org, jack@suse.cz, hare@suse.de,
ming.lei@redhat.com, damien.lemoal@wdc.com
Subject: Re: [PATCH] block: check disk exist before trying to add partition
Date: Tue, 8 Jun 2021 15:08:28 -0600 [thread overview]
Message-ID: <8e7e4b2a-b0e2-9830-e2bc-cbc6e9fd7b41@kernel.dk> (raw)
In-Reply-To: <20210608092707.1062259-1-yuyufen@huawei.com>
On 6/8/21 3:27 AM, Yufen Yu wrote:
> If disk have been deleted, we should return fail for ioctl
> BLKPG_DEL_PARTITION. Otherwise, the directory /sys/class/block
> may remain invalid symlinks file. The race as following:
>
> blkdev_open
> del_gendisk
> disk->flags &= ~GENHD_FL_UP;
> blk_drop_partitions
> blkpg_ioctl
> bdev_add_partition
> add_partition
> device_add
> device_add_class_symlinks
>
> ioctl may add_partition after del_gendisk() have tried to delete
> partitions. Then, symlinks file will be created.
Let's do this for 5.14, which means send it against for-5.14/block
please. Thanks.
--
Jens Axboe
next prev parent reply other threads:[~2021-06-08 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 9:27 [PATCH] block: check disk exist before trying to add partition Yufen Yu
2021-06-08 10:08 ` Jan Kara
2021-06-08 17:10 ` Christoph Hellwig
2021-06-08 21:08 ` Jens Axboe [this message]
2021-06-10 2:30 ` Yufen Yu
2021-06-10 6:28 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e7e4b2a-b0e2-9830-e2bc-cbc6e9fd7b41@kernel.dk \
--to=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.