From: Matt <mwtaylor@gmail.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: Error setting UUIDs discovery filter on big endian systems
Date: Wed, 6 Mar 2019 15:14:16 +0000 [thread overview]
Message-ID: <8e85abc1-6661-547c-3aab-a60dd8b4a7b2@gmail.com> (raw)
In-Reply-To: <CABBYNZ+CQ_RQgxAavzKCyhGcy0rNPnZkG_fW6mSO0j0Q3Y+cTg@mail.gmail.com>
On 06/03/2019 14:14, Luiz Augusto von Dentz wrote:
> Hi Matt,
> On Wed, Mar 6, 2019 at 3:48 PM Matt <mwtaylor@gmail.com> wrote:
>> On 06/03/2019 11:10, Luiz Augusto von Dentz wrote:
>>> Looks like the kernel is indeed assuming the length is in LE:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git/tree/net/bluetooth/mgmt.c#n3958
>> Thanks for pointing me to this line, removing the __le16_to_cpu() does
>> seem to fix the UUIDs filter scanning on my big endian hardware, I'm not
>> sure why it is needed, perhaps removing it would break LE hardware or
>> some other case but I would imagine __le16_to_cpu() would do nothing in
>> the LE case anyway. I have made this patch to my kernel (4.9) that seems
>> to be all is needed for me to fix the issue (no changes to bluez):
> Check the patch Ive just sent, your initial fix is actually correct
> but since you change it to little endian you had to convert it back
> when calculating the length of message otherwise you end up with an
> invalid size.
The patch you sent works, thanks. (Sorry, I missed it as I wasn't
subscribed to the mailing list but looking at the archive.)
>
> The kernel is actually assuming Little Endian as this is a convention
> for Bluetooth protocols.
Ok, that would explain it then.
Many thanks for your help,
Matt
prev parent reply other threads:[~2019-03-06 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 13:56 Error setting UUIDs discovery filter on big endian systems Matt
2018-12-04 19:53 ` Luiz Augusto von Dentz
2018-12-05 0:27 ` Matt
2019-03-05 18:02 ` Matt
2019-03-06 11:10 ` Luiz Augusto von Dentz
2019-03-06 13:48 ` Matt
2019-03-06 14:14 ` Luiz Augusto von Dentz
2019-03-06 15:14 ` Matt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e85abc1-6661-547c-3aab-a60dd8b4a7b2@gmail.com \
--to=mwtaylor@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.