All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Goel, Akash" <akash.goel@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: akash.goel@intel.com
Subject: Re: [PATCH 17/19] drm/i915: Use SSE4.1 movntdqa based memcpy for sampling GuC log buffer
Date: Sat, 20 Aug 2016 12:14:46 +0530	[thread overview]
Message-ID: <8e897476-23aa-9f67-d7ec-3d4c58abbed9@intel.com> (raw)
In-Reply-To: <20160819181920.GD16497@nuc-i3427.alporthouse.com>



On 8/19/2016 11:49 PM, Chris Wilson wrote:
> On Fri, Aug 19, 2016 at 02:13:16PM +0530, akash.goel@intel.com wrote:
>> From: Akash Goel <akash.goel@intel.com>
>>
>> In order to have fast reads from the GuC log buffer, used SSE4.1 movntdqa
>> based memcpy function i915_memcpy_from_wc.
>> GuC log buffer has a WC type vmalloc mapping and copying using movntqda
>> from WC type memory is almost as fast as reading from WB memory.
>> This will further reduce the log buffer sampling time, so is needed dearly
>> to deal with the flush interrupt storm when GuC is generating logs at a
>> very high rate.
>> Ideally SSE 4.1 should be present on all chipsets supporting GuC based
>> submisssions, but if not then logging will not be enabled.
>>
>> v2: Rebase.
>>
>> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Signed-off-by: Akash Goel <akash.goel@intel.com>
>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Should be squashed with patch 16 (use MAP_WC).
Fine will squash, but please could you tell that what issue could be 
there with 2 patches being separate. Either both will be merged or none 
of them will be merged.

Best regards
Akash

> -Chris
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-08-20  6:44 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-19  8:42 [PATCH v8 00/19] Support for sustained capturing of GuC firmware logs akash.goel
2016-08-19  8:43 ` [PATCH 01/19] drm/i915: Decouple GuC log setup from verbosity parameter akash.goel
2016-08-19  8:43 ` [PATCH 02/19] drm/i915: Add GuC ukernel logging related fields to fw interface file akash.goel
2016-08-19  8:43 ` [PATCH 03/19] drm/i915: New structure to contain GuC logging related fields akash.goel
2016-08-19  8:43 ` [PATCH 04/19] drm/i915: Add low level set of routines for programming PM IER/IIR/IMR register set akash.goel
2016-08-19  8:43 ` [PATCH 05/19] drm/i915: Support for GuC interrupts akash.goel
2016-08-19  8:43 ` [PATCH 06/19] drm/i915: Handle log buffer flush interrupt event from GuC akash.goel
2016-08-19 10:08   ` Tvrtko Ursulin
2016-08-19  8:43 ` [PATCH 07/19] relay: Use per CPU constructs for the relay channel buffer pointers akash.goel
2016-08-19  8:43 ` [PATCH 08/19] drm/i915: Add a relay backed debugfs interface for capturing GuC logs akash.goel
2016-08-19 18:03   ` Chris Wilson
2016-08-20  6:40     ` Goel, Akash
2016-08-19  8:43 ` [PATCH 09/19] drm/i915: New lock to serialize the Host2GuC actions akash.goel
2016-08-19  8:43 ` [PATCH 10/19] drm/i915: Add stats for GuC log buffer flush interrupts akash.goel
2016-08-19  8:43 ` [PATCH 11/19] drm/i915: Optimization to reduce the sampling time of GuC log buffer akash.goel
2016-08-19  8:43 ` [PATCH 12/19] drm/i915: Increase GuC log buffer size to reduce flush interrupts akash.goel
2016-08-19  8:43 ` [PATCH 13/19] drm/i915: Augment i915 error state to include the dump of GuC log buffer akash.goel
2016-08-19  8:43 ` [PATCH 14/19] drm/i915: Forcefully flush GuC log buffer on reset akash.goel
2016-08-19 18:10   ` Chris Wilson
2016-08-20  6:49     ` Goel, Akash
2016-08-19  8:43 ` [PATCH 15/19] drm/i915: Debugfs support for GuC logging control akash.goel
2016-08-19 18:18   ` Chris Wilson
2016-08-20  6:40     ` Goel, Akash
2016-08-19  8:43 ` [PATCH 16/19] drm/i915: Use uncached(WC) mapping for acessing the GuC log buffer akash.goel
2016-08-19  8:43 ` [PATCH 17/19] drm/i915: Use SSE4.1 movntdqa based memcpy for sampling " akash.goel
2016-08-19 18:19   ` Chris Wilson
2016-08-20  6:44     ` Goel, Akash [this message]
2016-08-20  8:40       ` Chris Wilson
2016-08-19  8:43 ` [PATCH 18/19] drm/i915: Early creation of relay channel for capturing boot time logs akash.goel
2016-08-19  8:43 ` [PATCH 19/19] drm/i915: Mark the GuC log buffer flush interrupts handling WQ as freezable akash.goel
2016-08-19 10:19   ` Imre Deak
2016-08-19  9:01 ` ✗ Ro.CI.BAT: failure for Support for sustained capturing of GuC firmware logs (rev9) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2016-08-17 10:14 [PATCH v7 00/19] Support for sustained capturing of GuC firmware logs akash.goel
2016-08-17 10:14 ` [PATCH 17/19] drm/i915: Use SSE4.1 movntdqa based memcpy for sampling GuC log buffer akash.goel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e897476-23aa-9f67-d7ec-3d4c58abbed9@intel.com \
    --to=akash.goel@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.