All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2
@ 2022-04-13  0:57 Anusha Srivatsa
  2022-04-13 20:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Anusha Srivatsa @ 2022-04-13  0:57 UTC (permalink / raw)
  To: intel-gfx

Add Support for DC states on Dg2.

Signed-off-by: Anusha Srivatsa <anusha.srivatsa@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c |  2 +-
 drivers/gpu/drm/i915/display/intel_dmc.c           | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 6a5695008f7c..5a0cab82a156 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -4770,7 +4770,7 @@ static u32 get_allowed_dc_mask(const struct drm_i915_private *dev_priv,
 	if (!HAS_DISPLAY(dev_priv))
 		return 0;
 
-	if (IS_DG1(dev_priv))
+	if (IS_DG1(dev_priv) || IS_DG2(dev_priv))
 		max_dc = 3;
 	else if (DISPLAY_VER(dev_priv) >= 12)
 		max_dc = 4;
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 257cf662f9f4..2f01aca4d981 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -52,6 +52,10 @@
 
 #define DISPLAY_VER12_DMC_MAX_FW_SIZE	ICL_DMC_MAX_FW_SIZE
 
+#define DG2_DMC_PATH			DMC_PATH(dg2, 2, 06)
+#define DG2_DMC_VERSION_REQUIRED	DMC_VERSION(2, 06)
+MODULE_FIRMWARE(DG2_DMC_PATH);
+
 #define ADLP_DMC_PATH			DMC_PATH(adlp, 2, 16)
 #define ADLP_DMC_VERSION_REQUIRED	DMC_VERSION(2, 16)
 MODULE_FIRMWARE(ADLP_DMC_PATH);
@@ -688,7 +692,11 @@ void intel_dmc_ucode_init(struct drm_i915_private *dev_priv)
 	 */
 	intel_dmc_runtime_pm_get(dev_priv);
 
-	if (IS_ALDERLAKE_P(dev_priv)) {
+	if (IS_DG2(dev_priv)) {
+		dmc->fw_path = DG2_DMC_PATH;
+		dmc->required_version = DG2_DMC_VERSION_REQUIRED;
+		dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
+	} else if (IS_ALDERLAKE_P(dev_priv)) {
 		dmc->fw_path = ADLP_DMC_PATH;
 		dmc->required_version = ADLP_DMC_VERSION_REQUIRED;
 		dmc->max_fw_size = DISPLAY_VER13_DMC_MAX_FW_SIZE;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 0/1] DG2 DMC Support
@ 2022-05-06 17:13 Anusha Srivatsa
  2022-05-06 18:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4) Patchwork
  0 siblings, 1 reply; 13+ messages in thread
From: Anusha Srivatsa @ 2022-05-06 17:13 UTC (permalink / raw)
  To: intel-gfx; +Cc: Rodrigo Vivi

While DG2 supports DC5 and DC9, some of the tests in
fast-feedback blew up DG2 when the tests forced transition
from dc5->dc9 on suspend and dc9->dc5 on resume. Some local
experiments performed with Rodrigo on a RIL system  showed promising
results when dc5 was completely diabled and i915 took only dc9 paths.

Sending this so we can check the CI results to confirm the
findings from local testing which will hopefully help narrow
down the root cause of MMIO BAR lost issue

Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Imre Deak <imre.deak@intel.com>

Anusha Srivatsa (1):
  drm/i915/dmc: Load DMC on DG2

 drivers/gpu/drm/i915/display/intel_display_power.c |  4 +++-
 drivers/gpu/drm/i915/display/intel_dmc.c           | 10 +++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-05-06 18:14 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13  0:57 [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2 Anusha Srivatsa
2022-04-13 20:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-04-14  2:21   ` Srivatsa, Anusha
2022-04-13 20:56 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2022-04-14  3:05 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: Load DMC on DG2 (rev3) Patchwork
2022-04-14 18:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4) Patchwork
2022-04-14 20:54   ` Srivatsa, Anusha
2022-04-15  4:37     ` Lucas De Marchi
2022-04-15  6:39       ` Lucas De Marchi
2022-04-16 16:27       ` Sarvela, Tomi P
2022-04-14 21:44 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-04-15  4:32 ` [Intel-gfx] [PATCH] drm/i915/dmc: Load DMC on DG2 Lucas De Marchi
2022-05-06 17:13 [Intel-gfx] [PATCH 0/1] DG2 DMC Support Anusha Srivatsa
2022-05-06 18:14 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: Load DMC on DG2 (rev4) Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.