[PATCH v2] drm/amd/display: fix compiling error on 32-Bit Linux

[PATCH v2] drm/amd/display: fix compiling error on 32-Bit Linux

[Rex Zhu]

ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!

v2: remove temporary variable

Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
---
 drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
index 5e12e46..685f03d 100644
--- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
+++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
@@ -647,7 +647,7 @@ void mod_freesync_build_vrr_params(struct mod_freesync *mod_freesync,
 	 * this should be allowed instead of blocking FreeSync.
 	 */
 	if ((min_refresh_in_uhz / 1000000) >
-			((nominal_field_rate_in_uhz + 1000000 - 1) / 1000000))
+		div_u64(nominal_field_rate_in_uhz + 1000000 - 1, 1000000))
 		nominal_field_rate_in_range = false;
 
 	// Full range may be larger than current video timing, so cap at nominal
-- 
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v2] drm/amd/display: fix compiling error on 32-Bit Linux

[Christian König]

Am 17.04.2018 um 11:44 schrieb Rex Zhu:
> ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>
> v2: remove temporary variable
>
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
> ---
>   drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5e12e46..685f03d 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -647,7 +647,7 @@ void mod_freesync_build_vrr_params(struct mod_freesync *mod_freesync,
>   	 * this should be allowed instead of blocking FreeSync.
>   	 */
>   	if ((min_refresh_in_uhz / 1000000) >
> -			((nominal_field_rate_in_uhz + 1000000 - 1) / 1000000))
> +		div_u64(nominal_field_rate_in_uhz + 1000000 - 1, 1000000))

The indentation isn't correct, but that is just a nitpick.

Patch is Acked-by: Christian König <christian.koenig@amd.com>.

Regards,
Christian.

>   		nominal_field_rate_in_range = false;
>   
>   	// Full range may be larger than current video timing, so cap at nominal

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH v2] drm/amd/display: fix compiling error on 32-Bit Linux

[Harry Wentland]

On 2018-04-17 05:44 AM, Rex Zhu wrote:
> ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> 
> v2: remove temporary variable
> 
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>

Thanks for the fix.

I just pushed a change by Anthony that removes that hunk of code completely, so this won't be needed anymore.

Harry

> ---
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 5e12e46..685f03d 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -647,7 +647,7 @@ void mod_freesync_build_vrr_params(struct mod_freesync *mod_freesync,
>  	 * this should be allowed instead of blocking FreeSync.
>  	 */
>  	if ((min_refresh_in_uhz / 1000000) >
> -			((nominal_field_rate_in_uhz + 1000000 - 1) / 1000000))
> +		div_u64(nominal_field_rate_in_uhz + 1000000 - 1, 1000000))
>  		nominal_field_rate_in_range = false;
>  
>  	// Full range may be larger than current video timing, so cap at nominal
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx