From: "Chegondi, Harish" <harish.chegondi@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>
Cc: "Taylor, Clinton A" <clinton.a.taylor@intel.com>,
"Yadav, Jyoti R" <jyoti.r.yadav@intel.com>
Subject: Re: [igt-dev] [RFC i-g-t 1/1] i915/pm_backlight: turn on dpms before backlight fade out and fade in
Date: Wed, 3 Apr 2019 00:47:09 +0000 [thread overview]
Message-ID: <8eb9c24250eb482bda91f1bcc430a21053d16017.camel@intel.com> (raw)
In-Reply-To: <155254958544.4168.8591390419495126785@skylake-alporthouse-com>
[-- Attachment #1.1: Type: text/plain, Size: 1644 bytes --]
On Thu, 2019-03-14 at 07:46 +0000, Chris Wilson wrote:
> Quoting Harish Chegondi (2019-03-14 06:41:48)
> > backlight fade with suspend test turns off dpms which turns off
> > the edp backlight and panel. Then it does a runtime suspend,
> > system suspend and resume. After resume, it does a fade out and
> > fade in of the backlight brightness. From the dmesg logs of the
> > ci tests it appears that the test is setting the brightness
> > even before the edp panel and backlight are turned on resuilting
> > in the brightness values written and read to be different.
> > Turn on the dpms which turns on the edp panel and backlight
> > before backlight fade out and fade in. With this change the
> > fade_with_suspend test passes.
Chris,
My commit message was confusing. I will redo the commit message in the
next version of my patch.
>
> But is it legal for the kernel to that? Is the kernel meant to
> restore
> the previous configuration upon resume or leave it to userspace? What
> about for fbcon?
Yes, the kernel is meant to restore the previous configuration upon
resume. In this test, before system suspend, DPMS is turned off which
sets the crtc state to inactive and edp backlight to off. After system
resume, the crtc state should still be inactive and dpms and edp
backlight should still be off. After system resume, before setting the
backlight brighness, the test should turn on the DPMS. Turning on the
DPMS would set the CRTC state to active and turn on the backlight.
-Harish.
>
> If it is meant to leave it to userspace, why is the connector still
> even
> enabled?
> -Chris
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3274 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-03 0:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 6:41 [igt-dev] [RFC i-g-t 1/1] i915/pm_backlight: turn on dpms before backlight fade out and fade in Harish Chegondi
2019-03-14 7:25 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [RFC,i-g-t,1/1] " Patchwork
2019-03-14 7:46 ` [igt-dev] [RFC i-g-t 1/1] " Chris Wilson
2019-04-03 0:47 ` Chegondi, Harish [this message]
2019-04-03 7:44 ` Chris Wilson
2019-04-03 14:34 ` Daniel Vetter
2019-04-03 16:10 ` Daniel Vetter
2019-04-03 17:44 ` Chegondi, Harish
2019-03-14 15:23 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [RFC,i-g-t,1/1] " Patchwork
2019-04-04 1:26 ` [igt-dev] [PATCH v2 1/1] i915/pm_backlight: Do not turn off DPMS before system suspend Harish Chegondi
2019-04-04 8:12 ` Daniel Vetter
2019-04-05 0:35 ` Chegondi, Harish
2019-04-04 22:40 ` Souza, Jose
2019-04-04 3:06 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [v2,1/1] i915/pm_backlight: Do not turn off DPMS before system suspend (rev2) Patchwork
2019-04-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb9c24250eb482bda91f1bcc430a21053d16017.camel@intel.com \
--to=harish.chegondi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=clinton.a.taylor@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jyoti.r.yadav@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.