From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753049AbdCaCK5 (ORCPT ); Thu, 30 Mar 2017 22:10:57 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:44137 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbdCaCKy (ORCPT ); Thu, 30 Mar 2017 22:10:54 -0400 Subject: Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller To: Russell King - ARM Linux , Gregory CLEMENT References: <20170330185639.GI7909@n2100.armlinux.org.uk> CC: Ulf Hansson , Adrian Hunter , , Jimmy Xu , Andrew Lunn , Mike Turquette , Nadav Haklai , Victor Gu , Doug Jones , , Jisheng Zhang , Yehuda Yitschak , Marcin Wojtas , Kostya Porotchkin , Hanna Hawa , Sebastian Hesselbarth , , Jason Cooper , Rob Herring , Ryan Gao , "Wei(SOCP) Liu" , , Thomas Petazzoni , Stephen Boyd , , Wilson Ding From: Hu Ziji Message-ID: <8ebf11c8-f8e0-e4bb-ed70-f8c2e68aa787@marvell.com> Date: Fri, 31 Mar 2017 10:09:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170330185639.GI7909@n2100.armlinux.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-30_21:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1703310017 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, On 2017/3/31 2:56, Russell King - ARM Linux wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:52PM +0200, Gregory CLEMENT wrote: >> - Remove parse of child node mmc-card. Wait for a better solution. > > So for mcbin, I have: > > &ap_sdhci0 { > bus-width = <8>; > marvell,xenon-emmc; > marvell,xenon-phy-type = "emmc 5.1 phy"; > /* > * Not stable in HS modes - phy needs "more calibration", so add > * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes. > */ > marvell,xenon-phy-slow-mode; > no-1-8-v; > non-removable; > status = "okay"; > vqmmc-supply = <&v_vddo_h>; > > #address-cells = <1>; > #size-cells = <0>; > mmccard: mmccard@0 { > compatible = "mmc-card"; > reg = <0>; > }; > }; > > Does this mean the "mmccard" bit is no longer required - or is it required > for the eMMC to be detected but is no longer supported by the driver? > Based on the implementation in this release, "mmccard" is no longer required. More details: eMMC Vqmmc in Xenon is fixed without a regulator. Thus 1.8V Signaling Enable bit in SDHC doesn't work. As a result, Xenon driver has to skip sdhci_start_signal_voltage_switch() to avoid checking 1.8V signaling enable bit when setting signaling voltage. Previously, we use "mmccard" to inform Xenon driver that it is an eMMC card and therefore sdhci_start_signal_voltage_switch() is skipped. Currently, Xenon driver directly checks if Vqmmc regulator is provided. Skip sdhci_start_signal_voltage_switch() if Vqmmc is fixed. In my own opinion, it is more direct and clear, than checking eMMC card type. Thank you. Best regards, Hu Ziji > Thanks. > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hu Ziji Subject: Re: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller Date: Fri, 31 Mar 2017 10:09:58 +0800 Message-ID: <8ebf11c8-f8e0-e4bb-ed70-f8c2e68aa787@marvell.com> References: <20170330185639.GI7909@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170330185639.GI7909-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux , Gregory CLEMENT Cc: Ulf Hansson , Adrian Hunter , linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jimmy Xu , Andrew Lunn , Mike Turquette , Nadav Haklai , Victor Gu , Doug Jones , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jisheng Zhang , Yehuda Yitschak , Marcin Wojtas , Kostya Porotchkin , Hanna Hawa , Sebastian Hesselbarth , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jason Cooper , Rob Herring , Ryan Gao , "Wei(SOCP) Liu" , linux-arm-kernel-IAPFreCvJWNGWvitb5QawA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Russell, On 2017/3/31 2:56, Russell King - ARM Linux wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:52PM +0200, Gregory CLEMENT wrote: >> - Remove parse of child node mmc-card. Wait for a better solution. > > So for mcbin, I have: > > &ap_sdhci0 { > bus-width = <8>; > marvell,xenon-emmc; > marvell,xenon-phy-type = "emmc 5.1 phy"; > /* > * Not stable in HS modes - phy needs "more calibration", so add > * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes. > */ > marvell,xenon-phy-slow-mode; > no-1-8-v; > non-removable; > status = "okay"; > vqmmc-supply = <&v_vddo_h>; > > #address-cells = <1>; > #size-cells = <0>; > mmccard: mmccard@0 { > compatible = "mmc-card"; > reg = <0>; > }; > }; > > Does this mean the "mmccard" bit is no longer required - or is it required > for the eMMC to be detected but is no longer supported by the driver? > Based on the implementation in this release, "mmccard" is no longer required. More details: eMMC Vqmmc in Xenon is fixed without a regulator. Thus 1.8V Signaling Enable bit in SDHC doesn't work. As a result, Xenon driver has to skip sdhci_start_signal_voltage_switch() to avoid checking 1.8V signaling enable bit when setting signaling voltage. Previously, we use "mmccard" to inform Xenon driver that it is an eMMC card and therefore sdhci_start_signal_voltage_switch() is skipped. Currently, Xenon driver directly checks if Vqmmc regulator is provided. Skip sdhci_start_signal_voltage_switch() if Vqmmc is fixed. In my own opinion, it is more direct and clear, than checking eMMC card type. Thank you. Best regards, Hu Ziji > Thanks. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: huziji@marvell.com (Hu Ziji) Date: Fri, 31 Mar 2017 10:09:58 +0800 Subject: [PATCH v7 00/13] mmc: Add support to Marvell Xenon SD Host Controller In-Reply-To: <20170330185639.GI7909@n2100.armlinux.org.uk> References: <20170330185639.GI7909@n2100.armlinux.org.uk> Message-ID: <8ebf11c8-f8e0-e4bb-ed70-f8c2e68aa787@marvell.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, On 2017/3/31 2:56, Russell King - ARM Linux wrote: > ---------------------------------------------------------------------- > On Thu, Mar 30, 2017 at 05:22:52PM +0200, Gregory CLEMENT wrote: >> - Remove parse of child node mmc-card. Wait for a better solution. > > So for mcbin, I have: > > &ap_sdhci0 { > bus-width = <8>; > marvell,xenon-emmc; > marvell,xenon-phy-type = "emmc 5.1 phy"; > /* > * Not stable in HS modes - phy needs "more calibration", so add > * the "slow-mode" and disable SDR104, SDR50 and DDR50 modes. > */ > marvell,xenon-phy-slow-mode; > no-1-8-v; > non-removable; > status = "okay"; > vqmmc-supply = <&v_vddo_h>; > > #address-cells = <1>; > #size-cells = <0>; > mmccard: mmccard at 0 { > compatible = "mmc-card"; > reg = <0>; > }; > }; > > Does this mean the "mmccard" bit is no longer required - or is it required > for the eMMC to be detected but is no longer supported by the driver? > Based on the implementation in this release, "mmccard" is no longer required. More details: eMMC Vqmmc in Xenon is fixed without a regulator. Thus 1.8V Signaling Enable bit in SDHC doesn't work. As a result, Xenon driver has to skip sdhci_start_signal_voltage_switch() to avoid checking 1.8V signaling enable bit when setting signaling voltage. Previously, we use "mmccard" to inform Xenon driver that it is an eMMC card and therefore sdhci_start_signal_voltage_switch() is skipped. Currently, Xenon driver directly checks if Vqmmc regulator is provided. Skip sdhci_start_signal_voltage_switch() if Vqmmc is fixed. In my own opinion, it is more direct and clear, than checking eMMC card type. Thank you. Best regards, Hu Ziji > Thanks. >