From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 214A2C433FE for ; Thu, 10 Dec 2020 11:44:18 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAEB223AC4 for ; Thu, 10 Dec 2020 11:44:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAEB223AC4 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.49119.86866 (Exim 4.92) (envelope-from ) id 1knKMg-0001MR-Un; Thu, 10 Dec 2020 11:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 49119.86866; Thu, 10 Dec 2020 11:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1knKMg-0001MJ-RS; Thu, 10 Dec 2020 11:44:06 +0000 Received: by outflank-mailman (input) for mailman id 49119; Thu, 10 Dec 2020 11:44:05 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1knKMe-0001Kj-UV for xen-devel@lists.xenproject.org; Thu, 10 Dec 2020 11:44:04 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 6e035dd6-5185-45a5-a752-f639291cf8a5; Thu, 10 Dec 2020 11:44:04 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 6A49CAD7C; Thu, 10 Dec 2020 11:44:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e035dd6-5185-45a5-a752-f639291cf8a5 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607600643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xyHh1YlXh3D5krmV0gaGkpUq1r97cEDPdXsFnMllEUU=; b=DKqIeH3h5q0p4CZs6wwn6FxTbKhI9zOixC9FJO7NfZBsjB/ahZ6r/A9mad/xrbPy3Gap9C LELGFDR59flElH5Q1twrOzE0YU8aZJDECw7KHT+G4F8CFVCJQgjrV1My/H4i8dgOxNzcbh ks085czZLsNKo+fwWKzKiBLeCwX772U= Subject: Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories To: Julien Grall , xen-devel@lists.xenproject.org Cc: paul@xen.org, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu References: <20201209161618.309-1-jgross@suse.com> <20201209161618.309-3-jgross@suse.com> <75232058-4626-80cb-6f71-4ce5253f3ef6@xen.org> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: <8ec5f4f5-4314-9c4d-45f0-1f4686028a82@suse.com> Date: Thu, 10 Dec 2020 08:54:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <75232058-4626-80cb-6f71-4ce5253f3ef6@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gSdjpcUaNTrBpTrbsoW5JWlJUvXsbFLdP" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gSdjpcUaNTrBpTrbsoW5JWlJUvXsbFLdP Content-Type: multipart/mixed; boundary="H6xg0yS6hWU500hkl23Elp9371I9TLsmN"; protected-headers="v1" From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= To: Julien Grall , xen-devel@lists.xenproject.org Cc: paul@xen.org, Andrew Cooper , George Dunlap , Ian Jackson , Jan Beulich , Stefano Stabellini , Wei Liu Message-ID: <8ec5f4f5-4314-9c4d-45f0-1f4686028a82@suse.com> Subject: Re: [PATCH RFC 2/3] xen/domain: add domain hypfs directories References: <20201209161618.309-1-jgross@suse.com> <20201209161618.309-3-jgross@suse.com> <75232058-4626-80cb-6f71-4ce5253f3ef6@xen.org> In-Reply-To: <75232058-4626-80cb-6f71-4ce5253f3ef6@xen.org> --H6xg0yS6hWU500hkl23Elp9371I9TLsmN Content-Type: multipart/mixed; boundary="------------BB6929A11E713E9E6A013377" Content-Language: en-US This is a multi-part message in MIME format. --------------BB6929A11E713E9E6A013377 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 09.12.20 17:37, Julien Grall wrote: > Hi Juergen, >=20 > On 09/12/2020 16:16, Juergen Gross wrote: >> Add /domain/ directories to hypfs. Those are completely >> dynamic, so the related hypfs access functions need to be implemented.= >> >> Signed-off-by: Juergen Gross >> --- >> V3: >> - new patch >> --- >> =C2=A0 docs/misc/hypfs-paths.pandoc |=C2=A0 10 +++ >> =C2=A0 xen/common/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 1 + >> =C2=A0 xen/common/hypfs_dom.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 13= 7 +++++++++++++++++++++++++++++++++++ >> =C2=A0 3 files changed, 148 insertions(+) >> =C2=A0 create mode 100644 xen/common/hypfs_dom.c >> >> diff --git a/docs/misc/hypfs-paths.pandoc b/docs/misc/hypfs-paths.pand= oc >> index e86f7d0dbe..116642e367 100644 >> --- a/docs/misc/hypfs-paths.pandoc >> +++ b/docs/misc/hypfs-paths.pandoc >> @@ -34,6 +34,7 @@ not containing any '/' character. The names "." and = >> ".." are reserved >> =C2=A0 for file system internal use. >> =C2=A0 VALUES are strings and can take the following forms (note that = this=20 >> represents >> +>>>>>>> patched >=20 > This seems to be a left-over of a merge. Oh, interesting that I wasn't warned about that. >=20 >> =C2=A0 only the syntax used in this document): >> =C2=A0 * STRING -- an arbitrary 0-delimited byte string. >> @@ -191,6 +192,15 @@ The scheduling granularity of a cpupool. >> =C2=A0 Writing a value is allowed only for cpupools with no cpu assign= ed=20 >> and if the >> =C2=A0 architecture is supporting different scheduling granularities. >=20 > [...] >=20 >> + >> +static int domain_dir_read(const struct hypfs_entry *entry, >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 XEN_GUEST_HANDLE_PARAM(void) uaddr) >> +{ >> +=C2=A0=C2=A0=C2=A0 int ret =3D 0; >> +=C2=A0=C2=A0=C2=A0 const struct domain *d; >> + >> +=C2=A0=C2=A0=C2=A0 for_each_domain ( d ) >=20 > This is definitely going to be an issue if you have a lot of domain=20 > running as Xen is not preemptible. In general this is correct, but in this case I don't think it will be a problem. The execution time for each loop iteration should be rather short (in the microsecond range?), so even with 32000 guests we would stay way below one second. And on rather slow cpus I don't think we'd have thousands of guests anyway. > I think the first step is to make sure that HYPFS can scale without=20 > hogging a pCPU for a long time. I agree this would be best. Juergen --------------BB6929A11E713E9E6A013377 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------BB6929A11E713E9E6A013377-- --H6xg0yS6hWU500hkl23Elp9371I9TLsmN-- --gSdjpcUaNTrBpTrbsoW5JWlJUvXsbFLdP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAl/R1CIFAwAAAAAACgkQsN6d1ii/Ey+o Agf/SWKaghqbwtnyyuxoLT/6CiHvxLUovD62MWxPPBVQh6uBeO3rPHnOD5J4Tw7KlyZkD7Hxb9Gl 5IKh6TSEapBOGlnzF5ZiHyn9g1kOt6c6Bs047AxVfsU7r6L5HwhpgxSfGe9R9Yecq6wa6HiR0do/ 89ySZGPegJGJErvF7bXMEoPoBhhfWjYpCRy8hB4NKaMVAGDpGEbZemR6Q3b+Gb8SM2a4kyc8ZEaA +WAJDoZXMWMytrRelrhGh6SBlJJv/uFhDmvXCqDKsRRiKVwWKsuQkJtjyq5oaD8gh4JPWZBBnG75 3zDoWLCnMjIHyzo9iOt5b644nklKXulZ9/RT3frxKg== =bcmM -----END PGP SIGNATURE----- --gSdjpcUaNTrBpTrbsoW5JWlJUvXsbFLdP--