From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 03/11] drm/i915/execlists: Pull submit after
 dequeue under timeline lock
Date: Fri, 1 Jun 2018 15:02:38 +0100
Message-ID: <8ed79b89-38ec-2bd3-6ea4-9f97eec43625@linux.intel.com>
References: <20180531185204.19520-1-chris@chris-wilson.co.uk>
 <20180531185204.19520-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 341126E6B3
 for <intel-gfx@lists.freedesktop.org>; Fri,  1 Jun 2018 14:02:41 +0000 (UTC)
In-Reply-To: <20180531185204.19520-4-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDMxLzA1LzIwMTggMTk6NTEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgbmV4dCBw
YXRjaCwgd2Ugd2lsbCBiZWdpbiBwcm9jZXNzaW5nIHRoZSBDU0IgZnJvbSBpbnNpZGUgdGhlCj4g
aW50ZXJydXB0IGhhbmRsZXIuIFRoaXMgbWVhbnMgdGhhdCB1cGRhdGluZyB0aGUgZXhlY2xpc3Rz
LT5wb3J0W10gd2lsbAoKVGhlIG1lc3NhZ2UgdGhhdCB3ZSB3aWxsIGJlIHByb2Nlc3NpbmcgQ1NC
IGZyb20gaXJxIGhhbmRsZXIsIGhlcmUgYW5kIGluIApmb2xsb3dpbmcgcGF0Y2ggNS8xMSwgZG9l
c24ndCBzZWVtIHRvIGJlIHRydWUuIFNvIHdoeSBpcyB0aGlzIG5lZWRlZD8gCldoeSBub3QganVz
dCBkcm9wIHNvbWUgcGF0Y2hlcyBmcm9tIHRoZSBzZXJpZXM/CgpSZWdhcmRzLAoKVHZydGtvCgo+
IG5vIGxvbmdlciBiZSBsb2NrZWQgYnkgdGhlIHRhc2tsZXQgYnV0IGJ5IHRoZSBlbmdpbmUtPnRp
bWVsaW5lLmxvY2sKPiBpbnN0ZWFkLiBQdWxsIGRlcXVldWUgYW5kIHN1Ym1pdCB1bmRlciB0aGUg
c2FtZSBsb2NrIGZvciBwcm90ZWN0aW9uLgo+IChBbiBhbHRlcm5hdGl2ZSwgZnV0dXJlLCBwbGFu
IGlzIHRvIGtlZXAgdGhlIGluL291dCBhcnJheXMgc2VwYXJhdGUgZm9yCj4gY29uY3VycmVudCBw
cm9jZXNzaW5nIGFuZCByZWR1Y2VkIGxvY2sgY292ZXJhZ2UuKQo+IAo+IFNpZ25lZC1vZmYtYnk6
IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAzMiArKysrKysrKysrKystLS0tLS0tLS0tLS0t
LS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9u
cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggZTVjZjA0OWMxOGY4Li5k
MjA3YTFiZjlkYzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj
LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC01NjIsNyAr
NTYyLDcgQEAgc3RhdGljIHZvaWQgY29tcGxldGVfcHJlZW1wdF9jb250ZXh0KHN0cnVjdCBpbnRl
bF9lbmdpbmVfZXhlY2xpc3RzICpleGVjbGlzdHMpCj4gICAJZXhlY2xpc3RzX2NsZWFyX2FjdGl2
ZShleGVjbGlzdHMsIEVYRUNMSVNUU19BQ1RJVkVfUFJFRU1QVCk7Cj4gICB9Cj4gICAKPiAtc3Rh
dGljIGJvb2wgX19leGVjbGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp
bmUpCj4gK3N0YXRpYyB2b2lkIF9fZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2lu
ZV9jcyAqZW5naW5lKQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfZXhlY2xpc3RzICog
Y29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3RzOwo+ICAgCXN0cnVjdCBleGVjbGlz
dF9wb3J0ICpwb3J0ID0gZXhlY2xpc3RzLT5wb3J0Owo+IEBAIC02MTcsMTEgKzYxNywxMSBAQCBz
dGF0aWMgYm9vbCBfX2V4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu
Z2luZSkKPiAgIAkJICogdGhlIEhXIHRvIGluZGljYXRlIHRoYXQgaXQgaGFzIGhhZCBhIGNoYW5j
ZSB0byByZXNwb25kLgo+ICAgCQkgKi8KPiAgIAkJaWYgKCFleGVjbGlzdHNfaXNfYWN0aXZlKGV4
ZWNsaXN0cywgRVhFQ0xJU1RTX0FDVElWRV9IV0FDSykpCj4gLQkJCXJldHVybiBmYWxzZTsKPiAr
CQkJcmV0dXJuOwo+ICAgCj4gICAJCWlmIChuZWVkX3ByZWVtcHQoZW5naW5lLCBsYXN0LCBleGVj
bGlzdHMtPnF1ZXVlX3ByaW9yaXR5KSkgewo+ICAgCQkJaW5qZWN0X3ByZWVtcHRfY29udGV4dChl
bmdpbmUpOwo+IC0JCQlyZXR1cm4gZmFsc2U7Cj4gKwkJCXJldHVybjsKPiAgIAkJfQo+ICAgCj4g
ICAJCS8qCj4gQEAgLTY0Niw3ICs2NDYsNyBAQCBzdGF0aWMgYm9vbCBfX2V4ZWNsaXN0c19kZXF1
ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkJICogcHJpb3JpdGllcyBv
ZiB0aGUgcG9ydHMgaGF2ZW4ndCBiZWVuIHN3aXRjaC4KPiAgIAkJICovCj4gICAJCWlmIChwb3J0
X2NvdW50KCZwb3J0WzFdKSkKPiAtCQkJcmV0dXJuIGZhbHNlOwo+ICsJCQlyZXR1cm47Cj4gICAK
PiAgIAkJLyoKPiAgIAkJICogV2FJZGxlTGl0ZVJlc3RvcmU6YmR3LHNrbAo+IEBAIC03NDYsOCAr
NzQ2LDEwIEBAIHN0YXRpYyBib29sIF9fZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0IGludGVsX2Vu
Z2luZV9jcyAqZW5naW5lKQo+ICAgCQlwb3J0ICE9IGV4ZWNsaXN0cy0+cG9ydCA/IHJxX3ByaW8o
bGFzdCkgOiBJTlRfTUlOOwo+ICAgCj4gICAJZXhlY2xpc3RzLT5maXJzdCA9IHJiOwo+IC0JaWYg
KHN1Ym1pdCkKPiArCWlmIChzdWJtaXQpIHsKPiAgIAkJcG9ydF9hc3NpZ24ocG9ydCwgbGFzdCk7
Cj4gKwkJZXhlY2xpc3RzX3N1Ym1pdF9wb3J0cyhlbmdpbmUpOwo+ICsJfQo+ICAgCj4gICAJLyog
V2UgbXVzdCBhbHdheXMga2VlcCB0aGUgYmVhc3QgZmVkIGlmIHdlIGhhdmUgd29yayBwaWxlZCB1
cCAqLwo+ICAgCUdFTV9CVUdfT04oZXhlY2xpc3RzLT5maXJzdCAmJiAhcG9ydF9pc3NldChleGVj
bGlzdHMtPnBvcnQpKTsKPiBAQCAtNzU2LDI0ICs3NTgsMTkgQEAgc3RhdGljIGJvb2wgX19leGVj
bGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJaWYgKGxh
c3QpCj4gICAJCWV4ZWNsaXN0c191c2VyX2JlZ2luKGV4ZWNsaXN0cywgZXhlY2xpc3RzLT5wb3J0
KTsKPiAgIAo+IC0JcmV0dXJuIHN1Ym1pdDsKPiArCS8qIElmIHRoZSBlbmdpbmUgaXMgbm93IGlk
bGUsIHNvIHNob3VsZCBiZSB0aGUgZmxhZzsgYW5kIHZpY2UgdmVyc2EuICovCj4gKwlHRU1fQlVH
X09OKGV4ZWNsaXN0c19pc19hY3RpdmUoJmVuZ2luZS0+ZXhlY2xpc3RzLAo+ICsJCQkJICAgICAg
IEVYRUNMSVNUU19BQ1RJVkVfVVNFUikgPT0KPiArCQkgICAhcG9ydF9pc3NldChlbmdpbmUtPmV4
ZWNsaXN0cy5wb3J0KSk7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1
ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAtCXN0cnVjdCBpbnRl
bF9lbmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3Rz
Owo+ICAgCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gLQlib29sIHN1Ym1pdDsKPiAgIAo+ICAgCXNw
aW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiAtCXN1Ym1p
dCA9IF9fZXhlY2xpc3RzX2RlcXVldWUoZW5naW5lKTsKPiArCV9fZXhlY2xpc3RzX2RlcXVldWUo
ZW5naW5lKTsKPiAgIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLmxv
Y2ssIGZsYWdzKTsKPiAtCj4gLQlpZiAoc3VibWl0KQo+IC0JCWV4ZWNsaXN0c19zdWJtaXRfcG9y
dHMoZW5naW5lKTsKPiAtCj4gLQlHRU1fQlVHX09OKHBvcnRfaXNzZXQoZXhlY2xpc3RzLT5wb3J0
KSAmJgo+IC0JCSAgICFleGVjbGlzdHNfaXNfYWN0aXZlKGV4ZWNsaXN0cywgRVhFQ0xJU1RTX0FD
VElWRV9VU0VSKSk7Cj4gICB9Cj4gICAKPiAgIHZvaWQKPiBAQCAtMTE1NiwxMSArMTE1Myw2IEBA
IHN0YXRpYyB2b2lkIGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQodW5zaWduZWQgbG9uZyBk
YXRhKQo+ICAgCj4gICAJaWYgKCFleGVjbGlzdHNfaXNfYWN0aXZlKCZlbmdpbmUtPmV4ZWNsaXN0
cywgRVhFQ0xJU1RTX0FDVElWRV9QUkVFTVBUKSkKPiAgIAkJZXhlY2xpc3RzX2RlcXVldWUoZW5n
aW5lKTsKPiAtCj4gLQkvKiBJZiB0aGUgZW5naW5lIGlzIG5vdyBpZGxlLCBzbyBzaG91bGQgYmUg
dGhlIGZsYWc7IGFuZCB2aWNlIHZlcnNhLiAqLwo+IC0JR0VNX0JVR19PTihleGVjbGlzdHNfaXNf
YWN0aXZlKCZlbmdpbmUtPmV4ZWNsaXN0cywKPiAtCQkJCSAgICAgICBFWEVDTElTVFNfQUNUSVZF
X1VTRVIpID09Cj4gLQkJICAgIXBvcnRfaXNzZXQoZW5naW5lLT5leGVjbGlzdHMucG9ydCkpOwo+
ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBxdWV1ZV9yZXF1ZXN0KHN0cnVjdCBpbnRlbF9lbmdp
bmVfY3MgKmVuZ2luZSwKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0
b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50
ZWwtZ2Z4Cg==