From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 3/7] Kernel: cobalt: workaround of BUILD_BUG_ON error on v4.18 References: <20190305144521.2567-1-roman.stratiienko@globallogic.com> <20190305144521.2567-3-roman.stratiienko@globallogic.com> From: Jan Kiszka Message-ID: <8ede93b4-a8ed-52f3-afcf-52f1710cc34c@siemens.com> Date: Tue, 5 Mar 2019 19:00:33 +0100 MIME-Version: 1.0 In-Reply-To: <20190305144521.2567-3-roman.stratiienko@globallogic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: roman.stratiienko@globallogic.com, xenomai@xenomai.org On 05.03.19 15:45, roman.stratiienko--- via Xenomai wrote: > From: Roman Stratiienko > > After kernel v4.18 commit 4a0772cf0674 > ("tracing: Prevent further users of zero size static arrays in trace events") > creating zero length arrays will force compile-time error > > Signed-off-by: Roman Stratiienko > --- > kernel/cobalt/trace/cobalt-posix.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/cobalt/trace/cobalt-posix.h b/kernel/cobalt/trace/cobalt-posix.h > index 77392e725..3a87cc610 100644 > --- a/kernel/cobalt/trace/cobalt-posix.h > +++ b/kernel/cobalt/trace/cobalt-posix.h > @@ -266,7 +266,7 @@ DECLARE_EVENT_CLASS(cobalt_void, > TP_PROTO(int dummy), > TP_ARGS(dummy), > TP_STRUCT__entry( > - __array(char, dummy, 0) > + __array(char, dummy, 1) Let's just do "__field(int, dummy)" at this chance. I'll have to adjust some tracing patch as well that is currently in next. > ), > TP_fast_assign( > (void)dummy; > Jan -- Siemens AG, Corporate Technology, CT RDA IOT SES-DE Corporate Competence Center Embedded Linux