Re: [PATCH] x86/xen: Add "xen_timer_slop" command line option

From: Dario Faggioli <dfaggioli@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	Ryan Thibodeaux <thibodux@gmail.com>
Cc: jgross@suse.com, oleksandr_andrushchenko@epam.com,
	"luca.abeni" <luca.abeni@santannapisa.it>,
	linux-kernel@vger.kernel.org, ryan.thibodeaux@starlab.io,
	xen-devel@lists.xenproject.org, tglx@linutronix.de
Subject: Re: [PATCH] x86/xen: Add "xen_timer_slop" command line option
Date: Mon, 25 Mar 2019 11:36:00 +0100	[thread overview]
Message-ID: <8eec0949bac18d8ee6f151027ff68de9827f143d.camel__17983.1970877544$1553510268$gmane$org@suse.com> (raw)
In-Reply-To: <20190324180724.GA4400@nat-wireless-guest-reg-153-50.bu.edu>

[-- Attachment #1.1: Type: text/plain, Size: 1940 bytes --]

On Sun, 2019-03-24 at 14:07 -0400, Boris Ostrovsky wrote:
> On Sat, Mar 23, 2019 at 08:00:52AM -0400, Ryan Thibodeaux wrote:
> > This test system was configured to use a TSC clocksource, disabled
> > C states, and lowered the timer slop. I am not claiming the timer
> > slop change was solely responsible for the best results.
> 
> How can we then be sure that the proposed change will indeed provide
> some sort of benefit?
> 
> Were there any other changes between your tests to think that slop
> time modification may not be responsible for better results?
> 
FWIW, in mine and Luca's experiments, changing lowering both timer_slop
in Xen and TIMER_SLOP in Linux, improved latency dramatically, without
any other change.

We also tried _only_ playing with the Xen tunable (as there's a Xen
boot parameter for it already) but that wasn't enough. It was only when
we also tuned TIMER_SLOP in Linux's Xen clockevent device that we got
decent numbers (i.e., comparable to KVM ones).

Reason why we had not share these results yet was that we were still
"polishing" them, and because we also found a couple of other issues,
and we were trying to understand them better, before sending anything
out. But those other issues were --although still about achieving low
latencies-- orthogonal from this, and lowering the default slop is
absolute prerequisite for even talking about having a reasonable vcpu
response time.

A patch like this one, was something we were thinking to submit ourself
sooner or later (backed up by our results). Personally, in addition to
making the value tunable, which I think is a good thing, I also would
lower the default.

Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel