All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Julien Grall <julien.grall@arm.com>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 2/2] x86/pv: Align %rsp before pushing the failsafe stack frame
Date: Mon, 8 May 2017 11:58:07 +0100	[thread overview]
Message-ID: <8eefdafe-3220-bcea-5b12-04112056c009@citrix.com> (raw)
In-Reply-To: <59106B0A0200007800157AB4@prv-mh.provo.novell.com>

On 08/05/17 11:56, Jan Beulich wrote:
>>>> On 08.05.17 at 12:04, <andrew.cooper3@citrix.com> wrote:
>> Architecturally, all 64bit stacks are aligned on a 16 byte boundary before an
>> exception frame is pushed.  The failsafe frame is not special in this regard.
> I'd prefer "should not be" as effectively is has been so far, but other
> than that ...

Certainly.

>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>

Thanks.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2017-05-08 10:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 10:04 [PATCH for-4.9 0/2] x86/pv: Misc fixes Andrew Cooper
2017-05-08 10:04 ` [PATCH 1/2] x86/pv: Fix bugs with the handling of int80_bounce Andrew Cooper
2017-05-08 10:52   ` Jan Beulich
2017-05-08 12:23     ` Andrew Cooper
2017-05-08 12:39       ` Jan Beulich
2017-05-08 12:54         ` Andrew Cooper
2017-05-08 13:05           ` Jan Beulich
2017-05-08 10:04 ` [PATCH 2/2] x86/pv: Align %rsp before pushing the failsafe stack frame Andrew Cooper
2017-05-08 10:56   ` Jan Beulich
2017-05-08 10:58     ` Andrew Cooper [this message]
2017-05-09 15:47 ` [PATCH for-4.9 0/2] x86/pv: Misc fixes Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8eefdafe-3220-bcea-5b12-04112056c009@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=julien.grall@arm.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.