From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755261AbeDWOhk (ORCPT ); Mon, 23 Apr 2018 10:37:40 -0400 Received: from mail.micronovasrl.com ([212.103.203.10]:45938 "EHLO mail.micronovasrl.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755376AbeDWOhh (ORCPT ); Mon, 23 Apr 2018 10:37:37 -0400 Authentication-Results: mail.micronovasrl.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=micronovasrl.com X-Spam-Flag: NO X-Spam-Score: -2.9 Subject: Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI To: Maxime Ripard Cc: Thierry Reding , David Airlie , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org References: <1521662593-25468-1-git-send-email-giulio.benetti@micronovasrl.com> <1521662593-25468-7-git-send-email-giulio.benetti@micronovasrl.com> <20180322180508.my64gobhh5rc2x2m@flea> From: Giulio Benetti Message-ID: <8ef3b259-03b4-6987-286e-36ff627a8b76@micronovasrl.com> Date: Mon, 23 Apr 2018 16:37:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180322180508.my64gobhh5rc2x2m@flea> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: it Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Il 22/03/2018 19:05, Maxime Ripard ha scritto: > On Wed, Mar 21, 2018 at 09:03:13PM +0100, Giulio Benetti wrote: >> The A20-Linova1-7 HMI, also called Q027_2_F which is printed on production >> label, is an industrial Human Machine Interface. >> It features: >> - 512MB DDR RAM >> - 1 Sd-card >= 4GB >> - 1 Usb otg(programmable via software) with A-Usb Connector >> - 1 Usb host >> - 1 Buzzer >> - 1 Input for LiPo >> - 1 Relay to signal absence of power supply >> - 1 External Rtc with 56 bytes of ram + CR2032 battery >> - 1 7" 24-bits Tft 800x480 with PCap on >> - 1 Mono audio 1-watt amplifier >> - 1 RS485 port >> - 1 Power On Line through +12Vdc reaching 57.600baud, >> from where it can be supplied and placed in a network of 50 units >> - exposed jtag pins >> >> HMI is supplied from +12Vdc. >> Ethernet is absent, so for debugging, need to enable rndis on Usb otg >> port through an A-A usb cable. >> It comes in different flavours for connector types and can be found with >> umounted features as requested by customers. > > So this is essentially the same board than in patch 6, but with a > different screen? > > You should have a single DT then, and handle the two different panels > using DT overlays. Ok for having different DT overlays. But do I have to submit them as patches? Or keep them in my company's repo? I ask you this because this involves sending also patches for displays and other little modifications to mainline ex: - rgb888 pins - 2 simple-panels - 1 uart iomux pins etc. If I don't submit those overlays, the other patches wouldn't make sense alone as I've seen, just like rgb888 pins. > >> Signed-off-by: Giulio Benetti >> --- >> .../devicetree/bindings/arm/micronova.txt | 4 + >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts | 192 +++++++++++++++++++++ >> 3 files changed, 197 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> >> diff --git a/Documentation/devicetree/bindings/arm/micronova.txt b/Documentation/devicetree/bindings/arm/micronova.txt >> index 35c4127..9f5ac72 100644 >> --- a/Documentation/devicetree/bindings/arm/micronova.txt >> +++ b/Documentation/devicetree/bindings/arm/micronova.txt >> @@ -4,3 +4,7 @@ Micronova Device Tree Bindings >> A20-LiNova1-4_3 HMI >> Required root node properties: >> - compatible = "micronova,a20-linova1-ctp-4_3i", "allwinner,sun7i-a20"; >> + >> +A20-LiNova1-7 HMI >> +Required root node properties: >> + - compatible = "micronova,a20-linova1-ctp-7i", "allwinner,sun7i-a20"; > > These bindings are unnecessary, but the panel-simple bindings should > be sent to the DT maintainers as well. Ok, removed them and already sent the ones for display. > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index c45a4f25..eafa7cb 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -942,6 +942,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \ >> sun7i-a20-m3.dtb \ >> sun7i-a20-mk808c.dtb \ >> sun7i-a20-linova1-ctp-4_3i.dtb\ >> + sun7i-a20-linova1-ctp-7i.dtb\ > > You should have a space after dtb, and it should be ordered > alphabetically. Done. > >> sun7i-a20-olimex-som-evb.dtb \ >> sun7i-a20-olinuxino-lime.dtb \ >> sun7i-a20-olinuxino-lime2.dtb \ >> diff --git a/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts b/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> new file mode 100644 >> index 0000000..7fd0d98 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> @@ -0,0 +1,192 @@ >> +/* >> + * This is based on sun7i-a20-linova1-ctp-7i.dts >> + * >> + * Copyright 2014 - Hans de Goede >> + * Copyright (c) 2014 FUKAUMI Naoki >> + * Copyright (c) 2018 Giulio Benetti >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ > > You should use an SPDX license header here. Done > >> + >> +/dts-v1/; >> +#include "sun7i-a20.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include >> +#include >> + >> +/ { >> + model = "Micronova srl LiNova1 CTP 7i"; >> + compatible = "micronova,a20-linova1-ctp-7i", "allwinner,sun7i-a20"; >> + >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + panel: panel { >> + compatible = "cdtech,s070wv95-ct16", "simple-panel"; >> + power-supply = <®_vcc3v3>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel_input: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&tcon0_out_panel>; >> + }; >> + }; >> + }; >> +}; >> + >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> +&ehci1 { >> + status = "okay"; >> +}; >> + >> +&i2c0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c0_pins_a>; >> + status = "okay"; >> + >> + axp209: pmic@34 { >> + compatible = "x-powers,axp209"; >> + reg = <0x34>; >> + interrupt-parent = <&nmi_intc>; >> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> + >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + }; >> +}; >> + >> +&i2c2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pins_a>; >> + status = "okay"; >> + >> + ft5x: touchscreen@38 { >> + compatible = "edt,edt-ft5206"; >> + reg = <0x38>; >> + interrupt-parent = <&pio>; >> + interrupts = <7 2 IRQ_TYPE_EDGE_FALLING>; /* PH2 */ >> + reset-gpios = <&pio 7 3 GPIO_ACTIVE_LOW>; /* PH3 */ >> + touchscreen-size-x = <800>; >> + touchscreen-size-y = <480>; >> + }; >> +}; >> + >> +&mmc0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&mmc0_pins_a>; >> + vmmc-supply = <®_vcc3v3>; >> + bus-width = <4>; >> + cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ >> + cd-inverted; >> + status = "okay"; >> +}; >> + >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> +&ohci1 { >> + status = "okay"; >> +}; >> + >> +&otg_sram { >> + status = "okay"; >> +}; >> + >> +®_usb0_vbus { >> + status = "okay"; >> +}; >> + >> +®_usb1_vbus { >> + status = "okay"; >> +}; > > Ideally you should be defining the regulators here too. Added. > >> +&uart0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_pins_a>; >> + status = "okay"; >> +}; >> + >> +&usb_otg { >> + dr_mode = "otg"; > > You're saying that this is a USB-A connector? Then it's not OTG since > it doesn't have an ID pin, this is an host. Right, with a special overlay I will activate Usb Device for RNDIS, so modified as host > >> + status = "okay"; >> +}; >> + >> +&usbphy { >> + pinctrl-names = "default"; >> + usb0_vbus-supply = <®_usb0_vbus>; >> + usb1_vbus-supply = <®_usb1_vbus>; >> + status = "okay"; >> +}; >> + >> +&be0 { >> + status = "okay"; >> +}; >> + >> +&de { >> + status = "okay"; >> +}; > > The nodes should be ordered by alphabetical order. Done. One last question: now I have some patch already reviewed-by. Do I have to re-submit entire patchset? Thank you very much. -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > Thanks! > Maxime > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giulio Benetti Subject: Re: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI Date: Mon, 23 Apr 2018 16:37:33 +0200 Message-ID: <8ef3b259-03b4-6987-286e-36ff627a8b76@micronovasrl.com> References: <1521662593-25468-1-git-send-email-giulio.benetti@micronovasrl.com> <1521662593-25468-7-git-send-email-giulio.benetti@micronovasrl.com> <20180322180508.my64gobhh5rc2x2m@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180322180508.my64gobhh5rc2x2m@flea> Content-Language: it List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Thierry Reding , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGksCgpJbCAyMi8wMy8yMDE4IDE5OjA1LCBNYXhpbWUgUmlwYXJkIGhhIHNjcml0dG86Cj4gT24g V2VkLCBNYXIgMjEsIDIwMTggYXQgMDk6MDM6MTNQTSArMDEwMCwgR2l1bGlvIEJlbmV0dGkgd3Jv dGU6Cj4+IFRoZSBBMjAtTGlub3ZhMS03IEhNSSwgYWxzbyBjYWxsZWQgUTAyN18yX0Ygd2hpY2gg aXMgcHJpbnRlZCBvbiBwcm9kdWN0aW9uCj4+IGxhYmVsLCBpcyBhbiBpbmR1c3RyaWFsIEh1bWFu IE1hY2hpbmUgSW50ZXJmYWNlLgo+PiBJdCBmZWF0dXJlczoKPj4gLSA1MTJNQiBERFIgUkFNCj4+ IC0gMSBTZC1jYXJkID49IDRHQgo+PiAtIDEgVXNiIG90Zyhwcm9ncmFtbWFibGUgdmlhIHNvZnR3 YXJlKSB3aXRoIEEtVXNiIENvbm5lY3Rvcgo+PiAtIDEgVXNiIGhvc3QKPj4gLSAxIEJ1enplcgo+ PiAtIDEgSW5wdXQgZm9yIExpUG8KPj4gLSAxIFJlbGF5IHRvIHNpZ25hbCBhYnNlbmNlIG9mIHBv d2VyIHN1cHBseQo+PiAtIDEgRXh0ZXJuYWwgUnRjIHdpdGggNTYgYnl0ZXMgb2YgcmFtICsgQ1Iy MDMyIGJhdHRlcnkKPj4gLSAxIDciIDI0LWJpdHMgVGZ0IDgwMHg0ODAgd2l0aCBQQ2FwIG9uCj4+ IC0gMSBNb25vIGF1ZGlvIDEtd2F0dCBhbXBsaWZpZXIKPj4gLSAxIFJTNDg1IHBvcnQKPj4gLSAx IFBvd2VyIE9uIExpbmUgdGhyb3VnaCArMTJWZGMgcmVhY2hpbmcgNTcuNjAwYmF1ZCwKPj4gICAg ZnJvbSB3aGVyZSBpdCBjYW4gYmUgc3VwcGxpZWQgYW5kIHBsYWNlZCBpbiBhIG5ldHdvcmsgb2Yg NTAgdW5pdHMKPj4gLSBleHBvc2VkIGp0YWcgcGlucwo+Pgo+PiBITUkgaXMgc3VwcGxpZWQgZnJv bSArMTJWZGMuCj4+IEV0aGVybmV0IGlzIGFic2VudCwgc28gZm9yIGRlYnVnZ2luZywgbmVlZCB0 byBlbmFibGUgcm5kaXMgb24gVXNiIG90Zwo+PiBwb3J0IHRocm91Z2ggYW4gQS1BIHVzYiBjYWJs ZS4KPj4gSXQgY29tZXMgaW4gZGlmZmVyZW50IGZsYXZvdXJzIGZvciBjb25uZWN0b3IgdHlwZXMg YW5kIGNhbiBiZSBmb3VuZCB3aXRoCj4+IHVtb3VudGVkIGZlYXR1cmVzIGFzIHJlcXVlc3RlZCBi eSBjdXN0b21lcnMuCj4gCj4gU28gdGhpcyBpcyBlc3NlbnRpYWxseSB0aGUgc2FtZSBib2FyZCB0 aGFuIGluIHBhdGNoIDYsIGJ1dCB3aXRoIGEKPiBkaWZmZXJlbnQgc2NyZWVuPwo+IAo+IFlvdSBz aG91bGQgaGF2ZSBhIHNpbmdsZSBEVCB0aGVuLCBhbmQgaGFuZGxlIHRoZSB0d28gZGlmZmVyZW50 IHBhbmVscwo+IHVzaW5nIERUIG92ZXJsYXlzLgoKT2sgZm9yIGhhdmluZyBkaWZmZXJlbnQgRFQg b3ZlcmxheXMuCkJ1dCBkbyBJIGhhdmUgdG8gc3VibWl0IHRoZW0gYXMgcGF0Y2hlcz8gT3Iga2Vl cCB0aGVtIGluIG15IGNvbXBhbnkncyByZXBvPwpJIGFzayB5b3UgdGhpcyBiZWNhdXNlIHRoaXMg aW52b2x2ZXMgc2VuZGluZyBhbHNvIHBhdGNoZXMgZm9yIGRpc3BsYXlzCmFuZCBvdGhlciBsaXR0 bGUgbW9kaWZpY2F0aW9ucyB0byBtYWlubGluZSBleDoKLSByZ2I4ODggcGlucwotIDIgc2ltcGxl LXBhbmVscwotIDEgdWFydCBpb211eCBwaW5zCmV0Yy4KCklmIEkgZG9uJ3Qgc3VibWl0IHRob3Nl IG92ZXJsYXlzLCB0aGUgb3RoZXIgcGF0Y2hlcyB3b3VsZG4ndCBtYWtlIHNlbnNlIAphbG9uZSBh cyBJJ3ZlIHNlZW4sIGp1c3QgbGlrZSByZ2I4ODggcGlucy4KCj4gCj4+IFNpZ25lZC1vZmYtYnk6 IEdpdWxpbyBCZW5ldHRpIDxnaXVsaW8uYmVuZXR0aUBtaWNyb25vdmFzcmwuY29tPgo+PiAtLS0K Pj4gICAuLi4vZGV2aWNldHJlZS9iaW5kaW5ncy9hcm0vbWljcm9ub3ZhLnR4dCAgICAgICAgICB8 ICAgNCArCj4+ICAgYXJjaC9hcm0vYm9vdC9kdHMvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDEgKwo+PiAgIGFyY2gvYXJtL2Jvb3QvZHRzL3N1bjdpLWEyMC1saW5vdmExLWN0 cC03aS5kdHMgICAgIHwgMTkyICsrKysrKysrKysrKysrKysrKysrKwo+PiAgIDMgZmlsZXMgY2hh bmdlZCwgMTk3IGluc2VydGlvbnMoKykKPj4gICBjcmVhdGUgbW9kZSAxMDA2NDQgYXJjaC9hcm0v Ym9vdC9kdHMvc3VuN2ktYTIwLWxpbm92YTEtY3RwLTdpLmR0cwo+Pgo+PiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9taWNyb25vdmEudHh0IGIvRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2FybS9taWNyb25vdmEudHh0Cj4+IGluZGV4 IDM1YzQxMjcuLjlmNWFjNzIgMTAwNjQ0Cj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9hcm0vbWljcm9ub3ZhLnR4dAo+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvYXJtL21pY3Jvbm92YS50eHQKPj4gQEAgLTQsMyArNCw3IEBAIE1pY3Jv bm92YSBEZXZpY2UgVHJlZSBCaW5kaW5ncwo+PiAgIEEyMC1MaU5vdmExLTRfMyBITUkKPj4gICBS ZXF1aXJlZCByb290IG5vZGUgcHJvcGVydGllczoKPj4gICAgICAgLSBjb21wYXRpYmxlID0gIm1p Y3Jvbm92YSxhMjAtbGlub3ZhMS1jdHAtNF8zaSIsICJhbGx3aW5uZXIsc3VuN2ktYTIwIjsKPj4g Kwo+PiArQTIwLUxpTm92YTEtNyBITUkKPj4gK1JlcXVpcmVkIHJvb3Qgbm9kZSBwcm9wZXJ0aWVz Ogo+PiArICAgIC0gY29tcGF0aWJsZSA9ICJtaWNyb25vdmEsYTIwLWxpbm92YTEtY3RwLTdpIiwg ImFsbHdpbm5lcixzdW43aS1hMjAiOwo+IAo+IFRoZXNlIGJpbmRpbmdzIGFyZSB1bm5lY2Vzc2Fy eSwgYnV0IHRoZSBwYW5lbC1zaW1wbGUgYmluZGluZ3Mgc2hvdWxkCj4gYmUgc2VudCB0byB0aGUg RFQgbWFpbnRhaW5lcnMgYXMgd2VsbC4KCk9rLCByZW1vdmVkIHRoZW0gYW5kIGFscmVhZHkgc2Vu dCB0aGUgb25lcyBmb3IgZGlzcGxheS4KCj4gCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290 L2R0cy9NYWtlZmlsZSBiL2FyY2gvYXJtL2Jvb3QvZHRzL01ha2VmaWxlCj4+IGluZGV4IGM0NWE0 ZjI1Li5lYWZhN2NiIDEwMDY0NAo+PiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9NYWtlZmlsZQo+ PiArKysgYi9hcmNoL2FybS9ib290L2R0cy9NYWtlZmlsZQo+PiBAQCAtOTQyLDYgKzk0Miw3IEBA IGR0Yi0kKENPTkZJR19NQUNIX1NVTjdJKSArPSBcCj4+ICAgCXN1bjdpLWEyMC1tMy5kdGIgXAo+ PiAgIAlzdW43aS1hMjAtbWs4MDhjLmR0YiBcCj4+ICAgCXN1bjdpLWEyMC1saW5vdmExLWN0cC00 XzNpLmR0YlwKPj4gKwlzdW43aS1hMjAtbGlub3ZhMS1jdHAtN2kuZHRiXAo+IAo+IFlvdSBzaG91 bGQgaGF2ZSBhIHNwYWNlIGFmdGVyIGR0YiwgYW5kIGl0IHNob3VsZCBiZSBvcmRlcmVkCj4gYWxw aGFiZXRpY2FsbHkuCgpEb25lLgoKPiAKPj4gICAJc3VuN2ktYTIwLW9saW1leC1zb20tZXZiLmR0 YiBcCj4+ICAgCXN1bjdpLWEyMC1vbGludXhpbm8tbGltZS5kdGIgXAo+PiAgIAlzdW43aS1hMjAt b2xpbnV4aW5vLWxpbWUyLmR0YiBcCj4+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0cy9z dW43aS1hMjAtbGlub3ZhMS1jdHAtN2kuZHRzIGIvYXJjaC9hcm0vYm9vdC9kdHMvc3VuN2ktYTIw LWxpbm92YTEtY3RwLTdpLmR0cwo+PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+PiBpbmRleCAwMDAw MDAwLi43ZmQwZDk4Cj4+IC0tLSAvZGV2L251bGwKPj4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMv c3VuN2ktYTIwLWxpbm92YTEtY3RwLTdpLmR0cwo+PiBAQCAtMCwwICsxLDE5MiBAQAo+PiArLyoK Pj4gKyAqIFRoaXMgaXMgYmFzZWQgb24gc3VuN2ktYTIwLWxpbm92YTEtY3RwLTdpLmR0cwo+PiAr ICoKPj4gKyAqIENvcHlyaWdodCAyMDE0IC0gSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0 LmNvbT4KPj4gKyAqIENvcHlyaWdodCAoYykgMjAxNCBGVUtBVU1JIE5hb2tpIDxuYW9ic2RAZ21h aWwuY29tPgo+PiArICogQ29weXJpZ2h0IChjKSAyMDE4IEdpdWxpbyBCZW5ldHRpIDxnaXVsaW8u YmVuZXR0aUBtaWNyb25vdmFzcmwuY29tPgo+PiArICoKPj4gKyAqIFRoaXMgZmlsZSBpcyBkdWFs LWxpY2Vuc2VkOiB5b3UgY2FuIHVzZSBpdCBlaXRoZXIgdW5kZXIgdGhlIHRlcm1zCj4+ICsgKiBv ZiB0aGUgR1BMIG9yIHRoZSBYMTEgbGljZW5zZSwgYXQgeW91ciBvcHRpb24uIE5vdGUgdGhhdCB0 aGlzIGR1YWwKPj4gKyAqIGxpY2Vuc2luZyBvbmx5IGFwcGxpZXMgdG8gdGhpcyBmaWxlLCBhbmQg bm90IHRoaXMgcHJvamVjdCBhcyBhCj4+ICsgKiB3aG9sZS4KPj4gKyAqCj4+ICsgKiAgYSkgVGhp cyBmaWxlIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgo+ PiArICogICAgIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlIGFzCj4+ICsgKiAgICAgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJl IEZvdW5kYXRpb247IGVpdGhlciB2ZXJzaW9uIDIgb2YgdGhlCj4+ICsgKiAgICAgTGljZW5zZSwg b3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KPj4gKyAqCj4+ICsgKiAgICAg VGhpcyBmaWxlIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2Vm dWwsCj4+ICsgKiAgICAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3aXRob3V0IGV2ZW4gdGhl IGltcGxpZWQgd2FycmFudHkgb2YKPj4gKyAqICAgICBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVT UyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCj4+ICsgKiAgICAgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4KPj4gKyAqCj4+ICsgKiBPciwgYWx0 ZXJuYXRpdmVseSwKPj4gKyAqCj4+ICsgKiAgYikgUGVybWlzc2lvbiBpcyBoZXJlYnkgZ3JhbnRl ZCwgZnJlZSBvZiBjaGFyZ2UsIHRvIGFueSBwZXJzb24KPj4gKyAqICAgICBvYnRhaW5pbmcgYSBj b3B5IG9mIHRoaXMgc29mdHdhcmUgYW5kIGFzc29jaWF0ZWQgZG9jdW1lbnRhdGlvbgo+PiArICog ICAgIGZpbGVzICh0aGUgIlNvZnR3YXJlIiksIHRvIGRlYWwgaW4gdGhlIFNvZnR3YXJlIHdpdGhv dXQKPj4gKyAqICAgICByZXN0cmljdGlvbiwgaW5jbHVkaW5nIHdpdGhvdXQgbGltaXRhdGlvbiB0 aGUgcmlnaHRzIHRvIHVzZSwKPj4gKyAqICAgICBjb3B5LCBtb2RpZnksIG1lcmdlLCBwdWJsaXNo LCBkaXN0cmlidXRlLCBzdWJsaWNlbnNlLCBhbmQvb3IKPj4gKyAqICAgICBzZWxsIGNvcGllcyBv ZiB0aGUgU29mdHdhcmUsIGFuZCB0byBwZXJtaXQgcGVyc29ucyB0byB3aG9tIHRoZQo+PiArICog ICAgIFNvZnR3YXJlIGlzIGZ1cm5pc2hlZCB0byBkbyBzbywgc3ViamVjdCB0byB0aGUgZm9sbG93 aW5nCj4+ICsgKiAgICAgY29uZGl0aW9uczoKPj4gKyAqCj4+ICsgKiAgICAgVGhlIGFib3ZlIGNv cHlyaWdodCBub3RpY2UgYW5kIHRoaXMgcGVybWlzc2lvbiBub3RpY2Ugc2hhbGwgYmUKPj4gKyAq ICAgICBpbmNsdWRlZCBpbiBhbGwgY29waWVzIG9yIHN1YnN0YW50aWFsIHBvcnRpb25zIG9mIHRo ZSBTb2Z0d2FyZS4KPj4gKyAqCj4+ICsgKiAgICAgVEhFIFNPRlRXQVJFIElTIFBST1ZJREVEICJB UyBJUyIsIFdJVEhPVVQgV0FSUkFOVFkgT0YgQU5ZIEtJTkQsCj4+ICsgKiAgICAgRVhQUkVTUyBP UiBJTVBMSUVELCBJTkNMVURJTkcgQlVUIE5PVCBMSU1JVEVEIFRPIFRIRSBXQVJSQU5USUVTCj4+ ICsgKiAgICAgT0YgTUVSQ0hBTlRBQklMSVRZLCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVS UE9TRSBBTkQKPj4gKyAqICAgICBOT05JTkZSSU5HRU1FTlQuIElOIE5PIEVWRU5UIFNIQUxMIFRI RSBBVVRIT1JTIE9SIENPUFlSSUdIVAo+PiArICogICAgIEhPTERFUlMgQkUgTElBQkxFIEZPUiBB TlkgQ0xBSU0sIERBTUFHRVMgT1IgT1RIRVIgTElBQklMSVRZLAo+PiArICogICAgIFdIRVRIRVIg SU4gQU4gQUNUSU9OIE9GIENPTlRSQUNULCBUT1JUIE9SIE9USEVSV0lTRSwgQVJJU0lORwo+PiAr ICogICAgIEZST00sIE9VVCBPRiBPUiBJTiBDT05ORUNUSU9OIFdJVEggVEhFIFNPRlRXQVJFIE9S IFRIRSBVU0UgT1IKPj4gKyAqICAgICBPVEhFUiBERUFMSU5HUyBJTiBUSEUgU09GVFdBUkUuCj4+ ICsgKi8KPiAKPiBZb3Ugc2hvdWxkIHVzZSBhbiBTUERYIGxpY2Vuc2UgaGVhZGVyIGhlcmUuCgpE b25lCgo+IAo+PiArCj4+ICsvZHRzLXYxLzsKPj4gKyNpbmNsdWRlICJzdW43aS1hMjAuZHRzaSIK Pj4gKyNpbmNsdWRlICJzdW54aS1jb21tb24tcmVndWxhdG9ycy5kdHNpIgo+PiArCj4+ICsjaW5j bHVkZSA8ZHQtYmluZGluZ3MvZ3Bpby9ncGlvLmg+Cj4+ICsjaW5jbHVkZSA8ZHQtYmluZGluZ3Mv aW50ZXJydXB0LWNvbnRyb2xsZXIvaXJxLmg+Cj4+ICsKPj4gKy8gewo+PiArCW1vZGVsID0gIk1p Y3Jvbm92YSBzcmwgTGlOb3ZhMSBDVFAgN2kiOwo+PiArCWNvbXBhdGlibGUgPSAibWljcm9ub3Zh LGEyMC1saW5vdmExLWN0cC03aSIsICJhbGx3aW5uZXIsc3VuN2ktYTIwIjsKPj4gKwo+PiArCWFs aWFzZXMgewo+PiArCQlzZXJpYWwwID0gJnVhcnQwOwo+PiArCX07Cj4+ICsKPj4gKwljaG9zZW4g ewo+PiArCQlzdGRvdXQtcGF0aCA9ICJzZXJpYWwwOjExNTIwMG44IjsKPj4gKwl9Owo+PiArCj4+ ICsJcGFuZWw6IHBhbmVsIHsKPj4gKwkJY29tcGF0aWJsZSA9ICJjZHRlY2gsczA3MHd2OTUtY3Qx NiIsICJzaW1wbGUtcGFuZWwiOwo+PiArCQlwb3dlci1zdXBwbHkgPSA8JnJlZ192Y2MzdjM+Owo+ PiArCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPj4gKwkJI3NpemUtY2VsbHMgPSA8MD47Cj4+ICsK Pj4gKwkJcG9ydEAwIHsKPj4gKwkJCXJlZyA9IDwwPjsKPj4gKwkJCSNhZGRyZXNzLWNlbGxzID0g PDE+Owo+PiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4+ICsKPj4gKwkJCXBhbmVsX2lucHV0OiBl bmRwb2ludEAwIHsKPj4gKwkJCQlyZWcgPSA8MD47Cj4+ICsJCQkJcmVtb3RlLWVuZHBvaW50ID0g PCZ0Y29uMF9vdXRfcGFuZWw+Owo+PiArCQkJfTsKPj4gKwkJfTsKPj4gKwl9Owo+PiArfTsKPj4g Kwo+PiArJmVoY2kwIHsKPj4gKwlzdGF0dXMgPSAib2theSI7Cj4+ICt9Owo+PiArCj4+ICsmZWhj aTEgewo+PiArCXN0YXR1cyA9ICJva2F5IjsKPj4gK307Cj4+ICsKPj4gKyZpMmMwIHsKPj4gKwlw aW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+PiArCXBpbmN0cmwtMCA9IDwmaTJjMF9waW5zX2E+ Owo+PiArCXN0YXR1cyA9ICJva2F5IjsKPj4gKwo+PiArCWF4cDIwOTogcG1pY0AzNCB7Cj4+ICsJ CWNvbXBhdGlibGUgPSAieC1wb3dlcnMsYXhwMjA5IjsKPj4gKwkJcmVnID0gPDB4MzQ+Owo+PiAr CQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZubWlfaW50Yz47Cj4+ICsJCWludGVycnVwdHMgPSA8MCBJ UlFfVFlQRV9MRVZFTF9MT1c+Owo+PiArCj4+ICsJCWludGVycnVwdC1jb250cm9sbGVyOwo+PiAr CQkjaW50ZXJydXB0LWNlbGxzID0gPDE+Owo+PiArCX07Cj4+ICt9Owo+PiArCj4+ICsmaTJjMiB7 Cj4+ICsJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKPj4gKwlwaW5jdHJsLTAgPSA8JmkyYzJf cGluc19hPjsKPj4gKwlzdGF0dXMgPSAib2theSI7Cj4+ICsKPj4gKwlmdDV4OiB0b3VjaHNjcmVl bkAzOCB7Cj4+ICsJCWNvbXBhdGlibGUgPSAiZWR0LGVkdC1mdDUyMDYiOwo+PiArCQlyZWcgPSA8 MHgzOD47Cj4+ICsJCWludGVycnVwdC1wYXJlbnQgPSA8JnBpbz47Cj4+ICsJCWludGVycnVwdHMg PSA8NyAyIElSUV9UWVBFX0VER0VfRkFMTElORz47IC8qIFBIMiAqLwo+PiArCQlyZXNldC1ncGlv cyA9IDwmcGlvIDcgMyBHUElPX0FDVElWRV9MT1c+OyAvKiBQSDMgKi8KPj4gKwkJdG91Y2hzY3Jl ZW4tc2l6ZS14ID0gPDgwMD47Cj4+ICsJCXRvdWNoc2NyZWVuLXNpemUteSA9IDw0ODA+Owo+PiAr CX07Cj4+ICt9Owo+PiArCj4+ICsmbW1jMCB7Cj4+ICsJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0 IjsKPj4gKwlwaW5jdHJsLTAgPSA8Jm1tYzBfcGluc19hPjsKPj4gKwl2bW1jLXN1cHBseSA9IDwm cmVnX3ZjYzN2Mz47Cj4+ICsJYnVzLXdpZHRoID0gPDQ+Owo+PiArCWNkLWdwaW9zID0gPCZwaW8g NyAxIEdQSU9fQUNUSVZFX0hJR0g+OyAvKiBQSDEgKi8KPj4gKwljZC1pbnZlcnRlZDsKPj4gKwlz dGF0dXMgPSAib2theSI7Cj4+ICt9Owo+PiArCj4+ICsmb2hjaTAgewo+PiArCXN0YXR1cyA9ICJv a2F5IjsKPj4gK307Cj4+ICsKPj4gKyZvaGNpMSB7Cj4+ICsJc3RhdHVzID0gIm9rYXkiOwo+PiAr fTsKPj4gKwo+PiArJm90Z19zcmFtIHsKPj4gKwlzdGF0dXMgPSAib2theSI7Cj4+ICt9Owo+PiAr Cj4+ICsmcmVnX3VzYjBfdmJ1cyB7Cj4+ICsJc3RhdHVzID0gIm9rYXkiOwo+PiArfTsKPj4gKwo+ PiArJnJlZ191c2IxX3ZidXMgewo+PiArCXN0YXR1cyA9ICJva2F5IjsKPj4gK307Cj4gCj4gSWRl YWxseSB5b3Ugc2hvdWxkIGJlIGRlZmluaW5nIHRoZSByZWd1bGF0b3JzIGhlcmUgdG9vLgoKQWRk ZWQuCgo+IAo+PiArJnVhcnQwIHsKPj4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+PiAr CXBpbmN0cmwtMCA9IDwmdWFydDBfcGluc19hPjsKPj4gKwlzdGF0dXMgPSAib2theSI7Cj4+ICt9 Owo+PiArCj4+ICsmdXNiX290ZyB7Cj4+ICsJZHJfbW9kZSA9ICJvdGciOwo+IAo+IFlvdSdyZSBz YXlpbmcgdGhhdCB0aGlzIGlzIGEgVVNCLUEgY29ubmVjdG9yPyBUaGVuIGl0J3Mgbm90IE9URyBz aW5jZQo+IGl0IGRvZXNuJ3QgaGF2ZSBhbiBJRCBwaW4sIHRoaXMgaXMgYW4gaG9zdC4KClJpZ2h0 LCB3aXRoIGEgc3BlY2lhbCBvdmVybGF5IEkgd2lsbCBhY3RpdmF0ZSBVc2IgRGV2aWNlIGZvciBS TkRJUywKc28gbW9kaWZpZWQgYXMgaG9zdAoKPiAKPj4gKwlzdGF0dXMgPSAib2theSI7Cj4+ICt9 Owo+PiArCj4+ICsmdXNicGh5IHsKPj4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+PiAr CXVzYjBfdmJ1cy1zdXBwbHkgPSA8JnJlZ191c2IwX3ZidXM+Owo+PiArCXVzYjFfdmJ1cy1zdXBw bHkgPSA8JnJlZ191c2IxX3ZidXM+Owo+PiArCXN0YXR1cyA9ICJva2F5IjsKPj4gK307Cj4+ICsK Pj4gKyZiZTAgewo+PiArCXN0YXR1cyA9ICJva2F5IjsKPj4gK307Cj4+ICsKPj4gKyZkZSB7Cj4+ ICsJc3RhdHVzID0gIm9rYXkiOwo+PiArfTsKPiAKPiBUaGUgbm9kZXMgc2hvdWxkIGJlIG9yZGVy ZWQgYnkgYWxwaGFiZXRpY2FsIG9yZGVyLgoKRG9uZS4KCk9uZSBsYXN0IHF1ZXN0aW9uOgpub3cg SSBoYXZlIHNvbWUgcGF0Y2ggYWxyZWFkeSByZXZpZXdlZC1ieS4KRG8gSSBoYXZlIHRvIHJlLXN1 Ym1pdCBlbnRpcmUgcGF0Y2hzZXQ/CgpUaGFuayB5b3UgdmVyeSBtdWNoLgoKLS0gCkdpdWxpbyBC ZW5ldHRpCkNUTwoKTUlDUk9OT1ZBIFNSTApTZWRlOiBWaWEgQS4gTmllZGRhIDMgLSAzNTAxMCBW aWdvbnphIChQRCkKVGVsLiAwNDkvODkzMTU2MyAtIEZheCAwNDkvODkzMTM0NgpDb2QuRmlzY2Fs ZSAtIFAuSVZBIDAyNjYzNDIwMjg1CkNhcGl0YWxlIFNvY2lhbGUg4oKsIDI2LjAwMCBpLnYuCklz Y3JpdHRhIGFsIFJlZy4gSW1wcmVzZSBkaSBQYWRvdmEgTi4gMDI2NjM0MjAyODUKTnVtZXJvIFIu RS5BLiAyNTg2NDIKCj4gCj4gVGhhbmtzIQo+IE1heGltZQo+IAoKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: giulio.benetti@micronovasrl.com (Giulio Benetti) Date: Mon, 23 Apr 2018 16:37:33 +0200 Subject: [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI In-Reply-To: <20180322180508.my64gobhh5rc2x2m@flea> References: <1521662593-25468-1-git-send-email-giulio.benetti@micronovasrl.com> <1521662593-25468-7-git-send-email-giulio.benetti@micronovasrl.com> <20180322180508.my64gobhh5rc2x2m@flea> Message-ID: <8ef3b259-03b4-6987-286e-36ff627a8b76@micronovasrl.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Il 22/03/2018 19:05, Maxime Ripard ha scritto: > On Wed, Mar 21, 2018 at 09:03:13PM +0100, Giulio Benetti wrote: >> The A20-Linova1-7 HMI, also called Q027_2_F which is printed on production >> label, is an industrial Human Machine Interface. >> It features: >> - 512MB DDR RAM >> - 1 Sd-card >= 4GB >> - 1 Usb otg(programmable via software) with A-Usb Connector >> - 1 Usb host >> - 1 Buzzer >> - 1 Input for LiPo >> - 1 Relay to signal absence of power supply >> - 1 External Rtc with 56 bytes of ram + CR2032 battery >> - 1 7" 24-bits Tft 800x480 with PCap on >> - 1 Mono audio 1-watt amplifier >> - 1 RS485 port >> - 1 Power On Line through +12Vdc reaching 57.600baud, >> from where it can be supplied and placed in a network of 50 units >> - exposed jtag pins >> >> HMI is supplied from +12Vdc. >> Ethernet is absent, so for debugging, need to enable rndis on Usb otg >> port through an A-A usb cable. >> It comes in different flavours for connector types and can be found with >> umounted features as requested by customers. > > So this is essentially the same board than in patch 6, but with a > different screen? > > You should have a single DT then, and handle the two different panels > using DT overlays. Ok for having different DT overlays. But do I have to submit them as patches? Or keep them in my company's repo? I ask you this because this involves sending also patches for displays and other little modifications to mainline ex: - rgb888 pins - 2 simple-panels - 1 uart iomux pins etc. If I don't submit those overlays, the other patches wouldn't make sense alone as I've seen, just like rgb888 pins. > >> Signed-off-by: Giulio Benetti >> --- >> .../devicetree/bindings/arm/micronova.txt | 4 + >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts | 192 +++++++++++++++++++++ >> 3 files changed, 197 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> >> diff --git a/Documentation/devicetree/bindings/arm/micronova.txt b/Documentation/devicetree/bindings/arm/micronova.txt >> index 35c4127..9f5ac72 100644 >> --- a/Documentation/devicetree/bindings/arm/micronova.txt >> +++ b/Documentation/devicetree/bindings/arm/micronova.txt >> @@ -4,3 +4,7 @@ Micronova Device Tree Bindings >> A20-LiNova1-4_3 HMI >> Required root node properties: >> - compatible = "micronova,a20-linova1-ctp-4_3i", "allwinner,sun7i-a20"; >> + >> +A20-LiNova1-7 HMI >> +Required root node properties: >> + - compatible = "micronova,a20-linova1-ctp-7i", "allwinner,sun7i-a20"; > > These bindings are unnecessary, but the panel-simple bindings should > be sent to the DT maintainers as well. Ok, removed them and already sent the ones for display. > >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index c45a4f25..eafa7cb 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -942,6 +942,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \ >> sun7i-a20-m3.dtb \ >> sun7i-a20-mk808c.dtb \ >> sun7i-a20-linova1-ctp-4_3i.dtb\ >> + sun7i-a20-linova1-ctp-7i.dtb\ > > You should have a space after dtb, and it should be ordered > alphabetically. Done. > >> sun7i-a20-olimex-som-evb.dtb \ >> sun7i-a20-olinuxino-lime.dtb \ >> sun7i-a20-olinuxino-lime2.dtb \ >> diff --git a/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts b/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> new file mode 100644 >> index 0000000..7fd0d98 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun7i-a20-linova1-ctp-7i.dts >> @@ -0,0 +1,192 @@ >> +/* >> + * This is based on sun7i-a20-linova1-ctp-7i.dts >> + * >> + * Copyright 2014 - Hans de Goede >> + * Copyright (c) 2014 FUKAUMI Naoki >> + * Copyright (c) 2018 Giulio Benetti >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ > > You should use an SPDX license header here. Done > >> + >> +/dts-v1/; >> +#include "sun7i-a20.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include >> +#include >> + >> +/ { >> + model = "Micronova srl LiNova1 CTP 7i"; >> + compatible = "micronova,a20-linova1-ctp-7i", "allwinner,sun7i-a20"; >> + >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + panel: panel { >> + compatible = "cdtech,s070wv95-ct16", "simple-panel"; >> + power-supply = <®_vcc3v3>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port at 0 { >> + reg = <0>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + panel_input: endpoint at 0 { >> + reg = <0>; >> + remote-endpoint = <&tcon0_out_panel>; >> + }; >> + }; >> + }; >> +}; >> + >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> +&ehci1 { >> + status = "okay"; >> +}; >> + >> +&i2c0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c0_pins_a>; >> + status = "okay"; >> + >> + axp209: pmic at 34 { >> + compatible = "x-powers,axp209"; >> + reg = <0x34>; >> + interrupt-parent = <&nmi_intc>; >> + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> + >> + interrupt-controller; >> + #interrupt-cells = <1>; >> + }; >> +}; >> + >> +&i2c2 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c2_pins_a>; >> + status = "okay"; >> + >> + ft5x: touchscreen at 38 { >> + compatible = "edt,edt-ft5206"; >> + reg = <0x38>; >> + interrupt-parent = <&pio>; >> + interrupts = <7 2 IRQ_TYPE_EDGE_FALLING>; /* PH2 */ >> + reset-gpios = <&pio 7 3 GPIO_ACTIVE_LOW>; /* PH3 */ >> + touchscreen-size-x = <800>; >> + touchscreen-size-y = <480>; >> + }; >> +}; >> + >> +&mmc0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&mmc0_pins_a>; >> + vmmc-supply = <®_vcc3v3>; >> + bus-width = <4>; >> + cd-gpios = <&pio 7 1 GPIO_ACTIVE_HIGH>; /* PH1 */ >> + cd-inverted; >> + status = "okay"; >> +}; >> + >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> +&ohci1 { >> + status = "okay"; >> +}; >> + >> +&otg_sram { >> + status = "okay"; >> +}; >> + >> +®_usb0_vbus { >> + status = "okay"; >> +}; >> + >> +®_usb1_vbus { >> + status = "okay"; >> +}; > > Ideally you should be defining the regulators here too. Added. > >> +&uart0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_pins_a>; >> + status = "okay"; >> +}; >> + >> +&usb_otg { >> + dr_mode = "otg"; > > You're saying that this is a USB-A connector? Then it's not OTG since > it doesn't have an ID pin, this is an host. Right, with a special overlay I will activate Usb Device for RNDIS, so modified as host > >> + status = "okay"; >> +}; >> + >> +&usbphy { >> + pinctrl-names = "default"; >> + usb0_vbus-supply = <®_usb0_vbus>; >> + usb1_vbus-supply = <®_usb1_vbus>; >> + status = "okay"; >> +}; >> + >> +&be0 { >> + status = "okay"; >> +}; >> + >> +&de { >> + status = "okay"; >> +}; > > The nodes should be ordered by alphabetical order. Done. One last question: now I have some patch already reviewed-by. Do I have to re-submit entire patchset? Thank you very much. -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642 > > Thanks! > Maxime >