All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Hisch" <t.hisch@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] format specifier for the cpu number -> %u
Date: Sat, 10 Feb 2007 10:01:13 +0000	[thread overview]
Message-ID: <8ef77f2e0702100201k43599315k1d27e6489899e8da@mail.gmail.com> (raw)
In-Reply-To: <20070209221521.GA3026@unknown-00-0d-60-79-ca-00.lan>

On 2/9/07, Thomas Hisch <t.hisch@gmail.com> wrote:
> changed format specifier for the cpu number in printk to %u
> in arch/i386/kernel/cpu/mcheck/*
>
> Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
> ---
>
> this is only a part of my cpu to unsigned int patch,
> which i think should be ok
>
> imho the CPU#%u format in printk's is the best for cpu numbers,
> so this format should be the default in the whole kernel
>
> thoughts ?
>
[snip]
>         set_in_cr4 (X86_CR4_MCE);
> -       printk (KERN_INFO "Intel machine check reporting enabled on CPU#%d.\n",
> +       printk (KERN_INFO "Intel machine check reporting enabled on CPU#%u.\n",
>                 smp_processor_id());
>
>         /* Check for P4/Xeon extended MCE MSRs */
>         rdmsr (MSR_IA32_MCG_CAP, l, h);
>         if (l & (1<<9)) {/* MCG_EXT_P */
>                 mce_num_extended_msrs = (l >> 16) & 0xff;
> -               printk (KERN_INFO "CPU%d: Intel P4/Xeon Extended MCE MSRs (%d)"
> +               printk (KERN_INFO "CPU%u: Intel P4/Xeon Extended MCE MSRs (%d)"

it looks like i forgot to add the # in here. i'll fix this asap.

Thomas
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2007-02-10 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 22:15 [KJ] [PATCH] format specifier for the cpu number -> %u Thomas Hisch
2007-02-10 10:01 ` Thomas Hisch [this message]
2007-02-10 11:13 ` Thomas Hisch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8ef77f2e0702100201k43599315k1d27e6489899e8da@mail.gmail.com \
    --to=t.hisch@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.