From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B722AC33C9E for ; Mon, 3 Feb 2020 06:09:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A58A20721 for ; Mon, 3 Feb 2020 06:09:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CFSlinOW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A58A20721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUux-0001E5-Nn for qemu-devel@archiver.kernel.org; Mon, 03 Feb 2020 01:09:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56446) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyUuJ-0000fr-0v for qemu-devel@nongnu.org; Mon, 03 Feb 2020 01:08:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyUuH-0005ti-WB for qemu-devel@nongnu.org; Mon, 03 Feb 2020 01:08:26 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:42089 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyUuH-0005sm-SL for qemu-devel@nongnu.org; Mon, 03 Feb 2020 01:08:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580710104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=oRF6kiqvrzygK+e1Yrr4QnwUbj4owRwSeJWOMnoz7kM=; b=CFSlinOWcmcxCJscA6hVnnrYXZjwMQNiTgVLxSFbJCGzfNJi6n8bCdRXtBPeYLzrxHDR6C 2YxfBaGhTOJmMGOiYC/dQz59WqN7hogCQlQh1m5fe802ZZrB16V4OWV2bZIGN3N400a+Bj uh5YWAQXMJnrqA0UYQCRckJashr7lBg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-ZN1GWPRtNh2bxhAFmYUiNw-1; Mon, 03 Feb 2020 01:08:23 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 555838017CC; Mon, 3 Feb 2020 06:08:22 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C969E1BC6D; Mon, 3 Feb 2020 06:08:17 +0000 (UTC) Subject: Re: [PATCH] tests/qtest: update comments about bios-tables-test-allowed-diff.h To: Heyi Guo , qemu-devel@nongnu.org References: <20200202110009.51479-1-guoheyi@huawei.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <8efa38bc-48dc-c43e-0a34-062d5ae9e9d5@redhat.com> Date: Mon, 3 Feb 2020 07:08:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200202110009.51479-1-guoheyi@huawei.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: ZN1GWPRtNh2bxhAFmYUiNw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , wanghaibin.wang@huawei.com, Igor Mammedov , Paolo Bonzini , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 02/02/2020 12.00, Heyi Guo wrote: > Update comments in tests/qtest/bios-tables-test.c to reflect the > current path of bios-tables-test-allowed-diff.h, which is now under > tests/qtest/ as well. > > Signed-off-by: Heyi Guo > > --- > > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Thomas Huth > Cc: Laurent Vivier > Cc: Paolo Bonzini > --- > tests/qtest/bios-tables-test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index 3ab4872bd7..b4752c644c 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -14,14 +14,14 @@ > * How to add or update the tests: > * Contributor: > * 1. add empty files for new tables, if any, under tests/data/acpi > - * 2. list any changed files in tests/bios-tables-test-allowed-diff.h > + * 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h > * 3. commit the above *before* making changes that affect the tables > * > * Contributor or ACPI Maintainer (steps 4-7 need to be redone to resolve conflicts > * in binary commit created in step 6): > * > * After 1-3 above tests will pass but ignore differences with the expected files. > - * You will also notice that tests/bios-tables-test-allowed-diff.h lists > + * You will also notice that tests/qtest/bios-tables-test-allowed-diff.h lists > * a bunch of files. This is your hint that you need to do the below: > * 4. Run > * make check V=1 > @@ -40,14 +40,14 @@ > * in commit log. > * 7. Before sending patches to the list (Contributor) > * or before doing a pull request (Maintainer), make sure > - * tests/bios-tables-test-allowed-diff.h is empty - this will ensure > + * tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure > * following changes to ACPI tables will be noticed. > * > * The resulting patchset/pull request then looks like this: > - * - patch 1: list changed files in tests/bios-tables-test-allowed-diff.h. > + * - patch 1: list changed files in tests/qtest/bios-tables-test-allowed-diff.h. > * - patches 2 - n: real changes, may contain multiple patches. > * - patch n + 1: update golden master binaries and empty > - * tests/bios-tables-test-allowed-diff.h > + * tests/qtest/bios-tables-test-allowed-diff.h > */ > > #include "qemu/osdep.h" > Reviewed-by: Thomas Huth