All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: Nikolay Borisov <nborisov@suse.com>,
	Anand Jain <anand.jain@oracle.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH] btrfs: check for SB checksum when scanned
Date: Wed, 14 Mar 2018 08:03:12 -0400	[thread overview]
Message-ID: <8f0e03e2-a7ca-9197-f415-aee1e41ec02a@gmail.com> (raw)
In-Reply-To: <8951fcb0-aadd-6a10-50f7-eac44ff41438@suse.com>

On 2018-03-14 05:20, Nikolay Borisov wrote:
> On 13.03.2018 17:06, Anand Jain wrote:
>> We aren't checking the SB csum when the device scanned,
>> instead we do that when mounting the device, and if the
>> csum fails we fail the mount. How if we check the csum
>> when the device is scanned, I can't see any reason for
>> why not? any idea?
> 
> So what problems does this solve? Only net "gain" I see is making a
> function public (which is a minus in my book) thus expanding the public
> interface.
> 
A device with bogus SB's is effectively a missing device as far as the 
mount code is concerned.  AFAICT, this patch results in it being treated 
more like a missing device right from the start.

OTOH, I'm not really sure if this is an improvement or not, as I've 
never had to deal with devices with invalid SB's before.

  reply	other threads:[~2018-03-14 12:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 15:06 [RFC PATCH] btrfs: check for SB checksum when scanned Anand Jain
2018-03-14  9:20 ` Nikolay Borisov
2018-03-14 12:03   ` Austin S. Hemmelgarn [this message]
2018-03-14 15:38   ` David Sterba
2018-03-14 15:35 ` David Sterba
2018-03-14 15:48 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f0e03e2-a7ca-9197-f415-aee1e41ec02a@gmail.com \
    --to=ahferroin7@gmail.com \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.