From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/3] drm/i915/execlists: Suppress preempting self Date: Wed, 23 Jan 2019 16:40:44 +0000 Message-ID: <8f1a8036-b031-a819-2a7d-0b3e003c249a@linux.intel.com> References: <20190123123602.21816-1-chris@chris-wilson.co.uk> <20190123123602.21816-2-chris@chris-wilson.co.uk> <569302b7-c8f2-3590-9554-c855572a3984@linux.intel.com> <154825332589.693.14111030345407577908@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 950276EFC0 for ; Wed, 23 Jan 2019 16:40:44 +0000 (UTC) In-Reply-To: <154825332589.693.14111030345407577908@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIzLzAxLzIwMTkgMTQ6MjIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAxLTIzIDE0OjA4OjU2KQo+Pgo+PiBPbiAyMy8wMS8yMDE5IDEyOjM2 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJbiBvcmRlciB0byBhdm9pZCBwcmVlbXB0aW5nIG91 cnNlbHZlcywgd2UgY3VycmVudGx5IHJlZnVzZSB0byBzY2hlZHVsZQo+Pj4gdGhlIHRhc2tsZXQg aWYgd2UgcmVzY2hlZHVsZSBhbiBpbmZsaWdodCBjb250ZXh0LiBIb3dldmVyLCB0aGlzIGdsb3Nz ZXMKPj4+IG92ZXIgYSBmZXcgaXNzdWVzIHN1Y2ggYXMgd2hhdCBoYXBwZW5zIGFmdGVyIGEgQ1Mg Y29tcGxldGlvbiBldmVudCBhbmQKPj4+IHdlIHRoZW4gcHJlZW1wdCB0aGUgbmV3bHkgZXhlY3V0 aW5nIGNvbnRleHQgd2l0aCBpdHNlbGYsIG9yIGlmIHNvbWV0aGluZwo+Pj4gZWxzZSBjYXVzZXMg YSB0YXNrbGV0X3NjaGVkdWxlIHRyaWdnZXJpbmcgdGhlIHNhbWUgZXZhbHVhdGlvbiB0bwo+Pj4g cHJlZW1wdCB0aGUgYWN0aXZlIGNvbnRleHQgd2l0aCBpdHNlbGYuCj4+Pgo+Pj4gVG8gYXZvaWQg dGhlIGV4dHJhIGNvbXBsaWNhdGlvbnMsIGFmdGVyIGRlY2lkaW5nIHRoYXQgd2UgaGF2ZQo+Pj4g cG90ZW50aWFsbHkgcXVldWVkIGEgcmVxdWVzdCB3aXRoIGhpZ2hlciBwcmlvcml0eSB0aGFuIHRo ZSBjdXJyZW50bHkKPj4+IGV4ZWN1dGluZyByZXF1ZXN0LCBpbnNwZWN0IHRoZSBoZWFkIG9mIHRo ZSBxdWV1ZSB0byBzZWUgaWYgaXQgaXMgaW5kZWVkCj4+PiBoaWdoZXIgcHJpb3JpdHkgZnJvbSBh bm90aGVyIGNvbnRleHQuCj4+Pgo+Pj4gUmVmZXJlbmNlczogYTJiZjkyZThjYzE2ICgiZHJtL2k5 MTUvZXhlY2xpc3RzOiBBdm9pZCBraWNraW5nIHByaW9yaXR5IG9uIHRoZSBjdXJyZW50IGNvbnRl eHQiKQo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u Y28udWs+Cj4+PiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K Pj4+IC0tLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zY2hlZHVsZXIuYyB8IDIw ICsrKysrKy0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyAgICAgIHwg NjcgKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDc2 IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9zY2hlZHVsZXIuYwo+Pj4gaW5kZXggMzQwZmFlYTZjMDhhLi5mYjVkOTUzNDMwZTUgMTAw NjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxlci5jCj4+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3NjaGVkdWxlci5jCj4+PiBAQCAtMjM5LDYg KzIzOSwxOCBAQCBzY2hlZF9sb2NrX2VuZ2luZShzdHJ1Y3QgaTkxNV9zY2hlZF9ub2RlICpub2Rl LCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpsb2NrZWQpCj4+PiAgICAgICAgcmV0dXJuIGVuZ2lu ZTsKPj4+ICAgIH0KPj4+ICAgIAo+Pj4gK3N0YXRpYyBib29sIGluZmxpZ2h0KGNvbnN0IHN0cnVj dCBpOTE1X3JlcXVlc3QgKnJxLAo+Pj4gKyAgICAgICAgICAgICAgICAgIGNvbnN0IHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPj4+ICt7Cj4+PiArICAgICBjb25zdCBzdHJ1Y3QgaTkx NV9yZXF1ZXN0ICphY3RpdmU7Cj4+PiArCj4+PiArICAgICBpZiAoIXJxLT5nbG9iYWxfc2Vxbm8p Cj4+PiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4+ICsKPj4+ICsgICAgIGFjdGl2ZSA9 IHBvcnRfcmVxdWVzdChlbmdpbmUtPmV4ZWNsaXN0cy5wb3J0KTsKPj4+ICsgICAgIHJldHVybiBh Y3RpdmUtPmh3X2NvbnRleHQgPT0gcnEtPmh3X2NvbnRleHQ7Cj4+PiArfQo+Pj4gKwo+Pj4gICAg c3RhdGljIHZvaWQgX19pOTE1X3NjaGVkdWxlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+Pj4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IGk5MTVfc2NoZWRfYXR0ciAq YXR0cikKPj4+ICAgIHsKPj4+IEBAIC0zMjgsNiArMzQwLDcgQEAgc3RhdGljIHZvaWQgX19pOTE1 X3NjaGVkdWxlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+Pj4gICAgICAgICAgICAgICAgSU5J VF9MSVNUX0hFQUQoJmRlcC0+ZGZzX2xpbmspOwo+Pj4gICAgCj4+PiAgICAgICAgICAgICAgICBl bmdpbmUgPSBzY2hlZF9sb2NrX2VuZ2luZShub2RlLCBlbmdpbmUpOwo+Pj4gKyAgICAgICAgICAg ICBsb2NrZGVwX2Fzc2VydF9oZWxkKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+Pj4gICAgCj4+ PiAgICAgICAgICAgICAgICAvKiBSZWNoZWNrIGFmdGVyIGFjcXVpcmluZyB0aGUgZW5naW5lLT50 aW1lbGluZS5sb2NrICovCj4+PiAgICAgICAgICAgICAgICBpZiAocHJpbyA8PSBub2RlLT5hdHRy LnByaW9yaXR5IHx8IG5vZGVfc2lnbmFsZWQobm9kZSkpCj4+PiBAQCAtMzU2LDE3ICszNjksMTYg QEAgc3RhdGljIHZvaWQgX19pOTE1X3NjaGVkdWxlKHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLAo+ Pj4gICAgICAgICAgICAgICAgaWYgKHByaW8gPD0gZW5naW5lLT5leGVjbGlzdHMucXVldWVfcHJp b3JpdHkpCj4+PiAgICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gICAgCj4+PiAr ICAgICAgICAgICAgIGVuZ2luZS0+ZXhlY2xpc3RzLnF1ZXVlX3ByaW9yaXR5ID0gcHJpbzsKPj4+ ICsKPj4+ICAgICAgICAgICAgICAgIC8qCj4+PiAgICAgICAgICAgICAgICAgKiBJZiB3ZSBhcmUg YWxyZWFkeSB0aGUgY3VycmVudGx5IGV4ZWN1dGluZyBjb250ZXh0LCBkb24ndAo+Pj4gICAgICAg ICAgICAgICAgICogYm90aGVyIGV2YWx1YXRpbmcgaWYgd2Ugc2hvdWxkIHByZWVtcHQgb3Vyc2Vs dmVzLgo+Pj4gICAgICAgICAgICAgICAgICovCj4+PiAtICAgICAgICAgICAgIGlmIChub2RlX3Rv X3JlcXVlc3Qobm9kZSktPmdsb2JhbF9zZXFubyAmJgo+Pj4gLSAgICAgICAgICAgICAgICAgaTkx NV9zZXFub19wYXNzZWQocG9ydF9yZXF1ZXN0KGVuZ2luZS0+ZXhlY2xpc3RzLnBvcnQpLT5nbG9i YWxfc2Vxbm8sCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBub2RlX3Rv X3JlcXVlc3Qobm9kZSktPmdsb2JhbF9zZXFubykpCj4+PiArICAgICAgICAgICAgIGlmIChpbmZs aWdodChub2RlX3RvX3JlcXVlc3Qobm9kZSksIGVuZ2luZSkpCj4+PiAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwo+Pj4gICAgCj4+PiAgICAgICAgICAgICAgICAvKiBEZWZlciAodGFz a2xldCkgc3VibWlzc2lvbiB1bnRpbCBhZnRlciBhbGwgb2Ygb3VyIHVwZGF0ZXMuICovCj4+PiAt ICAgICAgICAgICAgIGVuZ2luZS0+ZXhlY2xpc3RzLnF1ZXVlX3ByaW9yaXR5ID0gcHJpbzsKPj4+ ICAgICAgICAgICAgICAgIHRhc2tsZXRfaGlfc2NoZWR1bGUoJmVuZ2luZS0+ZXhlY2xpc3RzLnRh c2tsZXQpOwo+Pj4gICAgICAgIH0KPj4+ICAgIAo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMK Pj4+IGluZGV4IDhhYThhNDg2MjU0My4uZDlkNzQ0ZjZhYjJjIDEwMDY0NAo+Pj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2xyYy5jCj4+PiBAQCAtMTgyLDEyICsxODIsNjQgQEAgc3RhdGljIGlubGluZSBp bnQgcnFfcHJpbyhjb25zdCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSkKPj4+ICAgIH0KPj4+ICAg IAo+Pj4gICAgc3RhdGljIGlubGluZSBib29sIG5lZWRfcHJlZW1wdChjb25zdCBzdHJ1Y3QgaW50 ZWxfZW5naW5lX2NzICplbmdpbmUsCj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b25zdCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpsYXN0LAo+Pj4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgaW50IHByaW8pCj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25z dCBzdHJ1Y3QgaTkxNV9yZXF1ZXN0ICpycSwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGludCBxX3ByaW8pCj4+PiAgICB7Cj4+PiAtICAgICByZXR1cm4gKGludGVsX2VuZ2luZV9o YXNfcHJlZW1wdGlvbihlbmdpbmUpICYmCj4+PiAtICAgICAgICAgICAgIF9fZXhlY2xpc3RzX25l ZWRfcHJlZW1wdChwcmlvLCBycV9wcmlvKGxhc3QpKSAmJgo+Pj4gLSAgICAgICAgICAgICAhaTkx NV9yZXF1ZXN0X2NvbXBsZXRlZChsYXN0KSk7Cj4+PiArICAgICBjb25zdCBzdHJ1Y3QgaW50ZWxf Y29udGV4dCAqY3R4ID0gcnEtPmh3X2NvbnRleHQ7Cj4+PiArICAgICBjb25zdCBpbnQgbGFzdF9w cmlvID0gcnFfcHJpbyhycSk7Cj4+PiArICAgICBzdHJ1Y3QgcmJfbm9kZSAqcmI7Cj4+PiArICAg ICBpbnQgaWR4Owo+Pj4gKwo+Pj4gKyAgICAgaWYgKCFpbnRlbF9lbmdpbmVfaGFzX3ByZWVtcHRp b24oZW5naW5lKSkKPj4+ICsgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+Pj4gKwo+Pj4gKyAg ICAgaWYgKGk5MTVfcmVxdWVzdF9jb21wbGV0ZWQocnEpKQo+Pj4gKyAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7Cj4+PiArCj4+PiArICAgICBpZiAoIV9fZXhlY2xpc3RzX25lZWRfcHJlZW1wdChx X3ByaW8sIGxhc3RfcHJpbykpCj4+PiArICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKPj4+ICsK Pj4+ICsgICAgIC8qCj4+PiArICAgICAgKiBUaGUgcXVldWVfcHJpb3JpdHkgaXMgYSBtZXJlIGhp bnQgdGhhdCB3ZSBtYXkgbmVlZCB0byBwcmVlbXB0Lgo+Pj4gKyAgICAgICogSWYgdGhhdCBoaW50 IGlzIHN0YWxlIG9yIHdlIG1heSBiZSB0cnlpbmcgdG8gcHJlZW1wdCBvdXJzZWx2ZXMsCj4+PiAr ICAgICAgKiBpZ25vcmUgdGhlIHJlcXVlc3QuCj4+PiArICAgICAgKi8KPj4+ICsKPj4+ICsgICAg IGxpc3RfZm9yX2VhY2hfZW50cnlfY29udGludWUocnEsICZlbmdpbmUtPnRpbWVsaW5lLnJlcXVl c3RzLCBsaW5rKSB7Cj4+PiArICAgICAgICAgICAgIEdFTV9CVUdfT04ocnEtPmh3X2NvbnRleHQg PT0gY3R4KTsKPj4KPj4gV2h5IHdvdWxkIHRoZXJlIGJlIG5vIG1vcmUgcmVxdWVzdHMgYmVsb25n aW5nIHRvIHRoZSBzYW1lIGNvbnRleHQgb24gdGhlCj4+IGVuZ2luZSB0aW1lbGluZSBhZnRlciB0 aGUgZmlyc3Qgb25lPyBEaWQgeW91IG1lYW4gImlmIChycS0+aHdfY29udGV4dCA9PQo+PiBjdHgp IGNvbnRpbnVlOyIgPwo+IAo+IFdlIGVudGVyIHRoZSBmdW5jdGlvbiB3aXRoIHJxID09IGV4ZWNs aXN0LT5wb3J0LCBpLmUuIHRoZSBsYXN0IHJlcXVlc3QKPiBzdWJtaXR0ZWQgdG8gRUxTUFswXS4g SW4gdGhpcyBsb29wLCB3ZSBpdGVyYXRlIGZyb20gdGhlIHN0YXJ0IG9mIEVMU1BbMV0KPiBhbmQg YWxsIHRoZSByZXF1ZXN0IGhlcmUgYmVsb25nIHRvIHRoYXQgY29udGV4dC4gSXQgaXMgaWxsZWdh bCBmb3IKPiBFTFNQWzBdLmxyY2EgPT0gRUxTUFsxXS5scmNhLCBpLmUuIHRoZSBjb250ZXh0IG11 c3QgYmUgZGlmZmVyZW50LgoKWWVzLCB5b3UgYXJlIHJpZ2h0IHlldCBhZ2Fpbi4gSSBtaXNzZWQg dGhlIGZhY3QgaXQgaXMgZ3VhcmFudGVlZCB0aGlzIGlzIApjYWxsZWQgd2l0aCBwb3J0MC4gSSB3 b25kZXIgaWYgZnVuY3Rpb24gc2lnbmF0dXJlIHNob3VsZCBjaGFuZ2UgdG8gbWFrZSAKdGhpcyBv YnZpb3VzIHNvIHNvbWVvbmUgZG9lc24ndCBnZXQgdGhlIGlkZWEgdG8gY2FsbCBpdCB3aXRoIGFu eSBvbGQgCnJlcXVlc3QuCgo+IAo+Pgo+Pj4gKyAgICAgICAgICAgICBpZiAocnFfcHJpbyhycSkg PiBsYXN0X3ByaW8pCj4+PiArICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7Cj4+PiAr ICAgICB9Cj4+PiArCj4+PiArICAgICByYiA9IHJiX2ZpcnN0X2NhY2hlZCgmZW5naW5lLT5leGVj bGlzdHMucXVldWUpOwo+Pj4gKyAgICAgaWYgKCFyYikKPj4+ICsgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwo+Pj4gKwo+Pj4gKyAgICAgcHJpb2xpc3RfZm9yX2VhY2hfcmVxdWVzdChycSwgdG9f cHJpb2xpc3QocmIpLCBpZHgpCj4+PiArICAgICAgICAgICAgIHJldHVybiBycS0+aHdfY29udGV4 dCAhPSBjdHggJiYgcnFfcHJpbyhycSkgPiBsYXN0X3ByaW87Cj4+Cj4+IFRoaXMgaXNuJ3QgZXF1 aXZhbGVudCB0byB0b3Agb2YgdGhlIHF1ZXVlIHByaW9yaXR5Cj4+IChlbmdpbmUtPmV4ZWNsaXN0 cy5xdWV1ZV9wcmlvcml0eSk/IEFwYXJ0IGZyb20gdGhlIGRpZmZlcmVudCBjdHggY2hlY2suCj4+ IFNvIEkgZ3Vlc3MgaXQgaXMgZWFzaWVyIHRoYW4gc3RvcmluZyBuZXcgZW5naW5lLT5leGVjbGlz dHMucXVldWVfdG9wX2N0eAo+PiBhbmQgd29uZGVyaW5nIGFib3V0IHRoZSB2YWxpZGl0eSBvZiB0 aGF0IHBvaW50ZXIuCj4gCj4gVGhlIHByb2JsZW0gYmVpbmcgdGhhdCBxdWV1ZV9wcmlvcml0eSBt YXkgbm90IGFsd2F5cyBtYXRjaCB0aGUgdG9wIG9mCj4gdGhlIGV4ZWNsaXN0cy0+cXVldWUuIFJp Z2h0LCB0aGUgZmlyc3QgYXR0ZW1wdCBJIHRyaWVkIHdhcyB0byBzdG9yZSB0aGUKPiBxdWV1ZV9j b250ZXh0IG1hdGNoaW5nIHRoZSBxdWV1ZV9wcmlvcml0eSwgYnV0IGR1ZSB0byB0aGUgc3VwcHJl c3Npb24gb2YKPiBpbmZsaWdodCBwcmVlbXB0aW9ucywgaXQgZG9lc24ndCBtYXRjaCBmb3IgbG9u ZywgYW5kIGlzIG5vdCBhcyBhY2N1cmF0ZQo+IGFzIG9uZSB3b3VsZCBsaWtlIGFjcm9zcyBDUyBl dmVudHMuCj4gCj4gcHJpb2xpc3RfZm9yX2VhY2hfcmVxdWVzdCgpIGlzbid0IHRvbyBob3JyaWJs ZSBmb3IgZmluZGluZyB0aGUgZmlyc3QKPiBwb2ludGVyLiBJIG5vdGVkIHRoYXQgd2UgdGVhY2gg aXQgdG8gZG86IGZvcihpZHggPSBfX2ZmcyhwLT51c2VkKTsgLi4uKQo+IHRob3VnaC4gSWYgd2Ug ZGlkbid0IGNhcmUgYWJvdXQgY2hlY2tpbmcgaHdfY29udGV4dCwgd2UgY2FuIGNvbXB1dGUgdGhl Cj4gcHJpbyBmcm9tIChwLT5wcmlvcml0eSsxKTw8U0hJRlQgLSBmZnMocC0+dXNlZCkuCgpBbmQg dGhpcyBjaGVjayBpcyBkZWZpbml0ZWx5IG5lZWRlZCB0byBhdm9pZCBzb21lIGlzc3VlPyBJJ2xs IG5lZWQgdG8gCmhhdmUgYW5vdGhlciB0cnkgb2YgdW5kZXJzdGFuZGluZyB0aGUgY29tbWl0IGFu ZCBjb2RlIHBhdGhzIGZ1bGx5IAp0b21vcnJvdy4gSSBtZWFuLCBvbmx5IGJlY2F1c2UgaXQgd291 bGQgYmUgZ29vZCB0byBoYXZlIHNvbWV0aGluZyBtb3JlIAplbGVnYW50IHRoYXQgZnVsbCBibG93 biB0cmVlIGxvb2t1cC4KClJlZ2FyZHMsCgpUdnJ0a28KCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK