From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23B2AC00A89 for ; Sat, 31 Oct 2020 01:15:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D17FB207DE for ; Sat, 31 Oct 2020 01:15:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726151AbgJaBPn (ORCPT ); Fri, 30 Oct 2020 21:15:43 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:54547 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJaBPn (ORCPT ); Fri, 30 Oct 2020 21:15:43 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R401e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0UDgCrVb_1604106938; Received: from IT-FVFX43SYHV2H.lan(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UDgCrVb_1604106938) by smtp.aliyun-inc.com(127.0.0.1); Sat, 31 Oct 2020 09:15:39 +0800 Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled To: Johannes Weiner Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-3-git-send-email-alex.shi@linux.alibaba.com> <20201029134648.GC599825@cmpxchg.org> <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> <20201030140420.GB666074@cmpxchg.org> From: Alex Shi Message-ID: <8f288275-da78-335d-e83d-7e073fcd3b88@linux.alibaba.com> Date: Sat, 31 Oct 2020 09:13:26 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201030140420.GB666074@cmpxchg.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/10/30 下午10:04, Johannes Weiner 写道: >>> Acked-by: Johannes Weiner >>> >>> This should go in before the previous patch that adds the WARN for it. >> Right, but than the long ops may not weird. Should I remove the ops and resend the whole patchset? > You mean the warning in the changelog? I think that's alright. You can > just say that you're about to remove the !page->memcg check in the > next patch because the original reasons for having it are gone, and > memcg being disabled is the only remaining exception, so this patch > makes that check explicit in preparation for the next. > > Sorry, it's all a bit of a hassle, I just wouldn't want to introduce a > known warning into the kernel between those two patches (could confuse > bisection runs, complicates partial reverts etc.) H Johannes, I see, I will exchange the 1st and 2nd patch place with above comments in commit log. I guess you could give more comments on other patches, so I am going to wait you for more comments and send v21 as a whole. :) Many thanks! Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Shi Subject: Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled Date: Sat, 31 Oct 2020 09:13:26 +0800 Message-ID: <8f288275-da78-335d-e83d-7e073fcd3b88@linux.alibaba.com> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-3-git-send-email-alex.shi@linux.alibaba.com> <20201029134648.GC599825@cmpxchg.org> <96b6d122-df0e-dfb0-368c-6bd714fab116@linux.alibaba.com> <20201030140420.GB666074@cmpxchg.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20201030140420.GB666074-druUgvl0LCNAfugRpC6u6w@public.gmane.org> List-ID: Content-Type: text/plain; charset="utf-8" To: Johannes Weiner Cc: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, mgorman-3eNAlZScCAx27rWaFMvyedHuzzzSOjJt@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hughd-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, khlebnikov-XoJtRXgx1JseBXzfvpsJ4g@public.gmane.org, daniel.m.jordan-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org, richard.weiyang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org, alexander.duyck-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rong.a.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mhocko-IBi9RG/b67k@public.gmane.org, vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Michal Hocko 在 2020/10/30 下午10:04, Johannes Weiner 写道: >>> Acked-by: Johannes Weiner >>> >>> This should go in before the previous patch that adds the WARN for it. >> Right, but than the long ops may not weird. Should I remove the ops and resend the whole patchset? > You mean the warning in the changelog? I think that's alright. You can > just say that you're about to remove the !page->memcg check in the > next patch because the original reasons for having it are gone, and > memcg being disabled is the only remaining exception, so this patch > makes that check explicit in preparation for the next. > > Sorry, it's all a bit of a hassle, I just wouldn't want to introduce a > known warning into the kernel between those two patches (could confuse > bisection runs, complicates partial reverts etc.) H Johannes, I see, I will exchange the 1st and 2nd patch place with above comments in commit log. I guess you could give more comments on other patches, so I am going to wait you for more comments and send v21 as a whole. :) Many thanks! Alex