From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D047C433F5 for ; Fri, 17 Sep 2021 23:49:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 111AA61152 for ; Fri, 17 Sep 2021 23:49:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238726AbhIQXug (ORCPT ); Fri, 17 Sep 2021 19:50:36 -0400 Received: from mx.socionext.com ([202.248.49.38]:35866 "EHLO mx.socionext.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229812AbhIQXuO (ORCPT ); Fri, 17 Sep 2021 19:50:14 -0400 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 18 Sep 2021 08:48:51 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 4F16E205902A; Sat, 18 Sep 2021 08:48:51 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Sat, 18 Sep 2021 08:48:51 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 27767AB192; Sat, 18 Sep 2021 08:48:51 +0900 (JST) Received: from [10.212.183.152] (unknown [10.212.183.152]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 5B85EB62B3; Sat, 18 Sep 2021 08:48:46 +0900 (JST) Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking To: Marc Zyngier Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> <87ee9nb94s.wl-maz@kernel.org> From: Kunihiko Hayashi Message-ID: <8f2b77a5-e2a8-71a5-1b32-3ca2944cad28@socionext.com> Date: Sat, 18 Sep 2021 08:48:46 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87ee9nb94s.wl-maz@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Marc, Thank you for your comment. On 2021/09/17 22:54, Marc Zyngier wrote: > On Thu, 16 Sep 2021 12:30:52 +0100, > Kunihiko Hayashi wrote: >> >> Gentle ping, are there any comments about this series? >> >> Thank you, >> >> On 2021/08/30 11:22, Kunihiko Hayashi wrote: >>> This series includes some fixes to INTx masking/unmasking for UniPhier PCIe >>> host controller driver. >>> >>> - Remove unnecessary bit clears to INTX mask field >>> - Remove unnecessary irq_ack() function because write access to status field >>> doesn't work >>> - Add lock into callback functions to avoid race condition >>> >>> Kunihiko Hayashi (2): >>> PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack >>> function >>> PCI: uniphier: Serialize INTx masking/unmasking >>> >>> drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- >>> 1 file changed, 10 insertions(+), 16 deletions(-) >>> > > Patches look OK, although I would personally squash them into a single > one (INTx masking never really worked before that). FWIW: Surely applying only the first patch leaves the issue with the second one. I'll squash them in v3. Thank you, > > Acked-by: Marc Zyngier > > N, > --- Best Regards Kunihiko Hayashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F2E8C433F5 for ; Fri, 17 Sep 2021 23:50:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 152886112E for ; Fri, 17 Sep 2021 23:50:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 152886112E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F9vBt6bKsODIDLwPXa3SzwPQBVCO8gyhj4nynRJ293U=; b=am5Z+cDuPg5W6az70VuHx1pGxy ynPjq//JeJ1knMqTETR2IQTTN1Rgc8MjLGFOEckXM+iX61YyNUgoY8qyvSZbK7QgE81qcV3W81+L8 dTc3Y1WhiXwLGAW+SVrW/ethzc4Tces4HDh3AUWNJiVxvDvTOn3QhVi6vWm8qswWkH4HZ1xmICrPz frJCWa/Pwzp9Sg49hdKqdXKfrZwEX2FiN7us86flkTZiRg9kfme38HJoX/SsApFQ5podF/KgOHNzB gSQHXb45x4tn4487G0VNOaZ076bbdDHoOobOpUkqdaJ1NAp7EWRFd6DHvmQJeS9sLXcQiQjy6VqyQ 1RGXeoaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRNbG-00FA7X-SR; Fri, 17 Sep 2021 23:48:59 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRNbD-00FA6I-78 for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 23:48:56 +0000 Received: from unknown (HELO kinkan2-ex.css.socionext.com) ([172.31.9.52]) by mx.socionext.com with ESMTP; 18 Sep 2021 08:48:51 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by kinkan2-ex.css.socionext.com (Postfix) with ESMTP id 4F16E205902A; Sat, 18 Sep 2021 08:48:51 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Sat, 18 Sep 2021 08:48:51 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 27767AB192; Sat, 18 Sep 2021 08:48:51 +0900 (JST) Received: from [10.212.183.152] (unknown [10.212.183.152]) by yuzu2.css.socionext.com (Postfix) with ESMTP id 5B85EB62B3; Sat, 18 Sep 2021 08:48:46 +0900 (JST) Subject: Re: [PATCH v2 0/2] PCI: uniphier: Fix INTx masking/unmasking To: Marc Zyngier Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1630290158-31264-1-git-send-email-hayashi.kunihiko@socionext.com> <64fd8ea9-1d78-5e3a-8097-6206f03e69de@socionext.com> <87ee9nb94s.wl-maz@kernel.org> From: Kunihiko Hayashi Message-ID: <8f2b77a5-e2a8-71a5-1b32-3ca2944cad28@socionext.com> Date: Sat, 18 Sep 2021 08:48:46 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <87ee9nb94s.wl-maz@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_164855_424645_58B48DC1 X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marc, Thank you for your comment. On 2021/09/17 22:54, Marc Zyngier wrote: > On Thu, 16 Sep 2021 12:30:52 +0100, > Kunihiko Hayashi wrote: >> >> Gentle ping, are there any comments about this series? >> >> Thank you, >> >> On 2021/08/30 11:22, Kunihiko Hayashi wrote: >>> This series includes some fixes to INTx masking/unmasking for UniPhier PCIe >>> host controller driver. >>> >>> - Remove unnecessary bit clears to INTX mask field >>> - Remove unnecessary irq_ack() function because write access to status field >>> doesn't work >>> - Add lock into callback functions to avoid race condition >>> >>> Kunihiko Hayashi (2): >>> PCI: uniphier: Fix INTx mask/unmask bit operation and remove ack >>> function >>> PCI: uniphier: Serialize INTx masking/unmasking >>> >>> drivers/pci/controller/dwc/pcie-uniphier.c | 26 ++++++++++---------------- >>> 1 file changed, 10 insertions(+), 16 deletions(-) >>> > > Patches look OK, although I would personally squash them into a single > one (INTx masking never really worked before that). FWIW: Surely applying only the first patch leaves the issue with the second one. I'll squash them in v3. Thank you, > > Acked-by: Marc Zyngier > > N, > --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel