From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Wei Yang <richardw.yang@linux.intel.com>,
Li Xinhai <lixinhai.lxh@gmail.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
akpm <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
"kirill.shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH v2 1/2] mm/rmap: fix and simplify reusing mergeable anon_vma as parent when fork
Date: Sat, 18 Jan 2020 11:04:21 +0300 [thread overview]
Message-ID: <8f335403-4a14-bd17-39da-6299dd962fc6@yandex-team.ru> (raw)
In-Reply-To: <20200115012055.GC4916@richard>
On 15/01/2020 04.20, Wei Yang wrote:
> On Tue, Jan 14, 2020 at 10:42:52PM +0800, Li Xinhai wrote:
>> On 2020-01-13 at 19:07 Konstantin Khlebnikov wrote:
>>
>>>
>>> Because I want to keep both heuristics.
>>> This seems most sane way of interaction between them.
>>>
>>> Unfortunately even this patch is slightly broken.
>>> Condition prev->anon_vma->parent == pvma->anon_vma doesn't guarantee that
>>> prev vma has the same set of anon-vmas like current vma.
>>> I.e. anon_vma_clone(vma, prev) might be not enough for keeping connectivity.
>>
>> New patch is required?
>
> My suggestion is separate the fix and new approach instead of mess them into
> one patch.
Yep, it's messy. Maybe it's could be better to revert recent change,
apply second patch from this set and write something new after that.
>
>> It is necessary to call anon_vma_clone(vma, pvma) to link all anon_vma which
>> currently linked by pvma, then link the prev->anon_vma to vma. By this way,
>> connectivity of vma should be maintained, right?
>>
>>> Building such case isn't trivial job but I see nothing that could prevent it.
>>>
>>
>
next prev parent reply other threads:[~2020-01-18 8:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:19 [PATCH v2 1/2] mm/rmap: fix and simplify reusing mergeable anon_vma as parent when fork Konstantin Khlebnikov
2020-01-07 10:19 ` [PATCH v2 2/2] kernel/fork: set VMA's mm/prev/next right after vm_area_dup in dup_mmap Konstantin Khlebnikov
2020-01-07 14:22 ` lixinhai.lxh
2020-01-07 13:35 ` [PATCH v2 1/2] mm/rmap: fix and simplify reusing mergeable anon_vma as parent when fork lixinhai.lxh
2020-01-08 2:32 ` Wei Yang
2020-01-08 6:42 ` lixinhai.lxh
2020-01-08 10:40 ` Konstantin Khlebnikov
2020-01-09 2:52 ` Wei Yang
2020-01-09 8:54 ` Konstantin Khlebnikov
2020-01-10 2:30 ` Wei Yang
2020-01-10 3:23 ` Li Xinhai
2020-01-10 5:34 ` Wei Yang
2020-01-10 8:11 ` Konstantin Khlebnikov
2020-01-11 22:38 ` Wei Yang
2020-01-12 9:55 ` Konstantin Khlebnikov
2020-01-13 0:33 ` Wei Yang
2020-01-13 11:07 ` Konstantin Khlebnikov
2020-01-14 2:09 ` Wei Yang
2020-01-14 14:42 ` Li Xinhai
2020-01-15 1:20 ` Wei Yang
2020-01-18 8:04 ` Konstantin Khlebnikov [this message]
2020-01-18 14:00 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f335403-4a14-bd17-39da-6299dd962fc6@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixinhai.lxh@gmail.com \
--cc=richardw.yang@linux.intel.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.