From: Niklas Cassel <niklas.cassel@axis.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>, <shuah@kernel.org>,
<davem@davemloft.net>, <andrew@lunn.ch>,
<linux-kselftest@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] selftests: add a generic testsuite for ethernet device
Date: Tue, 4 Apr 2017 16:43:19 +0200 [thread overview]
Message-ID: <8f363cf9-1696-bab9-ab54-a003541e1409@axis.com> (raw)
In-Reply-To: <20170404133247.28725-1-clabbe.montjoie@gmail.com>
On 04/04/2017 03:32 PM, Corentin Labbe wrote:
> This patch add a generic testsuite for testing ethernet network device driver.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>
> Changes since v1:
> - Test for starting master interface
> - Changed printing format to "RESULT: $netdev: line"
> - Use "ip link" to get device list
>
> tools/testing/selftests/net/Makefile | 2 +-
> tools/testing/selftests/net/netdevice.sh | 200 +++++++++++++++++++++++++++++++
> 2 files changed, 201 insertions(+), 1 deletion(-)
> create mode 100755 tools/testing/selftests/net/netdevice.sh
>
(snip)
Good work!
I suggest adding a test for setting MTU as well.
It doesn't have to be added before merging, but it
would be great if it could be added in the near future.
Regards,
Niklas
next prev parent reply other threads:[~2017-04-04 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 13:32 [PATCH v2] selftests: add a generic testsuite for ethernet device Corentin Labbe
2017-04-04 14:24 ` Andrew Lunn
2017-04-04 14:43 ` Niklas Cassel [this message]
2017-04-04 14:50 ` Corentin Labbe
2017-04-04 15:00 ` Andrew Lunn
2017-04-05 15:30 ` David Miller
2017-06-29 8:26 ` Fathi Boudra
2017-07-01 6:42 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f363cf9-1696-bab9-ab54-a003541e1409@axis.com \
--to=niklas.cassel@axis.com \
--cc=andrew@lunn.ch \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.