From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA66C48BE6 for ; Wed, 16 Jun 2021 23:17:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AFC8611BE for ; Wed, 16 Jun 2021 23:17:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AFC8611BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=eik.bme.hu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lteme-0000VM-6x for qemu-devel@archiver.kernel.org; Wed, 16 Jun 2021 19:17:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46660) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltelA-0007OR-Cl; Wed, 16 Jun 2021 19:15:48 -0400 Received: from zero.eik.bme.hu ([2001:738:2001:2001::2001]:55950) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltel7-0006nr-DC; Wed, 16 Jun 2021 19:15:47 -0400 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id E955774570E; Thu, 17 Jun 2021 01:15:38 +0200 (CEST) Received: by zero.eik.bme.hu (Postfix, from userid 432) id A99E974570B; Thu, 17 Jun 2021 01:15:38 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id A7F957456B4; Thu, 17 Jun 2021 01:15:38 +0200 (CEST) Date: Thu, 17 Jun 2021 01:15:38 +0200 (CEST) From: BALATON Zoltan To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH v4 03/15] hw/display/sm501: Simplify sm501_i2c_write() logic In-Reply-To: <20210616214254.2647796-4-f4bug@amsat.org> Message-ID: <8f39606a-eaab-aac-48d0-b9307aba496@eik.bme.hu> References: <20210616214254.2647796-1-f4bug@amsat.org> <20210616214254.2647796-4-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-165660671-1623885338=:97089" Received-SPF: pass client-ip=2001:738:2001:2001::2001; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Richard Henderson , qemu-devel@nongnu.org, KONRAD Frederic , qemu-arm@nongnu.org, qemu-ppc@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-165660671-1623885338=:97089 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT On Wed, 16 Jun 2021, Philippe Mathieu-Daudé wrote: > Reviewed-by: Richard Henderson > Acked-by: Corey Minyard > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: BALATON Zoltan > --- > hw/display/sm501.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/display/sm501.c b/hw/display/sm501.c > index 8789722ef27..f276276f7f1 100644 > --- a/hw/display/sm501.c > +++ b/hw/display/sm501.c > @@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value, > int res = i2c_start_transfer(s->i2c_bus, > s->i2c_addr >> 1, > s->i2c_addr & 1); > - s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0); > - if (!res) { > + if (res) { > + s->i2c_status |= SM501_I2C_STATUS_ERROR; > + } else { > int i; > for (i = 0; i <= s->i2c_byte_count; i++) { > res = i2c_send_recv(s->i2c_bus, &s->i2c_data[i], > --3866299591-165660671-1623885338=:97089--