From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405DFC3A5A5 for ; Thu, 5 Sep 2019 12:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 008BA2053B for ; Thu, 5 Sep 2019 12:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="e99iYp1P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733105AbfIEMdN (ORCPT ); Thu, 5 Sep 2019 08:33:13 -0400 Received: from mout.web.de ([217.72.192.78]:57205 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731438AbfIEMdM (ORCPT ); Thu, 5 Sep 2019 08:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1567686777; bh=XfQXB2vIZe2JukTJVFUwHi4vpiAorDqzVl4iR6s4MU8=; h=X-UI-Sender-Class:Cc:References:Subject:From:To:Date:In-Reply-To; b=e99iYp1PbHtyxwKkP1vcOOeJMfVbmpSk9zTCP3MqIF9mxIGuTPyI5C1aF7tdJhUof gF5f/dHMI0Zhj4iDKnpy69ytMpmJlJ0/rOEcKdIEnUrJnvu/WhU+udDyYWkk8JjWwf hUpyfYxssvM/8e4CBa3dqELJRtAGRKKvQLjNp1/M= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.49.131.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M5x3d-1iLD60023N-00xovn; Thu, 05 Sep 2019 14:32:57 +0200 Cc: linux-kernel@vger.kernel.org, Gilles Muller , Julia Lawall , Masahiro Yamada , Michal Marek , Nicolas Palix References: <20190904221223.5281-1-efremov@linux.com> Subject: Re: [RFC PATCH] coccinelle: check for integer overflow in binary search From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= To: Denis Efremov , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org Message-ID: <8f454c56-735c-0620-ead4-b59e328b0283@web.de> Date: Thu, 5 Sep 2019 14:32:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190904221223.5281-1-efremov@linux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ZXkurD9h48YNUpH2sA9zXRQ7s8GTYYE8Wv1K0E1TnIYYk7loz1a eb9BGhjNIRwZVsqYEgXUKmhGxxBYAITOtev0+g6zR9a5VBLM9ofY9SAGCSeL+tr8ytvGdtR aDkHqgvR6Z16WXFR91LoTQNvHfHkkZhkiobhwYYGHvSUaGNIe1ju2NWm7/vGLUWjPNlB30Q bo97IAYqVs+LM2RxjF9fw== X-UI-Out-Filterresults: notjunk:1;V03:K0:UAQlLQyjxKU=:00X0gjPswzSxNVfINMEUe/ xGHfGxJ9+mKqN9BXiNLmZ4RHTIza8BTZsig2AbNuVLp2z6lD+n8hT/iNTXHwOIYjsPkF9258c FKUwKUyCgi4PHgnfjy7aDC1Kgs9AkUyFZdhvL2w5nXd+2P4kCCq6gBsm+E1mHYmc+vYm+ep5L gDyv77K0+DYybDX582sUV7qsBOLCE5sv8ixW+6Ht2H7TzCNvaMhfUUkUv7r4woGT3pNNcer7d bP2NcTXSSKRHjahqOlS5dfk0lXhPC05s4SMnREU+/c3TDH/+1mG4B1xhuAIu59tG5TGE00ru3 4ryS0y38aXTfzUyvPXkrlYZ8D68CObPW8XQixRpihmTmzaKQQFPMJ2Jj54M0G91Le+d040upq 38yhupY1G32D9MI9wBbBx/xJNkcdylcuFSh7OoiF90nRgzB7tVoYHGhi/Oq9yDGcJMFonAbeY G/lPVGB63I9NwBH7Wzj7mnqBdeTqQICNCj/ZtzUSEFtxhtGhouvDqfhMHScj8kD8LQcpy7kBZ egXWORYq8q/QgiZKLHCduePGcAqUtXwsHf+wolj6YBRMlYLkrJSNvYV/V2c1vuyn3qG5mH/HN BylPvUHiDY95TGwMc7iaUa7NQWVk8ZwX1vRF9u9y2MFeM0ZZ4dkIolflgRegTMO9aipYOaDWP /JpL+NueMgWHoBr3dYbwOu2m+RyGCmqiKevEfoY41aM+iqqKYXlz3on2LrgTVdFg2bYkv5KOm I5/RHfdLtLpS6dxndYyuVii3X0VArRoeQkwWSm/aK5jqu7mV0wnyNwg9E/vlYaAmN/3ckZeTm SRmnCdqEQmpKGLWG3A+uh8dOw5gHOxoRkrIusIxBV+37dF8fU4NcfxaBHkQSZYITNewW/TMci lR7xkmVSFUbChtAjvhaUNT/LUf6Hnv0Ki6MZpg0FylkMqEAVDGOmsp7sxlued+DDNYXyPWL3M 8ln8oBfN91yQZukEhbcRvnaZLdH0Y2RyvtIECYIEteaKzkfA7ssDhBk6dY2rPnB1N6o85aUYv STlQJQHB0G3d4ZDKU0bF172mkig96yplMM1n5p9qUlYOl3ABn2CSn2VOX1+3811kqFbRH5uWk V3Ptcef/M66Q04w35xhFrjz7ezavlG+dBUaSaRA9hRlRbDwdjiNXCMQdKn0UDJq+xaJl9qyQK Zs5LgTPvLeuGsK4NRxT5DkPyhl3qXuVeaPUXciM673lwTeVpma0c7Ou5/ymOs4S9wiAOa53qt NvdkDqmDT52h+Y0kk Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +identifier l, h, m; Can expressions make sense for these metavariables? > +@@ > +( > + while (\(l < h\|l <=3D h\|(h - l) > 1\|(l + 1) < h\|l < (h - 1)\)) { > + ... > +( > + ((l + h)@p / c) > +| > + ((l + h)@p >> c) > +) > + ... > + } * I suggest again to look at further possibilities to reduce undesirable code duplication also together with the usage of SmPL disjunctions. * The condition specification might be easier to read with a few additional spaces (or the following variant). * The SmPL ellipses will probably need further considerations. +@@ +( + while ( +( l \( < \| <=3D \) h +| (h - l) > 1 +| (h - 1) > l +| (l + 1) < h +) ) + { + <+... + ((l + h)@p \( / \| >> \) c) + ...+> + } > +@script:python depends on report@ > +p << r.p; > +@@ > + > +msg=3D"WARNING: custom implementation of bsearch is error-prone. " > +msg+=3D"Consider using lib/bsearch.c or fix the midpoint calculation " > +msg+=3D"as 'm =3D l + (h - l) / 2;' to prevent the arithmetic overflow.= " > +coccilib.report.print_report(p[0], msg) The Linux coding style supports to put a long string literal also into a s= ingle line. Thus I find such a message construction nicer without the extra variable = =E2=80=9Cmsg=E2=80=9D. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Date: Thu, 05 Sep 2019 12:32:54 +0000 Subject: Re: [RFC PATCH] coccinelle: check for integer overflow in binary search Message-Id: <8f454c56-735c-0620-ead4-b59e328b0283@web.de> List-Id: References: <20190904221223.5281-1-efremov@linux.com> In-Reply-To: <20190904221223.5281-1-efremov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Denis Efremov , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org Cc: Michal Marek , Nicolas Palix , linux-kernel@vger.kernel.org > +identifier l, h, m; Can expressions make sense for these metavariables? > +@@ > +( > + while (\(l < h\|l <= h\|(h - l) > 1\|(l + 1) < h\|l < (h - 1)\)) { > + ... > +( > + ((l + h)@p / c) > +| > + ((l + h)@p >> c) > +) > + ... > + } * I suggest again to look at further possibilities to reduce undesirable code duplication also together with the usage of SmPL disjunctions. * The condition specification might be easier to read with a few additional spaces (or the following variant). * The SmPL ellipses will probably need further considerations. +@@ +( + while ( +( l \( < \| <= \) h +| (h - l) > 1 +| (h - 1) > l +| (l + 1) < h +) ) + { + <+... + ((l + h)@p \( / \| >> \) c) + ...+> + } > +@script:python depends on report@ > +p << r.p; > +@@ > + > +msg="WARNING: custom implementation of bsearch is error-prone. " > +msg+="Consider using lib/bsearch.c or fix the midpoint calculation " > +msg+="as 'm = l + (h - l) / 2;' to prevent the arithmetic overflow." > +coccilib.report.print_report(p[0], msg) The Linux coding style supports to put a long string literal also into a single line. Thus I find such a message construction nicer without the extra variable “msg”. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD105C3A5A5 for ; Thu, 5 Sep 2019 12:33:22 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 442B52053B for ; Thu, 5 Sep 2019 12:33:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="e99iYp1P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 442B52053B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x85CX5QX018593; Thu, 5 Sep 2019 14:33:06 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id AFA4B7797; Thu, 5 Sep 2019 14:33:05 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 569507796 for ; Thu, 5 Sep 2019 14:33:04 +0200 (CEST) Received: from mout.web.de (mout.web.de [217.72.192.78]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id x85CX2ax001463; Thu, 5 Sep 2019 14:33:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1567686777; bh=XfQXB2vIZe2JukTJVFUwHi4vpiAorDqzVl4iR6s4MU8=; h=X-UI-Sender-Class:Cc:References:Subject:From:To:Date:In-Reply-To; b=e99iYp1PbHtyxwKkP1vcOOeJMfVbmpSk9zTCP3MqIF9mxIGuTPyI5C1aF7tdJhUof gF5f/dHMI0Zhj4iDKnpy69ytMpmJlJ0/rOEcKdIEnUrJnvu/WhU+udDyYWkk8JjWwf hUpyfYxssvM/8e4CBa3dqELJRtAGRKKvQLjNp1/M= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([78.49.131.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M5x3d-1iLD60023N-00xovn; Thu, 05 Sep 2019 14:32:57 +0200 References: <20190904221223.5281-1-efremov@linux.com> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= To: Denis Efremov , cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org Message-ID: <8f454c56-735c-0620-ead4-b59e328b0283@web.de> Date: Thu, 5 Sep 2019 14:32:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190904221223.5281-1-efremov@linux.com> Content-Language: en-US X-Provags-ID: V03:K1:ZXkurD9h48YNUpH2sA9zXRQ7s8GTYYE8Wv1K0E1TnIYYk7loz1a eb9BGhjNIRwZVsqYEgXUKmhGxxBYAITOtev0+g6zR9a5VBLM9ofY9SAGCSeL+tr8ytvGdtR aDkHqgvR6Z16WXFR91LoTQNvHfHkkZhkiobhwYYGHvSUaGNIe1ju2NWm7/vGLUWjPNlB30Q bo97IAYqVs+LM2RxjF9fw== X-UI-Out-Filterresults: notjunk:1;V03:K0:UAQlLQyjxKU=:00X0gjPswzSxNVfINMEUe/ xGHfGxJ9+mKqN9BXiNLmZ4RHTIza8BTZsig2AbNuVLp2z6lD+n8hT/iNTXHwOIYjsPkF9258c FKUwKUyCgi4PHgnfjy7aDC1Kgs9AkUyFZdhvL2w5nXd+2P4kCCq6gBsm+E1mHYmc+vYm+ep5L gDyv77K0+DYybDX582sUV7qsBOLCE5sv8ixW+6Ht2H7TzCNvaMhfUUkUv7r4woGT3pNNcer7d bP2NcTXSSKRHjahqOlS5dfk0lXhPC05s4SMnREU+/c3TDH/+1mG4B1xhuAIu59tG5TGE00ru3 4ryS0y38aXTfzUyvPXkrlYZ8D68CObPW8XQixRpihmTmzaKQQFPMJ2Jj54M0G91Le+d040upq 38yhupY1G32D9MI9wBbBx/xJNkcdylcuFSh7OoiF90nRgzB7tVoYHGhi/Oq9yDGcJMFonAbeY G/lPVGB63I9NwBH7Wzj7mnqBdeTqQICNCj/ZtzUSEFtxhtGhouvDqfhMHScj8kD8LQcpy7kBZ egXWORYq8q/QgiZKLHCduePGcAqUtXwsHf+wolj6YBRMlYLkrJSNvYV/V2c1vuyn3qG5mH/HN BylPvUHiDY95TGwMc7iaUa7NQWVk8ZwX1vRF9u9y2MFeM0ZZ4dkIolflgRegTMO9aipYOaDWP /JpL+NueMgWHoBr3dYbwOu2m+RyGCmqiKevEfoY41aM+iqqKYXlz3on2LrgTVdFg2bYkv5KOm I5/RHfdLtLpS6dxndYyuVii3X0VArRoeQkwWSm/aK5jqu7mV0wnyNwg9E/vlYaAmN/3ckZeTm SRmnCdqEQmpKGLWG3A+uh8dOw5gHOxoRkrIusIxBV+37dF8fU4NcfxaBHkQSZYITNewW/TMci lR7xkmVSFUbChtAjvhaUNT/LUf6Hnv0Ki6MZpg0FylkMqEAVDGOmsp7sxlued+DDNYXyPWL3M 8ln8oBfN91yQZukEhbcRvnaZLdH0Y2RyvtIECYIEteaKzkfA7ssDhBk6dY2rPnB1N6o85aUYv STlQJQHB0G3d4ZDKU0bF172mkig96yplMM1n5p9qUlYOl3ABn2CSn2VOX1+3811kqFbRH5uWk V3Ptcef/M66Q04w35xhFrjz7ezavlG+dBUaSaRA9hRlRbDwdjiNXCMQdKn0UDJq+xaJl9qyQK Zs5LgTPvLeuGsK4NRxT5DkPyhl3qXuVeaPUXciM673lwTeVpma0c7Ou5/ymOs4S9wiAOa53qt NvdkDqmDT52h+Y0kk X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 05 Sep 2019 14:33:06 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 05 Sep 2019 14:33:03 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Michal Marek , Nicolas Palix , linux-kernel@vger.kernel.org Subject: Re: [Cocci] [RFC PATCH] coccinelle: check for integer overflow in binary search X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr PiAraWRlbnRpZmllciBsLCBoLCBtOwoKQ2FuIGV4cHJlc3Npb25zIG1ha2Ugc2Vuc2UgZm9yIHRo ZXNlIG1ldGF2YXJpYWJsZXM/CgoKPiArQEAKPiArKAo+ICsgd2hpbGUgKFwobCA8IGhcfGwgPD0g aFx8KGggLSBsKSA+IDFcfChsICsgMSkgPCBoXHxsIDwgKGggLSAxKVwpKSB7Cj4gKyAgLi4uCj4g KygKPiArICAoKGwgKyBoKUBwIC8gYykKPiArfAo+ICsgICgobCArIGgpQHAgPj4gYykKPiArKQo+ ICsgIC4uLgo+ICsgfQoKKiBJIHN1Z2dlc3QgYWdhaW4gdG8gbG9vayBhdCBmdXJ0aGVyIHBvc3Np YmlsaXRpZXMgdG8gcmVkdWNlIHVuZGVzaXJhYmxlCiAgY29kZSBkdXBsaWNhdGlvbiBhbHNvIHRv Z2V0aGVyIHdpdGggdGhlIHVzYWdlIG9mIFNtUEwgZGlzanVuY3Rpb25zLgoKKiBUaGUgY29uZGl0 aW9uIHNwZWNpZmljYXRpb24gbWlnaHQgYmUgZWFzaWVyIHRvIHJlYWQgd2l0aCBhIGZldwogIGFk ZGl0aW9uYWwgc3BhY2VzIChvciB0aGUgZm9sbG93aW5nIHZhcmlhbnQpLgoKKiBUaGUgU21QTCBl bGxpcHNlcyB3aWxsIHByb2JhYmx5IG5lZWQgZnVydGhlciBjb25zaWRlcmF0aW9ucy4KCgorQEAK KygKKyB3aGlsZSAoCisoICAgICAgIGwgXCggPCBcfCA8PSBcKSBoCit8ICAgICAgIChoIC0gbCkg PiAxCit8ICAgICAgIChoIC0gMSkgPiBsCit8ICAgICAgIChsICsgMSkgPCBoCispICAgICAgKQor IHsKKyA8Ky4uLgorICgobCArIGgpQHAgXCggLyBcfCA+PiBcKSBjKQorIC4uLis+CisgfQoKCj4g K0BzY3JpcHQ6cHl0aG9uIGRlcGVuZHMgb24gcmVwb3J0QAo+ICtwIDw8IHIucDsKPiArQEAKPiAr Cj4gK21zZz0iV0FSTklORzogY3VzdG9tIGltcGxlbWVudGF0aW9uIG9mIGJzZWFyY2ggaXMgZXJy b3ItcHJvbmUuICIKPiArbXNnKz0iQ29uc2lkZXIgdXNpbmcgbGliL2JzZWFyY2guYyBvciBmaXgg dGhlIG1pZHBvaW50IGNhbGN1bGF0aW9uICIKPiArbXNnKz0iYXMgJ20gPSBsICsgKGggLSBsKSAv IDI7JyB0byBwcmV2ZW50IHRoZSBhcml0aG1ldGljIG92ZXJmbG93LiIKPiArY29jY2lsaWIucmVw b3J0LnByaW50X3JlcG9ydChwWzBdLCBtc2cpCgpUaGUgTGludXggY29kaW5nIHN0eWxlIHN1cHBv cnRzIHRvIHB1dCBhIGxvbmcgc3RyaW5nIGxpdGVyYWwgYWxzbyBpbnRvIGEgc2luZ2xlIGxpbmUu ClRodXMgSSBmaW5kIHN1Y2ggYSBtZXNzYWdlIGNvbnN0cnVjdGlvbiBuaWNlciB3aXRob3V0IHRo ZSBleHRyYSB2YXJpYWJsZSDigJxtc2figJ0uCgpSZWdhcmRzLApNYXJrdXMKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQ29jY2kgbWFpbGluZyBsaXN0CkNv Y2NpQHN5c3RlbWUubGlwNi5mcgpodHRwczovL3N5c3RlbWUubGlwNi5mci9tYWlsbWFuL2xpc3Rp bmZvL2NvY2NpCg==