From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Alex G." Subject: Re: [RFC PATCH v2 2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc Date: Thu, 19 Apr 2018 09:57:08 -0500 Message-ID: <8f467611-16a1-8fe7-ea12-e2e29023e4e8@gmail.com> References: <20180416215903.7318-1-mr.nuke.me@gmail.com> <20180416215903.7318-3-mr.nuke.me@gmail.com> <20180418175201.GI4795@pd.tnic> <5f26275c-5896-c552-69c4-78e5aaaa6558@gmail.com> <20180419143018.GC3600@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180419143018.GC3600@pd.tnic> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-Id: linux-acpi@vger.kernel.org On 04/19/2018 09:30 AM, Borislav Petkov wrote: > On Thu, Apr 19, 2018 at 09:19:03AM -0500, Alex G. wrote: >> On the other side, you lose readability as soon as you get a few more >> handlers and the function becomes too long. > > No you don't - you split it properly. And that was the motivation behind my splitting it in this patch. >> And more importantly, you lose generality: it's not obvious that >> there's ghes_edac_report_mem_error() which too wide a context. > > I don't understand what that means. My apologies, sometimes my thought is too far ahead of my typing fingers. For the purpose of handling _one_ error, you need the CPER entry for that one error -- narrow context. You don't need the entire GHES structure -- wide context. Individual handlers should not be able to access the entire ghes. When the handlers are restricted to a common signature --which doesn't include ghes--, it's obvious when functions try to bite more than they can chew. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [RFC,v2,2/4] acpi: apei: Split GHES handlers outside of ghes_do_proc From: Alexandru Gagniuc Message-Id: <8f467611-16a1-8fe7-ea12-e2e29023e4e8@gmail.com> Date: Thu, 19 Apr 2018 09:57:08 -0500 To: Borislav Petkov Cc: linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, tony.luck@intel.com, tbaicar@codeaurora.org, will.deacon@arm.com, james.morse@arm.com, shiju.jose@huawei.com, zjzhang@codeaurora.org, gengdongjiu@huawei.com, linux-kernel@vger.kernel.org, alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, devel@acpica.org, mchehab@kernel.org, robert.moore@intel.com, erik.schmauss@intel.com List-ID: T24gMDQvMTkvMjAxOCAwOTozMCBBTSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOgo+IE9uIFRodSwg QXByIDE5LCAyMDE4IGF0IDA5OjE5OjAzQU0gLTA1MDAsIEFsZXggRy4gd3JvdGU6Cj4+IE9uIHRo ZSBvdGhlciBzaWRlLCB5b3UgbG9zZSByZWFkYWJpbGl0eSBhcyBzb29uIGFzIHlvdSBnZXQgYSBm ZXcgbW9yZQo+PiBoYW5kbGVycyBhbmQgdGhlIGZ1bmN0aW9uIGJlY29tZXMgdG9vIGxvbmcuCj4g Cj4gTm8geW91IGRvbid0IC0geW91IHNwbGl0IGl0IHByb3Blcmx5LgoKQW5kIHRoYXQgd2FzIHRo ZSBtb3RpdmF0aW9uIGJlaGluZCBteSBzcGxpdHRpbmcgaXQgaW4gdGhpcyBwYXRjaC4KCj4+IEFu ZCBtb3JlIGltcG9ydGFudGx5LCB5b3UgbG9zZSBnZW5lcmFsaXR5OiBpdCdzIG5vdCBvYnZpb3Vz IHRoYXQKPj4gdGhlcmUncyBnaGVzX2VkYWNfcmVwb3J0X21lbV9lcnJvcigpIHdoaWNoIHRvbyB3 aWRlIGEgY29udGV4dC4KPiAKPiBJIGRvbid0IHVuZGVyc3RhbmQgd2hhdCB0aGF0IG1lYW5zLgoK TXkgYXBvbG9naWVzLCBzb21ldGltZXMgbXkgdGhvdWdodCBpcyB0b28gZmFyIGFoZWFkIG9mIG15 IHR5cGluZwpmaW5nZXJzLiBGb3IgdGhlIHB1cnBvc2Ugb2YgaGFuZGxpbmcgX29uZV8gZXJyb3Is IHlvdSBuZWVkIHRoZSBDUEVSCmVudHJ5IGZvciB0aGF0IG9uZSBlcnJvciAtLSBuYXJyb3cgY29u dGV4dC4gWW91IGRvbid0IG5lZWQgdGhlIGVudGlyZQpHSEVTIHN0cnVjdHVyZSAtLSB3aWRlIGNv bnRleHQuIEluZGl2aWR1YWwgaGFuZGxlcnMgc2hvdWxkIG5vdCBiZSBhYmxlCnRvIGFjY2VzcyB0 aGUgZW50aXJlIGdoZXMuCgpXaGVuIHRoZSBoYW5kbGVycyBhcmUgcmVzdHJpY3RlZCB0byBhIGNv bW1vbiBzaWduYXR1cmUgLS13aGljaCBkb2Vzbid0CmluY2x1ZGUgZ2hlcy0tLCBpdCdzIG9idmlv dXMgd2hlbiBmdW5jdGlvbnMgdHJ5IHRvIGJpdGUgbW9yZSB0aGFuIHRoZXkKY2FuIGNoZXcuCgpB bGV4Ci0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5z dWJzY3JpYmUgbGludXgtZWRhYyIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9t b0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2Vy bmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==