From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7251C433E0 for ; Tue, 2 Feb 2021 12:50:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2419564F45 for ; Tue, 2 Feb 2021 12:50:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2419564F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l6v8w-0000sR-5N for qemu-devel@archiver.kernel.org; Tue, 02 Feb 2021 07:50:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46432) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l6v7A-0008A1-OY for qemu-devel@nongnu.org; Tue, 02 Feb 2021 07:49:04 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32351) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l6v78-00017f-Ew for qemu-devel@nongnu.org; Tue, 02 Feb 2021 07:49:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612270141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3YeZe1cz4rY/AVreTU0zNZuhb4qQ5tvS/yQPIIWL4hQ=; b=DuEiPLrpLs4y8vnAccip5xUbA7cPC+Gnh2kb1qK9o1mGN9DhhdEk4WxI+8cA43UHhKyqmk zkpTpU199AtFHaOYrVCLv3cgtl7NFi7qi7XKu/AJfGGv0Zsu5NT/k62blfSvQzZhlm+R7N 1KNywvX8ZFmPeKVdh5uVqtmCQ9fExq8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-bPj6WugfPeeunOVkJLX7xQ-1; Tue, 02 Feb 2021 07:48:58 -0500 X-MC-Unique: bPj6WugfPeeunOVkJLX7xQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33CF2801817; Tue, 2 Feb 2021 12:48:57 +0000 (UTC) Received: from wainer-laptop.localdomain (ovpn-116-207.gru2.redhat.com [10.97.116.207]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78DA26EF45; Tue, 2 Feb 2021 12:48:40 +0000 (UTC) Subject: Re: [PATCH 0/1] Allow to build virtiofsd without the entire tools To: Paolo Bonzini References: <20210201211456.1133364-1-wainersm@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <8f5102be-a303-610b-9cf7-497056595da3@redhat.com> Date: Tue, 2 Feb 2021 09:48:38 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="------------B197FB05EACE26E3D5D19DD8" Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.386, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.155, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: misono.tomohiro@jp.fujitsu.com, qemu-devel , stefanha@redhat.com, David Gilbert Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is a multi-part message in MIME format. --------------B197FB05EACE26E3D5D19DD8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 2/1/21 8:04 PM, Paolo Bonzini wrote: > > > Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta > > ha scritto: > > Not too long ago (QEMU 5.0) it was possible to configure with > --disable-tools > and still have virtiofsd built. With the recent port of the build > system to > Meson, it is now built together with the tools though. > > The Kata Containers [1] project build QEMU with --disable-tools to > decrease the > attack surface > > > ---enable-tools only adds separate executables, therefore it can't add > to the attack surface of the emulators. So this is misleading. You are right, Paolo, thanks for the comment. I meant to say the project avoid installing unneeded binaries on the system, extra files which may be subject to CVEs and force a sysadmin to handle them. I hope this clarifies my point. Thanks! Wainer > > That said, it does make sense to let --enable-virtiofsd override > --disable-tools, and the same in the other direction too. > > Paolo > > Side note: in a private chat with Stefan Hajnoczi he come up with > the idea > that perhaps --disable-tools could be like > --without-default-features where > one can add back on feature-by-feature basis. This is outside the > scope of this > series but I thought in sharing because IMHO it is deserves a > discussion. > > > [1] https://katacontainers.io > > Wainer dos Santos Moschetta (1): >   virtiofsd: Allow to build it without the tools > >  tools/meson.build | 7 +++++-- >  1 file changed, 5 insertions(+), 2 deletions(-) > > -- > 2.29.2 > --------------B197FB05EACE26E3D5D19DD8 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit

Hi,

On 2/1/21 8:04 PM, Paolo Bonzini wrote:


Il lun 1 feb 2021, 22:15 Wainer dos Santos Moschetta <wainersm@redhat.com> ha scritto:
Not too long ago (QEMU 5.0) it was possible to configure with --disable-tools
and still have virtiofsd built. With the recent port of the build system to
Meson, it is now built together with the tools though.

The Kata Containers [1] project build QEMU with --disable-tools to decrease the
attack surface

---enable-tools only adds separate executables, therefore it can't add to the attack surface of the emulators. So this is misleading.


You are right, Paolo, thanks for the comment. I meant to say the project avoid installing unneeded binaries on the system, extra files which may be subject to CVEs and force a sysadmin to handle them. I hope this clarifies my point.

Thanks!

Wainer


That said, it does make sense to let --enable-virtiofsd override --disable-tools, and the same in the other direction too.

Paolo

Side note: in a private chat with Stefan Hajnoczi he come up with the idea
that perhaps --disable-tools could be like --without-default-features where
one can add back on feature-by-feature basis. This is outside the scope of this
series but I thought in sharing because IMHO it is deserves a discussion.

[1] https://katacontainers.io

Wainer dos Santos Moschetta (1):
  virtiofsd: Allow to build it without the tools

 tools/meson.build | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--
2.29.2

--------------B197FB05EACE26E3D5D19DD8--