From: Martin Doucha <mdoucha@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cpuhotplug05.sh: Rewrite test case
Date: Mon, 9 Dec 2019 13:50:59 +0100 [thread overview]
Message-ID: <8f5e7d2a-34a8-5d2a-658c-a1f535fd1cc7@suse.cz> (raw)
In-Reply-To: <31fe4c0c-863e-4ba6-d8d7-1af909013fb7@163.com>
On 12/9/19 4:13 AM, Xiao Yang wrote:
>> Your new scenario has two problems:
>>
>> - You have to run at least two test loops to verify that reactivating a
>> CPU doesn't break /proc/stat entries.
>
> I think running cpuhotplug05.sh with -i 2 can verfiy this point.
>
> Perhaps we can add -i option to runtest/cpuhotplug, or do you prefer to
> keep the original scenario?
I'd prefer keeping the original scenario (with your version of cleanup).
Running extra iterations of the same test should not be required to get
the full intended test coverage.
>> - Also consider doing the above check for all CPUs to increase test
>> coverage.
>
> Is it necessary to add above check for all CPUs?
>
> This test is designed to test specified CPU so you can test each CPU by
> using -c option.
It's not necessary but it'd be a nice addition. Note that running the
test script multiple times with different -c arguments does not fully
cover this extra check. Turning a CPU core off and on again might reset
its /proc/stat line into a sane state while breaking all the others.
--
Martin Doucha mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
next prev parent reply other threads:[~2019-12-09 12:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 10:19 [LTP] [PATCH] cpuhotplug05.sh: Rewrite test case Xiao Yang
2019-12-04 15:11 ` Martin Doucha
2019-12-09 3:13 ` Xiao Yang
2019-12-09 12:50 ` Martin Doucha [this message]
2019-12-09 21:06 ` Petr Vorel
2019-12-10 1:37 ` Xiao Yang
2019-12-10 8:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f5e7d2a-34a8-5d2a-658c-a1f535fd1cc7@suse.cz \
--to=mdoucha@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.