From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F801C33CAC for ; Mon, 3 Feb 2020 12:28:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B02020658 for ; Mon, 3 Feb 2020 12:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727942AbgBCM2C (ORCPT ); Mon, 3 Feb 2020 07:28:02 -0500 Received: from foss.arm.com ([217.140.110.172]:52798 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727905AbgBCM2C (ORCPT ); Mon, 3 Feb 2020 07:28:02 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B2F9BFEC; Mon, 3 Feb 2020 04:28:01 -0800 (PST) Received: from [10.1.196.63] (e123195-lin.cambridge.arm.com [10.1.196.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD26B3F52E; Mon, 3 Feb 2020 04:28:00 -0800 (PST) Subject: Re: [PATCH v2 kvmtool 18/30] hw/vesa: Set the size for BAR 0 To: Andre Przywara Cc: kvm@vger.kernel.org, will@kernel.org, julien.thierry.kdev@gmail.com, sami.mujawar@arm.com, lorenzo.pieralisi@arm.com, maz@kernel.org References: <20200123134805.1993-1-alexandru.elisei@arm.com> <20200123134805.1993-19-alexandru.elisei@arm.com> <20200203122049.05483484@donnerap.cambridge.arm.com> From: Alexandru Elisei Message-ID: <8f66615a-b771-1d6c-f794-182a5fd1d07d@arm.com> Date: Mon, 3 Feb 2020 12:27:55 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200203122049.05483484@donnerap.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Andre, On 2/3/20 12:20 PM, Andre Przywara wrote: > On Thu, 23 Jan 2020 13:47:53 +0000 > Alexandru Elisei wrote: > >> BAR 0 is an I/O BAR and is registered as an ioport region. Let's set its >> size, so a guest can actually use it. > Well, the whole I/O bar emulates as RAZ/WI, so I would be curious how the guest would actually use it, but specifying the size is surely a good thing, so: Yeah, you're right, I was thinking about ARM where ioport are MMIO and you need to map those address. I'll remove the part about the guest being able to actually use it in the next iteration of the series.. Is it OK if I keep your Reviewed-by? > >> Signed-off-by: Alexandru Elisei > Reviewed-by: Andre Przywara > > Cheers, > Andre > >> --- >> hw/vesa.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/hw/vesa.c b/hw/vesa.c >> index a665736a76d7..e988c0425946 100644 >> --- a/hw/vesa.c >> +++ b/hw/vesa.c >> @@ -70,6 +70,7 @@ struct framebuffer *vesa__init(struct kvm *kvm) >> >> vesa_base_addr = (u16)r; >> vesa_pci_device.bar[0] = cpu_to_le32(vesa_base_addr | PCI_BASE_ADDRESS_SPACE_IO); >> + vesa_pci_device.bar_size[0] = PCI_IO_SIZE; >> r = device__register(&vesa_device); >> if (r < 0) >> return ERR_PTR(r);