From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE32C433ED for ; Mon, 17 May 2021 11:47:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58E1A610CB for ; Mon, 17 May 2021 11:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 58E1A610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60282 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1libir-0001pR-GV for qemu-devel@archiver.kernel.org; Mon, 17 May 2021 07:47:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1libdU-0001Bk-1l for qemu-devel@nongnu.org; Mon, 17 May 2021 07:42:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51447) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1libdO-0002bs-QG for qemu-devel@nongnu.org; Mon, 17 May 2021 07:42:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621251724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LFljbWd4DU7XTa5qfHxcQh0G6vZ/b6k9LAWhOT9skGs=; b=RFE1XEMGh2RxPz7UyaQbBdaqAn9HsiyAJF8DpBBMTQzkiTKMZpQvwQoMLrKW8qHGH1Fkkl xjCALoKp/6jrs6SzuwiWh7JXaiVEgPdS931Zo0QxRfHIV8fBdaiH7WMBqzuvZ1RS+TmpN3 eUdeE4g1cHRql5NBmRGHiPuNOJys4tc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-595-DKXtO7PKOXyLd7USGVw9sA-1; Mon, 17 May 2021 07:42:01 -0400 X-MC-Unique: DKXtO7PKOXyLd7USGVw9sA-1 Received: by mail-ej1-f70.google.com with SMTP id x20-20020a1709061354b02903cff4894505so916759ejb.14 for ; Mon, 17 May 2021 04:42:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LFljbWd4DU7XTa5qfHxcQh0G6vZ/b6k9LAWhOT9skGs=; b=dOUqfYhBQvzx3cdMFzKAMlTm03DjEEK1w+8P/o9Vw/EBjF7L5VhvmEQHCHhxV0JmCQ SmdDA4kNMqUsrw3yyEC4KL/DVndTf2No1KZZEeDJoNH5JP47WtO/1PAWP/bNZMS8JRXG AfrQPV3G4ewwOMHTT0valxT4yO7X6ZmVfCGBTuklp76IR3mlVqdMPhtp5i4T4rno7PYh vxmmnB82vhaULf3M1vSJ9TlI582cvoRYiISEq9KxihLDG00+jqs9oFE5APHowLxDhIUt Dh2Huoy+riBOmves+wLryHS96HbRAvWXZmiEbwVdBtMP9THtonxvVt9F9Z8T36/1312U Ssgw== X-Gm-Message-State: AOAM533TVhvSr9J829eH1jBf0/07uSXVO8scS1d0RzvLNQMwR1jccA/l 8/UaO/b883EAQnLG9agmbSVLv8Mha9vh8Jc9k+MdJg/5G2UIjfFDpZfIBVEvjCUAR1/F/JPfGDJ Mr7ymYCEoQHXjRz2kodp09snFiMWsRzBJmLKFXgIpoB2N2AtNsyfs1XB8w0ikOB69Xbs= X-Received: by 2002:a17:906:ad81:: with SMTP id la1mr330115ejb.346.1621251719362; Mon, 17 May 2021 04:41:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPoe/SEshZ5pruI9QrHfN9MJZJzK8M5zJp/i9wZsA5ap0f5Xe2CeQCfW5dFu8Uiakvshs+4A== X-Received: by 2002:a17:906:ad81:: with SMTP id la1mr330087ejb.346.1621251718975; Mon, 17 May 2021 04:41:58 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id b19sm10642396edd.66.2021.05.17.04.41.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 May 2021 04:41:58 -0700 (PDT) Subject: Re: [PATCH] meson: Set implicit_include_directories to false To: Katsuhiro Ueno References: <2571b8c3-3e2b-f90e-6077-05232a52c711@redhat.com> From: Paolo Bonzini Message-ID: <8f6be65f-b3d9-c5fd-38a8-c52f9275430f@redhat.com> Date: Mon, 17 May 2021 13:41:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 01/05/21 04:08, Katsuhiro Ueno wrote: > 2021-04-30 16:48 Paolo Bonzini : >> >> On 29/04/21 04:43, Katsuhiro Ueno wrote: >>> Without this, libvixl cannot be compiled with macOS 11.3 SDK due to >>> include file name conflict (usr/include/c++/v1/version conflicts with >>> VERSION). >>> >>> Signed-off-by: Katsuhiro Ueno >>> --- >>> meson.build | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meson.build b/meson.build >>> index c6f4b0cf5e..d007bff8c3 100644 >>> --- a/meson.build >>> +++ b/meson.build >>> @@ -2129,6 +2129,7 @@ common_all = common_ss.apply(config_all, strict: false) >>> common_all = static_library('common', >>> build_by_default: false, >>> sources: common_all.sources() + genh, >>> + implicit_include_directories: false, >>> dependencies: common_all.dependencies(), >>> name_suffix: 'fa') >>> >> >> Can you include the difference in the include paths (the -I and -iquote >> arguments)? There are many cases in which we rely on having the current >> source directory in the build path, for example all inclusions of "trace.h". > > This only removes -I.. (current (top-level) source directory) from the > arguments. The meson manual says that it also removes -I. (current > (top-level) build directory) but -I. is still in the arguments (I am > not sure why). This does not change any -iquote argument. > > As far as I know, this does not affect the inclusions of "trace.h" > because each "trace.h" is in the same directory as the files that > include it, and the top-level build directory, which has the "trace" > directory containing generated "trace-*.h" files, is still in the > include path. Queued, thanks. It looks like "implicit" only refers to the directory that meson.build lies in. It would be nicer to have _all_ targets in meson.build have implicit_include_directories: false, since we would have the same problem for other C++ sources, but that can be done later. Paolo