From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Date: Mon, 10 Apr 2017 10:52:07 +0530 Message-ID: <8f7014dd-612e-fa8f-d7e6-54258d013073@ti.com> References: <201704062226.0RxDxHDj%fengguang.wu@intel.com> <1491509279-3982-1-git-send-email-vivek.gautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: Received: from fllnx210.ext.ti.com ([198.47.19.17]:52288 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbdDJFWO (ORCPT ); Mon, 10 Apr 2017 01:22:14 -0400 In-Reply-To: <1491509279-3982-1-git-send-email-vivek.gautam@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Vivek Gautam Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, sboyd@codeaurora.org, bjorn.andersson@linaro.org, srinivas.kandagatla@linaro.org, Fengguang Wu On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote: > The driver uses clock provider interface, and therefore > it fails to build when enabled for COMPILE_TEST, since > COMMON_CLK is not enabled at that time. > So, make PHY_QCOM_QMP depend on COMMON_CLK as well. > > Cc: Fengguang Wu > Cc: Kishon Vijay Abraham I > Signed-off-by: Vivek Gautam > --- > > Hi Kishon, > > This patch is fixing the build failures for architectures > such as, tile, and ia64, that don't enable COMMON_CLK by default. > You can either squash this into the qmp phy driver patch, > or put it as a separate patch with 'Fix' tag. > Let me know if you want me to add a 'fix' tag with a reference > to the commit ID. I squashed it with your earlier patch and pushed. Thanks Kishon > > Regards > Vivek > > drivers/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index bb8140355608..8550d3dc0b71 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -441,7 +441,7 @@ config PHY_STIH407_USB > > config PHY_QCOM_QMP > tristate "Qualcomm QMP PHY Driver" > - depends on OF && (ARCH_QCOM || COMPILE_TEST) > + depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > Enable this to support the QMP PHY transceiver that is used > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752523AbdDJFWQ (ORCPT ); Mon, 10 Apr 2017 01:22:16 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:52288 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751133AbdDJFWO (ORCPT ); Mon, 10 Apr 2017 01:22:14 -0400 Subject: Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK To: Vivek Gautam References: <201704062226.0RxDxHDj%fengguang.wu@intel.com> <1491509279-3982-1-git-send-email-vivek.gautam@codeaurora.org> CC: , , , , , , Fengguang Wu From: Kishon Vijay Abraham I Message-ID: <8f7014dd-612e-fa8f-d7e6-54258d013073@ti.com> Date: Mon, 10 Apr 2017 10:52:07 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <1491509279-3982-1-git-send-email-vivek.gautam@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote: > The driver uses clock provider interface, and therefore > it fails to build when enabled for COMPILE_TEST, since > COMMON_CLK is not enabled at that time. > So, make PHY_QCOM_QMP depend on COMMON_CLK as well. > > Cc: Fengguang Wu > Cc: Kishon Vijay Abraham I > Signed-off-by: Vivek Gautam > --- > > Hi Kishon, > > This patch is fixing the build failures for architectures > such as, tile, and ia64, that don't enable COMMON_CLK by default. > You can either squash this into the qmp phy driver patch, > or put it as a separate patch with 'Fix' tag. > Let me know if you want me to add a 'fix' tag with a reference > to the commit ID. I squashed it with your earlier patch and pushed. Thanks Kishon > > Regards > Vivek > > drivers/phy/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index bb8140355608..8550d3dc0b71 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -441,7 +441,7 @@ config PHY_STIH407_USB > > config PHY_QCOM_QMP > tristate "Qualcomm QMP PHY Driver" > - depends on OF && (ARCH_QCOM || COMPILE_TEST) > + depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST) > select GENERIC_PHY > help > Enable this to support the QMP PHY transceiver that is used >