From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC6E8C2BB55 for ; Wed, 15 Apr 2020 10:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C61C32078A for ; Wed, 15 Apr 2020 10:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406020AbgDOKbV (ORCPT ); Wed, 15 Apr 2020 06:31:21 -0400 Received: from foss.arm.com ([217.140.110.172]:41762 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405937AbgDOK32 (ORCPT ); Wed, 15 Apr 2020 06:29:28 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B1B21063; Wed, 15 Apr 2020 03:20:49 -0700 (PDT) Received: from [10.37.12.1] (unknown [10.37.12.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BE9B3F68F; Wed, 15 Apr 2020 03:20:47 -0700 (PDT) Subject: Re: [PATCH 4/8] arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu Cc: linux-kernel@vger.kernel.org, mark.rutland@arm.com, maz@kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org, dianders@chromium.org, kernel-team@android.com References: <20200414213114.2378-1-will@kernel.org> <20200414213114.2378-5-will@kernel.org> From: Suzuki K Poulose Message-ID: <8f911640-8b7d-bb6f-2b76-67dd0d259b75@arm.com> Date: Wed, 15 Apr 2020 11:25:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200414213114.2378-5-will@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/14/2020 10:31 PM, Will Deacon wrote: > There's no need to call id_aa64pfr0_32bit_el0() twice because the > sanitised value of ID_AA64PFR0_EL1 has already been updated for the CPU > being onlined. > > Remove the redundant function call. > > Signed-off-by: Will Deacon Reviewed-by: Suzuki K Poulose > --- > arch/arm64/kernel/cpufeature.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 838fe5cc8d7e..7dfcdd9e75c1 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -792,9 +792,7 @@ void update_cpu_features(int cpu, > * If we have AArch32, we care about 32-bit features for compat. > * If the system doesn't support AArch32, don't update them. > */ > - if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1)) && > - id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) { > - > + if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1))) { > taint |= check_update_ftr_reg(SYS_ID_DFR0_EL1, cpu, > info->reg_id_dfr0, boot->reg_id_dfr0); > taint |= check_update_ftr_reg(SYS_ID_ISAR0_EL1, cpu, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B753FC2BA19 for ; Wed, 15 Apr 2020 10:20:53 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 2F7DD20775 for ; Wed, 15 Apr 2020 10:20:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F7DD20775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9CDDA4B16C; Wed, 15 Apr 2020 06:20:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4MbBYXT9gsZm; Wed, 15 Apr 2020 06:20:51 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7ED6D4B1D0; Wed, 15 Apr 2020 06:20:51 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF4AC4B16C for ; Wed, 15 Apr 2020 06:20:50 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uJ0Or75haRIR for ; Wed, 15 Apr 2020 06:20:49 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DCDF34B117 for ; Wed, 15 Apr 2020 06:20:49 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B1B21063; Wed, 15 Apr 2020 03:20:49 -0700 (PDT) Received: from [10.37.12.1] (unknown [10.37.12.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BE9B3F68F; Wed, 15 Apr 2020 03:20:47 -0700 (PDT) Subject: Re: [PATCH 4/8] arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <20200414213114.2378-1-will@kernel.org> <20200414213114.2378-5-will@kernel.org> From: Suzuki K Poulose Message-ID: <8f911640-8b7d-bb6f-2b76-67dd0d259b75@arm.com> Date: Wed, 15 Apr 2020 11:25:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200414213114.2378-5-will@kernel.org> Content-Language: en-US Cc: saiprakash.ranjan@codeaurora.org, anshuman.khandual@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, catalin.marinas@arm.com, kernel-team@android.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 04/14/2020 10:31 PM, Will Deacon wrote: > There's no need to call id_aa64pfr0_32bit_el0() twice because the > sanitised value of ID_AA64PFR0_EL1 has already been updated for the CPU > being onlined. > > Remove the redundant function call. > > Signed-off-by: Will Deacon Reviewed-by: Suzuki K Poulose > --- > arch/arm64/kernel/cpufeature.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 838fe5cc8d7e..7dfcdd9e75c1 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -792,9 +792,7 @@ void update_cpu_features(int cpu, > * If we have AArch32, we care about 32-bit features for compat. > * If the system doesn't support AArch32, don't update them. > */ > - if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1)) && > - id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) { > - > + if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1))) { > taint |= check_update_ftr_reg(SYS_ID_DFR0_EL1, cpu, > info->reg_id_dfr0, boot->reg_id_dfr0); > taint |= check_update_ftr_reg(SYS_ID_ISAR0_EL1, cpu, > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DC0C3815B for ; Wed, 15 Apr 2020 10:20:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 026EB20775 for ; Wed, 15 Apr 2020 10:20:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ma+E4Pm8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 026EB20775 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C5OuL2Osb46yTiW0swDmBC4NaKU4IoL5pxZPNFRFxw8=; b=Ma+E4Pm8/9jPV5Hk/KPgp1T2W YlK/TSDqxWTi5gmU4LYET6znASOf1t9DjqEtVQ6DIAC9cLnAZzSi6XAOqoeYhI5l6280dvzS5JEkP MQgLigch10M+apiM11DSpqTIPlc0kY81yj+//qBvV0dX14OTedGUUUrUw7CJCH2jwPOBYD8aKhXrz JW4IXePxgNFIE6+XlJYVGb1+PYs3IQBJSsgsQP9VxZV/gJgv1o3EewulQ040Bme18e1Xa6ksK/z3W weUQ/H1Ea6bcU4AMyKzdahAKQKIyyThAxjvgScsmmkbJJCUHv8QMs1Wo208AeAOAy4iit9Ly3bTeG HLIoSWzJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOfA5-00022W-Vq; Wed, 15 Apr 2020 10:20:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOfA2-0001yQ-FE for linux-arm-kernel@lists.infradead.org; Wed, 15 Apr 2020 10:20:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B1B21063; Wed, 15 Apr 2020 03:20:49 -0700 (PDT) Received: from [10.37.12.1] (unknown [10.37.12.1]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2BE9B3F68F; Wed, 15 Apr 2020 03:20:47 -0700 (PDT) Subject: Re: [PATCH 4/8] arm64: cpufeature: Remove redundant call to id_aa64pfr0_32bit_el0() To: will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu References: <20200414213114.2378-1-will@kernel.org> <20200414213114.2378-5-will@kernel.org> From: Suzuki K Poulose Message-ID: <8f911640-8b7d-bb6f-2b76-67dd0d259b75@arm.com> Date: Wed, 15 Apr 2020 11:25:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200414213114.2378-5-will@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200415_032050_714669_4212DB9E X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, saiprakash.ranjan@codeaurora.org, anshuman.khandual@arm.com, maz@kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, catalin.marinas@arm.com, kernel-team@android.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/14/2020 10:31 PM, Will Deacon wrote: > There's no need to call id_aa64pfr0_32bit_el0() twice because the > sanitised value of ID_AA64PFR0_EL1 has already been updated for the CPU > being onlined. > > Remove the redundant function call. > > Signed-off-by: Will Deacon Reviewed-by: Suzuki K Poulose > --- > arch/arm64/kernel/cpufeature.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > index 838fe5cc8d7e..7dfcdd9e75c1 100644 > --- a/arch/arm64/kernel/cpufeature.c > +++ b/arch/arm64/kernel/cpufeature.c > @@ -792,9 +792,7 @@ void update_cpu_features(int cpu, > * If we have AArch32, we care about 32-bit features for compat. > * If the system doesn't support AArch32, don't update them. > */ > - if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1)) && > - id_aa64pfr0_32bit_el0(info->reg_id_aa64pfr0)) { > - > + if (id_aa64pfr0_32bit_el0(read_sanitised_ftr_reg(SYS_ID_AA64PFR0_EL1))) { > taint |= check_update_ftr_reg(SYS_ID_DFR0_EL1, cpu, > info->reg_id_dfr0, boot->reg_id_dfr0); > taint |= check_update_ftr_reg(SYS_ID_ISAR0_EL1, cpu, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel