From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/5] drm/i915/gt: Push engine stopping into reset-prepare Date: Wed, 17 Jul 2019 14:42:15 +0100 Message-ID: <8f97cfb9-3cd9-ac96-f28f-1415fe9bbe6b@linux.intel.com> References: <20190716124931.5870-1-chris@chris-wilson.co.uk> <20190716124931.5870-2-chris@chris-wilson.co.uk> <156336891995.4375.4394847020984312949@skylake-alporthouse-com> <156337025269.4375.8104628033771518861@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADEA66E188 for ; Wed, 17 Jul 2019 13:42:17 +0000 (UTC) In-Reply-To: <156337025269.4375.8104628033771518861@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE3LzA3LzIwMTkgMTQ6MzAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTA3LTE3IDE0OjIxOjUwKQo+Pgo+PiBPbiAxNy8wNy8yMDE5IDE0OjA4 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE5LTA3 LTE3IDE0OjA0OjM0KQo+Pj4+Cj4+Pj4gT24gMTYvMDcvMjAxOSAxMzo0OSwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBQdXNoIHRoZSBlbmdpbmUgc3RvcCBpbnRvIHRoZSBiYWNrIHJlc2V0X3By ZXBhcmUgKHdoZXJlIGl0IGFscmVhZHkgd2FzISkKPj4+Pj4gVGhpcyBhbGxvd3MgdXMgdG8gYXZv aWQgZGFuZ2Vyb3VzbHkgc2V0dGluZyB0aGUgUklORyByZWdpc3RlcnMgdG8gMCBmb3IKPj4+Pj4g bG9naWNhbCBjb250ZXh0cy4gSWYgd2UgY2xlYXIgdGhlIHJlZ2lzdGVyIG9uIGEgbGl2ZSBjb250 ZXh0LCB0aG9zZQo+Pj4+PiBpbnZhbGlkIHJlZ2lzdGVyIHZhbHVlcyBhcmUgcmVjb3JkZWQgaW4g dGhlIGxvZ2ljYWwgY29udGV4dCBzdGF0ZSBhbmQKPj4+Pj4gcmVwbGF5ZWQgKHdpdGggaGlsYXJp b3VzIHJlc3VsdHMpLgo+Pj4+Cj4+Pj4gU28gZXNzZW50aWFsbHkgc3RhdGVtZW50IGlzIGdlbjNf c3RvcF9lbmdpbmUgaXMgbm90IG5lZWRlZCBhbmQgZXZlbgo+Pj4+IGRhbmdlcm91cyB3aXRoIGV4 ZWNsaXN0cz8KPj4+Cj4+PiBZZXMuIEl0IGhhcyBiZWVuIGEgbnVpc2FuY2UgaW4gdGhlIHBhc3Qs IHdoaWNoIGlzIHdoeSB3ZSB0cnkgdG8gYXZvaWQKPj4+IGl0LiBJIGhhdmUgY29tZSB0byBjb25j bHVzaW9uIHRoYXQgaXQgc2VydmVzIG5vIHB1cnBvc2UgZm9yIGV4ZWNsaXN0cwo+Pj4gYW5kIG9u bHkgbWFrZXMgcmVjb3Zlcnkgd29yc2UuCj4+Pgo+Pj4+Cj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYt Ynk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+Pj4+PiAtLS0KPj4+ Pj4gICAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d0L2ludGVsX2xyYy5jICAgICAgICB8IDE2ICsr KysrLQo+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmVzZXQuYyAgICAg IHwgNTggLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+Pj4+PiAgICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvZ3QvaW50ZWxfcmluZ2J1ZmZlci5jIHwgNDAgKysrKysrKysrKysrKystCj4+Pj4+ICAgICAz IGZpbGVzIGNoYW5nZWQsIDUzIGluc2VydGlvbnMoKyksIDYxIGRlbGV0aW9ucygtKQo+Pj4+Pgo+ Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfbHJjLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9scmMuYwo+Pj4+PiBpbmRleCA5ZTA5OTI0OTgw ODcuLjliODdhMmZjMTg2YyAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3QvaW50ZWxfbHJjLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxf bHJjLmMKPj4+Pj4gQEAgLTIxNzMsMTEgKzIxNzMsMjMgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3Rz X3Jlc2V0X3ByZXBhcmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4+PiAgICAg ICAgIF9fdGFza2xldF9kaXNhYmxlX3N5bmNfb25jZSgmZXhlY2xpc3RzLT50YXNrbGV0KTsKPj4+ Pj4gICAgICAgICBHRU1fQlVHX09OKCFyZXNldF9pbl9wcm9ncmVzcyhleGVjbGlzdHMpKTsKPj4+ Pj4gICAgIAo+Pj4+PiAtICAgICBpbnRlbF9lbmdpbmVfc3RvcF9jcyhlbmdpbmUpOwo+Pj4+PiAt Cj4+Pj4+ICAgICAgICAgLyogQW5kIGZsdXNoIGFueSBjdXJyZW50IGRpcmVjdCBzdWJtaXNzaW9u LiAqLwo+Pj4+PiAgICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPmFjdGl2ZS5sb2Nr LCBmbGFncyk7Cj4+Pj4+ICAgICAgICAgc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZW5naW5lLT5h Y3RpdmUubG9jaywgZmxhZ3MpOwo+Pj4+PiArCj4+Pj4+ICsgICAgIC8qCj4+Pj4+ICsgICAgICAq IFdlIHN0b3AgZW5naW5lcywgb3RoZXJ3aXNlIHdlIG1pZ2h0IGdldCBmYWlsZWQgcmVzZXQgYW5k IGEKPj4+Pj4gKyAgICAgICogZGVhZCBncHUgKG9uIGVsaykuIEFsc28gYXMgbW9kZXJuIGdwdSBh cyBrYmwgY2FuIHN1ZmZlcgo+Pj4+PiArICAgICAgKiBmcm9tIHN5c3RlbSBoYW5nIGlmIGJhdGNo YnVmZmVyIGlzIHByb2dyZXNzaW5nIHdoZW4KPj4+Pj4gKyAgICAgICogdGhlIHJlc2V0IGlzIGlz c3VlZCwgcmVnYXJkbGVzcyBvZiBSRUFEWV9UT19SRVNFVCBhY2suCj4+Pj4+ICsgICAgICAqIFRo dXMgYXNzdW1lIGl0IGlzIGJlc3QgdG8gc3RvcCBlbmdpbmVzIG9uIGFsbCBnZW5zCj4+Pj4+ICsg ICAgICAqIHdoZXJlIHdlIGhhdmUgYSBncHUgcmVzZXQuCj4+Pj4+ICsgICAgICAqCj4+Pj4+ICsg ICAgICAqIFdhS0JMVkVDU1NlbWFwaG9yZVdhaXRQb2xsOmtibCAob24gQUxMX0VOR0lORVMpCj4+ Pj4+ICsgICAgICAqCj4+Pj4+ICsgICAgICAqIEZJWE1FOiBXYSBmb3IgbW9yZSBtb2Rlcm4gZ2Vu cyBuZWVkcyB0byBiZSB2YWxpZGF0ZWQKPj4+Pj4gKyAgICAgICovCj4+Pj4+ICsgICAgIGludGVs X2VuZ2luZV9zdG9wX2NzKGVuZ2luZSk7Cj4+Pj4+ICAgICB9Cj4+Pj4+ICAgICAKPj4+Pj4gICAg IHN0YXRpYyB2b2lkIHJlc2V0X2NzYl9wb2ludGVycyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpl bmdpbmUpCj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndC9pbnRlbF9y ZXNldC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmVzZXQuYwo+Pj4+PiBpbmRl eCA3ZGRlZGZiMTZhYTIuLjU1ZTJkZGNiZDIxNSAxMDA2NDQKPj4+Pj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZ3QvaW50ZWxfcmVzZXQuYwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9ndC9pbnRlbF9yZXNldC5jCj4+Pj4+IEBAIC0xMzUsNDcgKzEzNSw2IEBAIHZvaWQgX19p OTE1X3JlcXVlc3RfcmVzZXQoc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEsIGJvb2wgZ3VpbHR5KQo+ Pj4+PiAgICAgICAgIH0KPj4+Pj4gICAgIH0KPj4+Pj4gICAgIAo+Pj4+PiAtc3RhdGljIHZvaWQg Z2VuM19zdG9wX2VuZ2luZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4+Pj4+IC17 Cj4+Pj4+IC0gICAgIHN0cnVjdCBpbnRlbF91bmNvcmUgKnVuY29yZSA9IGVuZ2luZS0+dW5jb3Jl Owo+Pj4+PiAtICAgICBjb25zdCB1MzIgYmFzZSA9IGVuZ2luZS0+bW1pb19iYXNlOwo+Pj4+PiAt Cj4+Pj4+IC0gICAgIEdFTV9UUkFDRSgiJXNcbiIsIGVuZ2luZS0+bmFtZSk7Cj4+Pj4+IC0KPj4+ Pj4gLSAgICAgaWYgKGludGVsX2VuZ2luZV9zdG9wX2NzKGVuZ2luZSkpCj4+Pj4+IC0gICAgICAg ICAgICAgR0VNX1RSQUNFKCIlczogdGltZWQgb3V0IG9uIFNUT1BfUklOR1xuIiwgZW5naW5lLT5u YW1lKTsKPj4+Pj4gLQo+Pj4+PiAtICAgICBpbnRlbF91bmNvcmVfd3JpdGVfZncodW5jb3JlLAo+ Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgUklOR19IRUFEKGJhc2UpLAo+Pj4+PiAt ICAgICAgICAgICAgICAgICAgICAgICAgICAgaW50ZWxfdW5jb3JlX3JlYWRfZncodW5jb3JlLCBS SU5HX1RBSUwoYmFzZSkpKTsKPj4+Pj4gLSAgICAgaW50ZWxfdW5jb3JlX3Bvc3RpbmdfcmVhZF9m dyh1bmNvcmUsIFJJTkdfSEVBRChiYXNlKSk7IC8qIHBhcmFub2lhICovCj4+Pj4+IC0KPj4+Pj4g LSAgICAgaW50ZWxfdW5jb3JlX3dyaXRlX2Z3KHVuY29yZSwgUklOR19IRUFEKGJhc2UpLCAwKTsK Pj4+Pj4gLSAgICAgaW50ZWxfdW5jb3JlX3dyaXRlX2Z3KHVuY29yZSwgUklOR19UQUlMKGJhc2Up LCAwKTsKPj4+Pj4gLSAgICAgaW50ZWxfdW5jb3JlX3Bvc3RpbmdfcmVhZF9mdyh1bmNvcmUsIFJJ TkdfVEFJTChiYXNlKSk7Cj4+Pj4+IC0KPj4+Pj4gLSAgICAgLyogVGhlIHJpbmcgbXVzdCBiZSBl bXB0eSBiZWZvcmUgaXQgaXMgZGlzYWJsZWQgKi8KPj4+Pj4gLSAgICAgaW50ZWxfdW5jb3JlX3dy aXRlX2Z3KHVuY29yZSwgUklOR19DVEwoYmFzZSksIDApOwo+Pj4+PiAtCj4+Pj4+IC0gICAgIC8q IENoZWNrIGFjdHMgYXMgYSBwb3N0ICovCj4+Pj4+IC0gICAgIGlmIChpbnRlbF91bmNvcmVfcmVh ZF9mdyh1bmNvcmUsIFJJTkdfSEVBRChiYXNlKSkpCj4+Pj4+IC0gICAgICAgICAgICAgR0VNX1RS QUNFKCIlczogcmluZyBoZWFkIFsleF0gbm90IHBhcmtlZFxuIiwKPj4+Pj4gLSAgICAgICAgICAg ICAgICAgICAgICAgZW5naW5lLT5uYW1lLAo+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAgICBp bnRlbF91bmNvcmVfcmVhZF9mdyh1bmNvcmUsIFJJTkdfSEVBRChiYXNlKSkpOwo+Pj4+PiAtfQo+ Pj4+PiAtCj4+Pj4+IC1zdGF0aWMgdm9pZCBzdG9wX2VuZ2luZXMoc3RydWN0IGludGVsX2d0ICpn dCwgaW50ZWxfZW5naW5lX21hc2tfdCBlbmdpbmVfbWFzaykKPj4+Pj4gLXsKPj4+Pj4gLSAgICAg c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lOwo+Pj4+PiAtICAgICBpbnRlbF9lbmdpbmVf bWFza190IHRtcDsKPj4+Pj4gLQo+Pj4+PiAtICAgICBpZiAoSU5URUxfR0VOKGd0LT5pOTE1KSA8 IDMpCj4+Pj4+IC0gICAgICAgICAgICAgcmV0dXJuOwo+Pj4+PiAtCj4+Pj4+IC0gICAgIGZvcl9l YWNoX2VuZ2luZV9tYXNrZWQoZW5naW5lLCBndC0+aTkxNSwgZW5naW5lX21hc2ssIHRtcCkKPj4+ Pj4gLSAgICAgICAgICAgICBnZW4zX3N0b3BfZW5naW5lKGVuZ2luZSk7Cj4+Pj4+IC19Cj4+Pj4+ IC0KPj4+Pj4gICAgIHN0YXRpYyBib29sIGk5MTVfaW5fcmVzZXQoc3RydWN0IHBjaV9kZXYgKnBk ZXYpCj4+Pj4+ICAgICB7Cj4+Pj4+ICAgICAgICAgdTggZ2Ryc3Q7Cj4+Pj4+IEBAIC02MDcsMjMg KzU2Niw2IEBAIGludCBfX2ludGVsX2d0X3Jlc2V0KHN0cnVjdCBpbnRlbF9ndCAqZ3QsIGludGVs X2VuZ2luZV9tYXNrX3QgZW5naW5lX21hc2spCj4+Pj4+ICAgICAgICAgICovCj4+Pj4+ICAgICAg ICAgaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9nZXQoZ3QtPnVuY29yZSwgRk9SQ0VXQUtFX0FMTCk7 Cj4+Pj4+ICAgICAgICAgZm9yIChyZXRyeSA9IDA7IHJldCA9PSAtRVRJTUVET1VUICYmIHJldHJ5 IDwgcmV0cmllczsgcmV0cnkrKykgewo+Pj4+PiAtICAgICAgICAgICAgIC8qCj4+Pj4+IC0gICAg ICAgICAgICAgICogV2Ugc3RvcCBlbmdpbmVzLCBvdGhlcndpc2Ugd2UgbWlnaHQgZ2V0IGZhaWxl ZCByZXNldCBhbmQgYQo+Pj4+PiAtICAgICAgICAgICAgICAqIGRlYWQgZ3B1IChvbiBlbGspLiBB bHNvIGFzIG1vZGVybiBncHUgYXMga2JsIGNhbiBzdWZmZXIKPj4+Pj4gLSAgICAgICAgICAgICAg KiBmcm9tIHN5c3RlbSBoYW5nIGlmIGJhdGNoYnVmZmVyIGlzIHByb2dyZXNzaW5nIHdoZW4KPj4+ Pj4gLSAgICAgICAgICAgICAgKiB0aGUgcmVzZXQgaXMgaXNzdWVkLCByZWdhcmRsZXNzIG9mIFJF QURZX1RPX1JFU0VUIGFjay4KPj4+Pj4gLSAgICAgICAgICAgICAgKiBUaHVzIGFzc3VtZSBpdCBp cyBiZXN0IHRvIHN0b3AgZW5naW5lcyBvbiBhbGwgZ2Vucwo+Pj4+PiAtICAgICAgICAgICAgICAq IHdoZXJlIHdlIGhhdmUgYSBncHUgcmVzZXQuCj4+Pj4+IC0gICAgICAgICAgICAgICoKPj4+Pj4g LSAgICAgICAgICAgICAgKiBXYUtCTFZFQ1NTZW1hcGhvcmVXYWl0UG9sbDprYmwgKG9uIEFMTF9F TkdJTkVTKQo+Pj4+PiAtICAgICAgICAgICAgICAqCj4+Pj4+IC0gICAgICAgICAgICAgICogV2FN ZWRpYVJlc2V0TWFpblJpbmdDbGVhbnVwOmN0ZyxlbGsgKHByZXN1bWFibHkpCj4+Pj4+IC0gICAg ICAgICAgICAgICoKPj4+Pj4gLSAgICAgICAgICAgICAgKiBGSVhNRTogV2EgZm9yIG1vcmUgbW9k ZXJuIGdlbnMgbmVlZHMgdG8gYmUgdmFsaWRhdGVkCj4+Pj4+IC0gICAgICAgICAgICAgICovCj4+ Pj4+IC0gICAgICAgICAgICAgaWYgKHJldHJ5KQo+Pj4+PiAtICAgICAgICAgICAgICAgICAgICAg c3RvcF9lbmdpbmVzKGd0LCBlbmdpbmVfbWFzayk7Cj4+Pj4+IC0KPj4+Pgo+Pj4+IE9ubHkgb3Ro ZXIgZnVuY3Rpb25hbCBjaGFuZ2UgSSBzZWUgaXMgdGhhdCB3ZSBzdG9wIHJldHJ5aW5nIHRvIHN0 b3AgdGhlCj4+Pj4gZW5naW5lcyBiZWZvcmUgcmVzZXQgYXR0ZW1wdHMuIEkgZG9uJ3Qga25vdyBp ZiB0aGF0IGlzIGEgY29uY2VybiBvciBub3QuCj4+Pgo+Pj4gQWgsIGJ1dCB3ZSBkbyBzdG9wIHRo ZSBlbmdpbmUgYmVmb3JlIHJlc2V0cyBpbiAqcmVzZXRfcHJlcGFyZS4gVGhlIG90aGVyCj4+PiBw YXRoIHRvIGFycml2ZSBpcyBpbiBzYW5pdGl6ZSB3aGVyZSB3ZSBkb24ndCBrbm93IGVub3VnaCBz dGF0ZSB0byBzYWZlbHkKPj4+IHR3ZWFrIHRoZSBlbmdpbmVzLiBGb3IgdGhvc2UsIEkgY2xhaW0g aXQgc2hvdWxkbid0IG1hdHRlciBhcyB0aGUgZW5naW5lcwo+Pj4gc2hvdWxkIGJlIGlkbGUgYW5k IHdlIG9ubHkgbmVlZCB0aGUgcmVzZXQgdG8gY2xlYXIgc3RhbGUgY29udGV4dCBzdGF0ZS4KPj4K Pj4gWWVzIEkga25vdyB0aGF0IHdlIGRvIGNhbGwgc3RvcCBpbiBwcmVwYXJlLCBqdXN0IG5vdCBv biB0aGUgcmVzZXQgcmV0cnkKPj4gcGF0aC4gSXQncyB0aGUgYWJvdmUgbG9vcCwgaWYgcmVzZXQg d2FzIGZhaWxpbmcgYW5kIG5lZWRlZCByZXRyaWVzCj4+IGJlZm9yZSB3ZSB3b3VsZCByZS1yZXRy aWVkIHN0b3BwaW5nIGVuZ2luZXMgYW5kIG5vdyB3ZSB3b3VsZCBub3QuCj4gCj4gVGhlIGVuZ2lu ZXMgYXJlIHN0aWxsIHN0b3BwZWQuIFRoZSBmdW5jdGlvbmFsIGNoYW5nZSBpcyB0byByZW1vdmUg dGhlCj4gZGFuZ2Vyb3VzIGNsZWFyaW5nIG9mIFJJTkdfSEVBRC9DVEwuCgpPa2F5IGZvciBleGVj bGlzdHMsIGJ1dCBmb3IgcmluZ2J1ZmZlciBJIHdhcyBzaW1wbHkgYXNraW5nIGlmIF9vbmVfIG9m IAp0aGUgcmVhc29ucyBmb3IgZmFpbGVkIHJlc2V0IGNvdWxkIGJlIGZhaWx1cmUgdG8gc3RvcCBj cy4gSW4gd2hpY2ggY2FzZSAKcmVtb3ZhbCBvZiBzdG9wX2VuZ2luZXMgZnJvbSB0aGUgcmV0cnkg bG9vcCBtaWdodCBiZSBkZXRyaW1lbnRhbCBmb3IgCnJpbmdidWZmZXIuCgpSZWdhcmRzLAoKVHZy dGtvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==