From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D46DCC433F5 for ; Fri, 15 Oct 2021 19:38:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 457B761151 for ; Fri, 15 Oct 2021 19:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 457B761151 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbT2G-0005lW-CJ for qemu-devel@archiver.kernel.org; Fri, 15 Oct 2021 15:38:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbSui-0000J2-UJ for qemu-devel@nongnu.org; Fri, 15 Oct 2021 15:30:53 -0400 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:51456 helo=mail.default.ilande.bv.iomart.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbSud-0000ny-Gf for qemu-devel@nongnu.org; Fri, 15 Oct 2021 15:30:41 -0400 Received: from [2a00:23c4:8b9d:f500:9396:df17:737c:b32c] by mail.default.ilande.bv.iomart.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mbSuI-000BN4-0x; Fri, 15 Oct 2021 20:30:22 +0100 To: Laurent Vivier , qemu-devel@nongnu.org References: <20211013212132.31519-1-mark.cave-ayland@ilande.co.uk> <20211013212132.31519-2-mark.cave-ayland@ilande.co.uk> From: Mark Cave-Ayland Message-ID: <8f99f470-bdde-97e5-32bf-a8e519f607ad@ilande.co.uk> Date: Fri, 15 Oct 2021 20:30:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a00:23c4:8b9d:f500:9396:df17:737c:b32c X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH 1/8] mac_via: update comment for VIA1B_vMystery bit X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.bv.iomart.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.bv.iomart.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 15/10/2021 07:14, Laurent Vivier wrote: > Le 13/10/2021 à 23:21, Mark Cave-Ayland a écrit : >> According to both Linux and NetBSD, port B bit 6 is used on the Quadra 800 to >> configure the GLUE logic in A/UX mode. Whilst the name VIA1B_vMystery isn't >> particularly descriptive, the patch leaves this to ensure that the constants >> in mac_via.c remain in sync with Linux's mac_via.h. >> >> Signed-off-by: Mark Cave-Ayland >> --- >> hw/misc/mac_via.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c >> index 993bac017d..7a53a8b4c0 100644 >> --- a/hw/misc/mac_via.c >> +++ b/hw/misc/mac_via.c >> @@ -130,6 +130,10 @@ >> * On SE/30, vertical sync interrupt enable. >> * 0=enabled. This vSync interrupt shows up >> * as a slot $E interrupt. >> + * On Quadra 800 this bit toggles A/UX mode which >> + * configures the glue logic to deliver some IRQs >> + * at different levels compared to a classic >> + * Mac. >> */ >> #define VIA1B_vADBS2 0x20 /* ADB state input bit 1 (unused on IIfx) */ >> #define VIA1B_vADBS1 0x10 /* ADB state input bit 0 (unused on IIfx) */ >> > > I'm not sure we need to keep in sync a word that neither used by linux or qemu (for now). > > Perhaps you can put a word from where it is (NetBSD)? > > It seems it's supported by all Quadra, not only Quadra 800 (see NetBSD comment in mac68k/machdep.c > > Anyway: > > Reviewed-by: Laurent Vivier Yeah, it's a hard one: you can see the bit referenced in the via_alt_mapping logic in Linux but mac_via.h still shows it as VIA1B_vMystery (and indeed, it seems to have different uses on different machines). The thought behind adding the comment was to better explain the purpose of VIA1B_vMystery within the series. ATB, Mark.