All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH rdma-core 1/2] suse: Add spec file for SUSE
@ 2017-08-24 14:49 Nicolas Morey-Chaisemartin
       [not found] ` <abf2bc82-824b-a1d9-bc6b-a3a77045d633-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-24 14:49 UTC (permalink / raw)
  To: linux-rdma-u79uwXL29TY76Z2rM5mHXA

Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin-IBi9RG/b67k@public.gmane.org>
---
 MAINTAINERS         |   5 +
 suse/rdma-core.spec | 687 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 692 insertions(+)
 create mode 100644 suse/rdma-core.spec

diff --git a/MAINTAINERS b/MAINTAINERS
index 19fe88df..08286cb5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -166,6 +166,11 @@ M:	Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
 S:	Supported
 F:	srp_daemon/
 
+SUSE PACKAGING
+M:	Nicolas Morey-Chaisemartin <nmoreychaisemartin-l3A5Bk7waGM@public.gmane.org>
+S:	Supported
+F:	suse/
+
 VMWARE PVRDMA USERSPACE PROVIDER (for vmw_pvrdma.ko)
 M:	Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
 L:	pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec
new file mode 100644
index 00000000..70d9eb2c
--- /dev/null
+++ b/suse/rdma-core.spec
@@ -0,0 +1,687 @@
+#
+# spec file for package rdma-core
+#
+# Copyright (c) 2017 SUSE LINUX GmbH, Nuernberg, Germany.
+#
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
+# Please submit bugfixes or comments via http://bugs.opensuse.org/
+#
+
+
+%bcond_without  systemd
+%define         git_ver %{nil}
+Name:           rdma-core
+Version:        15
+Release:        0
+Summary:        RDMA core userspace libraries and daemons
+License:        GPL-2.0 or BSD-2-Clause
+Group:          Productivity/Networking/Other
+
+%define verbs_so_major  1
+%define ibcm_so_major   1
+%define rdmacm_so_major 1
+%define umad_so_major   3
+%define mlx4_so_major   1
+%define mlx5_so_major   1
+
+%define  verbs_lname  libibverbs%{verbs_so_major}
+%define  ibcm_lname   libibcm%{ibcm_so_major}
+%define  rdmacm_lname librdmacm%{rdmacm_so_major}
+%define  umad_lname   libibumad%{umad_so_major}
+%define  mlx4_lname   libmlx4-%{mlx4_so_major}
+%define  mlx5_lname   libmlx5-%{mlx5_so_major}
+
+%ifnarch s390 %arm
+%define dma_coherent 1
+%endif
+
+# Almost everything is licensed under the OFA dual GPLv2, 2 Clause BSD license
+#  providers/ipathverbs/ Dual licensed using a BSD license with an extra patent clause
+#  providers/rxe/ Incorporates code from ipathverbs and contains the patent clause
+#  providers/hfi1verbs Uses the 3 Clause BSD license
+Url:            https://github.com/linux-rdma/rdma-core
+Source:         rdma-core-%{version}%{git_ver}.tar.gz
+Source1:        baselibs.conf
+BuildRequires:  binutils
+BuildRequires:  cmake >= 2.8.11
+BuildRequires:  gcc
+BuildRequires:  pkgconfig
+BuildRequires:  pkgconfig(libsystemd)
+BuildRequires:  pkgconfig(libudev)
+BuildRequires:  pkgconfig(systemd)
+%ifnarch s390 s390x
+BuildRequires:  valgrind-devel
+%endif
+BuildRequires:  systemd-rpm-macros
+BuildRequires:  pkgconfig(libnl-3.0)
+BuildRequires:  pkgconfig(libnl-route-3.0)
+BuildRequires:  pkgconfig(systemd)
+Requires:       dracut
+Requires:       kmod
+Requires:       systemd
+
+# SUSE previously shipped rdma as a stand-alone
+# package which we're supplanting here.
+
+Provides:       rdma = %{version}
+Obsoletes:      rdma < %{version}
+Provides:       ofed = %{version}
+Obsoletes:      ofed < %{version}
+
+%if 0%{?suse_version} >= 1330
+BuildRequires:  curl-mini
+%endif
+
+# Tumbleweed's cmake RPM macro adds -Wl,--no-undefined to the module flags
+# which is totally inappropriate and breaks building 'ENABLE_EXPORTS' style
+# module libraries (eg ibacmp).
+#%%define CMAKE_FLAGS -DCMAKE_MODULE_LINKER_FLAGS=""
+
+# Since we recommend developers use Ninja, so should packagers, for consistency.
+%define CMAKE_FLAGS %{nil}
+%if 0%{?suse_version} >= 1300
+BuildRequires:  ninja
+%define CMAKE_FLAGS -GNinja
+%define make_jobs ninja -v %{?_smp_mflags}
+%define cmake_install DESTDIR=%{buildroot} ninja install
+%else
+# Fallback to make otherwise
+BuildRequires:  make
+%define make_jobs make -v %{?_smp_mflags}
+%define cmake_install DESTDIR=%{buildroot} make install
+%endif
+
+%description
+RDMA core userspace infrastructure and documentation, including initialization
+scripts, kernel driver-specific modprobe override configs, IPoIB network
+scripts, dracut rules, and the rdma-ndd utility.
+
+%package devel
+Summary:        RDMA core development libraries and headers
+Group:          Development/Libraries/C and C++
+Requires:       %{name}%{?_isa} = %{version}-%{release}
+
+Requires:       %{ibcm_lname} = %{version}-%{release}
+Requires:       %{rdmacm_lname} = %{version}-%{release}
+Requires:       %{umad_lname} = %{version}-%{release}
+Requires:       %{verbs_lname} = %{version}-%{release}
+%%if 0%{?dma_coherent}
+Requires:       %{mlx4_lname} = %{version}-%{release}
+Requires:       %{mlx5_lname} = %{version}-%{release}
+%endif
+Requires:       rsocket = %{version}-%{release}
+
+Provides:       libibverbs-devel = %{version}-%{release}
+Obsoletes:      libibverbs-devel < %{version}-%{release}
+
+Provides:       libibcm-devel = %{version}-%{release}
+Obsoletes:      libibcm-devel < %{version}-%{release}
+
+Provides:       libibumad-devel = %{version}-%{release}
+Obsoletes:      libibumad-devel < %{version}-%{release}
+Provides:       librdmacm-devel = %{version}-%{release}
+
+Obsoletes:      librdmacm-devel < %{version}-%{release}
+#Requires:       ibacm = %%{version}-%%{release}
+Provides:       ibacm-devel = %{version}-%{release}
+Obsoletes:      ibacm-devel < %{version}-%{release}
+
+%description devel
+RDMA core development libraries and headers.
+
+%package -n     libibverbs
+Summary:        Library & drivers for direct userspace use of InfiniBand/iWARP/RoCE hardware
+Group:          System/Libraries
+Requires:       %{name}%{?_isa} = %{version}-%{release}
+Obsoletes:      libcxgb3-rdmav2 < %{version}-%{release}
+Obsoletes:      libcxgb4-rdmav2 < %{version}-%{release}
+Obsoletes:      libhfi1verbs-rdmav2 < %{version}-%{release}
+Obsoletes:      libi40iw-rdmav2 < %{version}-%{release}
+Obsoletes:      libipathverbs-rdmav2 < %{version}-%{release}
+Obsoletes:      libmlx4-rdmav2 < %{version}-%{release}
+Obsoletes:      libmlx5-rdmav2 < %{version}-%{release}
+Obsoletes:      libmthca-rdmav2 < %{version}-%{release}
+Obsoletes:      libnes-rdmav2 < %{version}-%{release}
+Obsoletes:      libocrdma-rdmav2 < %{version}-%{release}
+Obsoletes:      librxe-rdmav2 < %{version}-%{release}
+%if 0%{?dma_coherent}
+Requires:       %{mlx4_lname} = %{version}-%{release}
+Requires:       %{mlx5_lname} = %{version}-%{release}
+%endif
+
+%description -n libibverbs
+libibverbs is a library that allows userspace processes to use RDMA
+"verbs" as described in the InfiniBand Architecture Specification and
+the RDMA Protocol Verbs Specification.  This includes direct hardware
+access from userspace to InfiniBand/iWARP adapters (kernel bypass) for
+fast path operations.
+
+Device-specific plug-in ibverbs userspace drivers are included:
+
+- libcxgb3: Chelsio T3 iWARP HCA
+- libcxgb4: Chelsio T4 iWARP HCA
+- libhfi1: Intel Omni-Path HFI
+- libhns: HiSilicon Hip06 SoC
+- libi40iw: Intel Ethernet Connection X722 RDMA
+- libipathverbs: QLogic InfiniPath HCA
+- libmlx4: Mellanox ConnectX-3 InfiniBand HCA
+- libmlx5: Mellanox Connect-IB/X-4+ InfiniBand HCA
+- libmthca: Mellanox InfiniBand HCA
+- libnes: NetEffect RNIC
+- libocrdma: Emulex OneConnect RDMA/RoCE Device
+- libqedr: QLogic QL4xxx RoCE HCA
+- librxe: A software implementation of the RoCE protocol
+- libvmw_pvrdma: VMware paravirtual RDMA device
+
+%package -n %verbs_lname
+Summary:        Ibverbs runtime library
+Group:          System/Libraries
+Requires:       libibverbs = %{version}
+
+%description -n %verbs_lname
+This package contains the ibverbs runtime library.
+
+%if 0%{?dma_coherent}
+%package -n %mlx4_lname
+Summary:        MLX4 runtime library
+Group:          System/Libraries
+
+%description -n %mlx4_lname
+This package contains the mlx4 runtime library.
+
+%package -n %mlx5_lname
+Summary:        MLX5 runtime library
+Group:          System/Libraries
+
+%description -n %mlx5_lname
+This package contains the mlx5 runtime library.
+%endif
+
+%package -n     libibverbs-utils
+Summary:        Examples for the libibverbs library
+Group:          Productivity/Networking/Other
+Requires:       libibverbs%{?_isa} = %{version}
+
+%description -n libibverbs-utils
+Useful libibverbs example programs such as ibv_devinfo, which
+displays information about RDMA devices.
+
+%package -n     ibacm
+Summary:        InfiniBand Communication Manager Assistant
+Group:          Productivity/Networking/Other
+%{?systemd_requires}
+Requires:       %{name}%{?_isa} = %{version}
+Obsoletes:      libibacmp1 < %{version}
+Provides:       libibacmp1 = %{version}
+
+%description -n ibacm
+The ibacm daemon helps reduce the load of managing path record lookups on
+large InfiniBand fabrics by providing a user space implementation of what
+is functionally similar to an ARP cache.  The use of ibacm, when properly
+configured, can reduce the SA packet load of a large IB cluster from O(n^2)
+to O(n).  The ibacm daemon is started and normally runs in the background,
+user applications need not know about this daemon as long as their app
+uses librdmacm to handle connection bring up/tear down.  The librdmacm
+library knows how to talk directly to the ibacm daemon to retrieve data.
+
+%package -n iwpmd
+Summary:        Userspace iWarp Port Mapper daemon
+Group:          Development/Libraries/C and C++
+Requires:       %{name}%{?_isa} = %{version}
+%{?systemd_requires}
+
+%description -n iwpmd
+iwpmd provides a userspace service for iWarp drivers to claim
+tcp ports through the standard socket interface.
+
+%package -n %ibcm_lname
+Summary:        Userspace InfiniBand Connection Manager
+Group:          System/Libraries
+
+%description -n %ibcm_lname
+libibcm provides a userspace library that handles the majority of the low
+level work required to open an RDMA connection between two machines.
+
+%package -n %umad_lname
+Summary:        OpenFabrics Alliance InfiniBand Userspace Management Datagram library
+Group:          System/Libraries
+
+%description -n %umad_lname
+libibumad provides the userspace management datagram (umad) library
+functions, which sit on top of the umad modules in the kernel. These
+are used by the IB diagnostic and management tools, including OpenSM.
+
+%package -n     %rdmacm_lname
+Summary:        Userspace RDMA Connection Manager
+Group:          System/Libraries
+Requires:       %{name} = %{version}
+
+%description -n %rdmacm_lname
+librdmacm provides a userspace RDMA Communication Management API.
+
+%package -n rsocket
+Summary:        Preloadable library to turn the socket API RDMA-aware
+Group:          System/Libraries
+
+%description -n rsocket
+Existing applications can make use of rsockets through the use this
+preloadable library. See the documentation in the packaged rsocket(7)
+manpage for details.
+
+%package -n librdmacm-utils
+Summary:        Examples for the librdmacm library
+Group:          Productivity/Networking/Other
+
+%description -n librdmacm-utils
+Example test programs for the librdmacm library.
+
+%package -n srp_daemon
+Summary:        Tools for using the InfiniBand SRP protocol devices
+Group:          Development/Libraries/C and C++
+Requires:       %{name} = %{version}
+Obsoletes:      srptools <= 1.0.3
+Provides:       srptools = %{version}
+%{?systemd_requires}
+
+%description -n srp_daemon
+In conjunction with the kernel ib_srp driver, srp_daemon allows you to
+discover and use SCSI devices via the SCSI RDMA Protocol over InfiniBand.
+
+%package     -n rdma-ndd
+Summary:        Daemon to manage RDMA Node Description
+Group:          System/Daemons
+Requires:       %{name} = %{version}
+# The udev rules in rdma need to be aware of rdma-ndd:
+Conflicts:      rdma < 2.1
+%{?systemd_requires}
+
+%description -n rdma-ndd
+rdma-ndd is a system daemon which watches for rdma device changes and/or
+hostname changes and updates the Node Description of the rdma devices based
+on those changes.
+
+%prep
+%setup -q -n  %{name}-%{version}%{git_ver}
+
+%build
+
+# New RPM defines _rundir, usually as /run
+%if 0%{?_rundir:1}
+%else
+%define _rundir /var/run
+%endif
+
+# Pass all of the rpm paths directly to GNUInstallDirs and our other defines.
+%cmake %{CMAKE_FLAGS} \
+	 -DCMAKE_MODULE_LINKER_FLAGS="-Wl,--as-needed -Wl,-z,now" \
+         -DCMAKE_BUILD_TYPE=Release \
+         -DCMAKE_INSTALL_BINDIR:PATH=%{_bindir} \
+         -DCMAKE_INSTALL_SBINDIR:PATH=%{_sbindir} \
+         -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir} \
+         -DCMAKE_INSTALL_LIBEXECDIR:PATH=%{_libexecdir} \
+         -DCMAKE_INSTALL_LOCALSTATEDIR:PATH=%{_localstatedir} \
+         -DCMAKE_INSTALL_SHAREDSTATEDIR:PATH=%{_sharedstatedir} \
+         -DCMAKE_INSTALL_INCLUDEDIR:PATH=%{_includedir} \
+         -DCMAKE_INSTALL_INFODIR:PATH=%{_infodir} \
+         -DCMAKE_INSTALL_MANDIR:PATH=%{_mandir} \
+         -DCMAKE_INSTALL_SYSCONFDIR:PATH=%{_sysconfdir} \
+         -DCMAKE_INSTALL_SYSTEMD_SERVICEDIR:PATH=%{_unitdir} \
+         -DCMAKE_INSTALL_INITDDIR:PATH=%{_initddir} \
+         -DCMAKE_INSTALL_RUNDIR:PATH=%{_rundir} \
+         -DCMAKE_INSTALL_DOCDIR:PATH=%{_docdir}/%{name}-%{version} \
+         -DCMAKE_INSTALL_UDEV_RULESDIR:PATH=%{_udevrulesdir}
+%make_jobs
+
+%install
+cd build
+%cmake_install
+cd ..
+mkdir -p %{buildroot}/%{_sysconfdir}/rdma
+
+%global dracutlibdir %%{_sysconfdir}/dracut.conf.d
+%global sysmodprobedir %%{_sysconfdir}/modprobe.d
+
+mkdir -p %{buildroot}%{_libexecdir}/udev/rules.d
+mkdir -p %{buildroot}%{_udevrulesdir}
+mkdir -p %{buildroot}%{dracutlibdir}/modules.d/05rdma
+mkdir -p %{buildroot}%{sysmodprobedir}
+mkdir -p %{buildroot}%{_unitdir}
+
+install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf
+sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service
+chmod 0644 %{buildroot}%{_unitdir}/rdma.service
+install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs
+install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf
+install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules
+sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
+chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
+install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules
+sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
+chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
+
+sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel
+chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel
+install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf
+install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk
+install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh
+
+mv %{buildroot}%{_sysconfdir}/modprobe.d/truescale.conf %{buildroot}%{_sysconfdir}/modprobe.d/50-truescale.conf
+%if 0%{?dma_coherent}
+mv %{buildroot}%{_sysconfdir}/modprobe.d/mlx4.conf %{buildroot}%{_sysconfdir}/modprobe.d/50-mlx4.conf
+%endif
+
+# ibacm
+cd build
+LD_LIBRARY_PATH=./lib bin/ib_acme -D . -O
+install -D -m0644 ibacm_opts.cfg %{buildroot}%{_sysconfdir}/rdma/
+
+for service in rdma rdma-ndd ibacm iwpmd srp_daemon; do ln -sf %{_sbindir}/service %{buildroot}%{_sbindir}/rc${service}; done
+
+# Delete the package's init.d scripts
+rm -rf %{buildroot}/%{_initddir}/
+rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
+
+%post -n %verbs_lname -p /sbin/ldconfig
+%postun -n %verbs_lname -p /sbin/ldconfig
+
+%if 0%{?dma_coherent}
+%post -n %mlx4_lname -p /sbin/ldconfig
+%postun -n %mlx4_lname -p /sbin/ldconfig
+
+%post -n %mlx5_lname -p /sbin/ldconfig
+%postun -n %mlx5_lname -p /sbin/ldconfig
+%endif
+
+%post -n %ibcm_lname -p /sbin/ldconfig
+%postun -n %ibcm_lname -p /sbin/ldconfig
+
+%post -n %umad_lname -p /sbin/ldconfig
+%postun -n %umad_lname -p /sbin/ldconfig
+
+%post -n %rdmacm_lname -p /sbin/ldconfig
+%postun -n %rdmacm_lname -p /sbin/ldconfig
+
+%pre
+%service_add_pre rdma.service rdma-load-modules@.service rdma-hw.target
+
+%post
+%service_add_post rdma.service rdma-load-modules@.service rdma-hw.target
+
+%preun
+%service_del_preun rdma.service rdma-load-modules@.service rdma-hw.target
+
+%postun
+%service_del_postun rdma.service rdma-load-modules@.service rdma-hw.target
+
+#
+# ibacm
+#
+%pre -n ibacm
+%service_add_pre ibacm.service ibacm.socket
+
+%post -n ibacm
+%service_add_post ibacm.service ibacm.socket
+
+%preun -n ibacm
+%service_del_preun ibacm.service ibacm.socket
+
+%postun -n ibacm
+%service_del_postun ibacm.service ibacm.socket
+
+#
+# srp daemon
+#
+%pre -n srp_daemon
+%service_add_pre srp_daemon.service srp_daemon_port@.service
+
+%post -n srp_daemon
+%service_add_post srp_daemon.service srp_daemon_port@.service
+
+%preun -n srp_daemon
+%service_del_preun srp_daemon.service srp_daemon_port@.service
+
+%postun -n srp_daemon
+%service_del_postun srp_daemon.service srp_daemon_port@.service
+
+#
+# iwpmd
+#
+%pre -n iwpmd
+%service_add_pre ibiwpmd.service
+
+%post -n iwpmd
+%service_add_post iwpmd.service
+
+%preun -n iwpmd
+%service_del_preun iwpmd.service
+
+%postun -n iwpmd
+%service_del_postun iwpmd.service
+
+#
+# rdma-ndd
+#
+%pre -n rdma-ndd
+%service_add_pre rdma-ndd.service
+
+%preun -n rdma-ndd
+%service_del_preun rdma-ndd.service
+
+%post -n rdma-ndd
+%service_add_post rdma-ndd.service
+
+%postun -n rdma-ndd
+%service_del_postun rdma-ndd.service
+
+%files
+%defattr(-,root,root)
+%dir %{_sysconfdir}/rdma
+%dir %{_sysconfdir}/rdma/modules
+%dir %{_docdir}/%{name}-%{version}
+%dir %{_libexecdir}/udev
+%dir %{_libexecdir}/udev/rules.d
+%dir %{_sysconfdir}/modprobe.d
+%doc %{_docdir}/%{name}-%{version}/README.md
+%config(noreplace) %{_sysconfdir}/rdma/mlx4.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/infiniband.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/iwarp.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/opa.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/rdma.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/roce.conf
+%config(noreplace) %{_sysconfdir}/rdma/rdma.conf
+%config(noreplace) %{_sysconfdir}/rdma/sriov-vfs
+%if 0%{?dma_coherent}
+%config(noreplace) %{_sysconfdir}/modprobe.d/50-mlx4.conf
+%endif
+%config(noreplace) %{_sysconfdir}/modprobe.d/50-truescale.conf
+%{_unitdir}/rdma-hw.target
+%{_unitdir}/rdma-load-modules@.service
+%{_unitdir}/rdma.service
+%dir %{dracutlibdir}
+%dir %{dracutlibdir}/modules.d
+%dir %{dracutlibdir}/modules.d/05rdma
+%{dracutlibdir}/modules.d/05rdma/module-setup.sh
+%{_udevrulesdir}/60-rdma-ndd.rules
+%{_udevrulesdir}/70-persistent-ipoib.rules
+%{_udevrulesdir}/75-rdma-description.rules
+%{_udevrulesdir}/90-rdma-hw-modules.rules
+%{_udevrulesdir}/90-rdma-ulp-modules.rules
+%{_udevrulesdir}/90-rdma-umad.rules
+%{_udevrulesdir}/98-rdma.rules
+%config %{sysmodprobedir}/50-libmlx4.conf
+%{_libexecdir}/rdma-init-kernel
+%{_libexecdir}/rdma-set-sriov-vf
+%{_libexecdir}/rdma-fixup-mtrr.awk
+%{_libexecdir}/mlx4-setup.sh
+%{_libexecdir}/truescale-serdes.cmds
+%license COPYING.*
+%{_sbindir}/rcrdma
+
+%files devel
+%defattr(-,root,root)
+%doc %{_docdir}/%{name}-%{version}/MAINTAINERS
+%dir %{_includedir}/infiniband
+%dir %{_includedir}/rdma
+%{_includedir}/infiniband/*
+%{_includedir}/rdma/*
+%{_libdir}/lib*.so
+%{_mandir}/man3/ibv_*
+%{_mandir}/man3/rdma*
+%{_mandir}/man3/umad*
+%{_mandir}/man3/*_to_ibv_rate.*
+%{_mandir}/man7/rdma_cm.*
+%if 0%{?dma_coherent}
+%{_mandir}/man3/mlx5dv*
+%{_mandir}/man3/mlx4dv*
+%{_mandir}/man7/mlx5dv*
+%{_mandir}/man7/mlx4dv*
+%endif
+
+%files -n libibverbs
+%defattr(-,root,root)
+%dir %{_sysconfdir}/libibverbs.d
+%dir %{_libdir}/libibverbs
+%{_libdir}/libibverbs/*.so
+%config(noreplace) %{_sysconfdir}/libibverbs.d/*.driver
+%doc %{_docdir}/%{name}-%{version}/libibverbs.md
+%doc %{_docdir}/%{name}-%{version}/rxe.md
+%{_bindir}/rxe_cfg
+%{_mandir}/man7/rxe*
+%{_mandir}/man8/rxe*
+
+%files -n %verbs_lname
+%defattr(-,root,root)
+%{_libdir}/libibverbs*.so.*
+
+%if 0%{?dma_coherent}
+%files -n %mlx4_lname
+%defattr(-,root,root)
+%{_libdir}/libmlx4*.so.*
+
+%files -n %mlx5_lname
+%defattr(-,root,root)
+%{_libdir}/libmlx5*.so.*
+%endif
+
+%files -n libibverbs-utils
+%defattr(-,root,root)
+%{_bindir}/ibv_*
+%{_mandir}/man1/ibv_*
+
+%files -n ibacm
+%defattr(-,root,root)
+%config(noreplace) %{_sysconfdir}/rdma/ibacm_opts.cfg
+%{_bindir}/ib_acme
+%{_sbindir}/ibacm
+%{_mandir}/man1/ibacm.*
+%{_mandir}/man1/ib_acme.*
+%{_mandir}/man7/ibacm.*
+%{_mandir}/man7/ibacm_prov.*
+%{_unitdir}/ibacm.service
+%{_unitdir}/ibacm.socket
+%dir %{_libdir}/ibacm
+%{_libdir}/ibacm/*
+%{_sbindir}/rcibacm
+%doc %{_docdir}/%{name}-%{version}/ibacm.md
+
+%files -n iwpmd
+%defattr(-,root,root)
+%dir %{_sysconfdir}/rdma
+%dir %{_sysconfdir}/rdma/modules
+%{_sbindir}/iwpmd
+%{_sbindir}/rciwpmd
+%{_unitdir}/iwpmd.service
+%config(noreplace) %{_sysconfdir}/rdma/modules/iwpmd.conf
+%config(noreplace) %{_sysconfdir}/iwpmd.conf
+%{_udevrulesdir}/90-iwpmd.rules
+%{_mandir}/man8/iwpmd.*
+%{_mandir}/man5/iwpmd.*
+
+%files -n %ibcm_lname
+%defattr(-,root,root)
+%{_libdir}/libibcm*.so.*
+%doc %{_docdir}/%{name}-%{version}/libibcm.md
+
+%files -n %umad_lname
+%defattr(-,root,root)
+%{_libdir}/libibumad*.so.*
+
+%files -n %rdmacm_lname
+%defattr(-,root,root)
+%{_libdir}/librdmacm*.so.*
+%doc %{_docdir}/%{name}-%{version}/librdmacm.md
+
+%files -n rsocket
+%defattr(-,root,root)
+%dir %{_libdir}/rsocket
+%{_libdir}/rsocket/*.so*
+%{_mandir}/man7/rsocket.*
+
+%files -n librdmacm-utils
+%defattr(-,root,root)
+%{_bindir}/cmtime
+%{_bindir}/mckey
+%{_bindir}/rcopy
+%{_bindir}/rdma_client
+%{_bindir}/rdma_server
+%{_bindir}/rdma_xclient
+%{_bindir}/rdma_xserver
+%{_bindir}/riostream
+%{_bindir}/rping
+%{_bindir}/rstream
+%{_bindir}/ucmatose
+%{_bindir}/udaddy
+%{_bindir}/udpong
+%{_mandir}/man1/cmtime.*
+%{_mandir}/man1/mckey.*
+%{_mandir}/man1/rcopy.*
+%{_mandir}/man1/rdma_client.*
+%{_mandir}/man1/rdma_server.*
+%{_mandir}/man1/rdma_xclient.*
+%{_mandir}/man1/rdma_xserver.*
+%{_mandir}/man1/riostream.*
+%{_mandir}/man1/rping.*
+%{_mandir}/man1/rstream.*
+%{_mandir}/man1/ucmatose.*
+%{_mandir}/man1/udaddy.*
+%{_mandir}/man1/udpong.*
+
+%files -n srp_daemon
+%defattr(-,root,root)
+%dir %{_libexecdir}/srp_daemon
+%dir %{_sysconfdir}/rdma
+%dir %{_sysconfdir}/rdma/modules
+%config(noreplace) %{_sysconfdir}/srp_daemon.conf
+%config(noreplace) %{_sysconfdir}/rdma/modules/srp_daemon.conf
+%{_libexecdir}/udev/rules.d/60-srp_daemon.rules
+%{_libexecdir}/srp_daemon/start_on_all_ports
+%{_unitdir}/srp_daemon.service
+%{_unitdir}/srp_daemon_port@.service
+%{_sbindir}/ibsrpdm
+%{_sbindir}/srp_daemon
+%{_sbindir}/run_srp_daemon
+%{_sbindir}/rcsrp_daemon
+%{_mandir}/man1/ibsrpdm.1*
+%{_mandir}/man1/srp_daemon.1*
+%{_mandir}/man5/srp_daemon.service.5*
+%{_mandir}/man5/srp_daemon_port@.service.5*
+%doc %{_docdir}/%{name}-%{version}/ibsrpdm.md
+
+%files -n rdma-ndd
+%defattr(-, root, root)
+%{_sbindir}/rdma-ndd
+%{_sbindir}/rcrdma-ndd
+%{_unitdir}/rdma-ndd.service
+%{_mandir}/man8/rdma-ndd.*
+%{_mandir}/man8/rdma-ndd.8*
+%{_libexecdir}/udev/rules.d/60-rdma-ndd.rules
+
+%changelog
-- 
2.14.1.252.gf15771ee3


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found] ` <abf2bc82-824b-a1d9-bc6b-a3a77045d633-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-27 21:47   ` Jason Gunthorpe
       [not found]     ` <20170827214704.GC14542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-27 21:47 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote:

> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf
> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service
> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service
> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs
> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf
> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules
> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules
> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf

> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel
> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel
> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf
> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk
> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh

Going forward suse may not want to include this boot stuff from RH,
unless historical versions of suse used it or something similar. The
new cross-distro stuff in kernel-boot basically does the same thing.

I'm hoping RH will discontinue their version in newer releases.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]     ` <20170827214704.GC14542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-28  5:59       ` Nicolas Morey-Chaisemartin
       [not found]         ` <ecddc225-0dc5-c51f-535b-c2bee252d5ed-l3A5Bk7waGM@public.gmane.org>
  2017-08-28 15:05       ` [PATCH rdma-core] suse: switch fully to the new udev mechanism Nicolas Morey-Chaisemartin
  1 sibling, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28  5:59 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit :
> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote:
>
>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf
>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service
>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service
>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs
>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf
>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules
>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules
>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel
>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel
>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf
>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk
>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh
> Going forward suse may not want to include this boot stuff from RH,
> unless historical versions of suse used it or something similar. The
> new cross-distro stuff in kernel-boot basically does the same thing.
>
> I'm hoping RH will discontinue their version in newer releases.
>
> Jason
Do you mean that all these should not be used anymore? Even the dracut rules ?
The udev rules and the few new services are now sufficient ?

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]         ` <ecddc225-0dc5-c51f-535b-c2bee252d5ed-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-28  6:07           ` Leon Romanovsky
       [not found]             ` <20170828060758.GD12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Leon Romanovsky @ 2017-08-28  6:07 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin
  Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 2485 bytes --]

On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit :
> > On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote:
> >
> >> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf
> >> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service
> >> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service
> >> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs
> >> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf
> >> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules
> >> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> >> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> >> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules
> >> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
> >> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
> >> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel
> >> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel
> >> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf
> >> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk
> >> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh
> > Going forward suse may not want to include this boot stuff from RH,
> > unless historical versions of suse used it or something similar. The
> > new cross-distro stuff in kernel-boot basically does the same thing.
> >
> > I'm hoping RH will discontinue their version in newer releases.
> >
> > Jason
> Do you mean that all these should not be used anymore?

I think so, from the spotted immediately - "fixup-mtrr" - is not needed
for sure.

> The udev rules and the few new services are now sufficient ?

This was the intention.

>
> Nicolas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]             ` <20170828060758.GD12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-08-28  8:17               ` Nicolas Morey-Chaisemartin
       [not found]                 ` <86a21008-c993-de29-2cb9-845af14c4cd5-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28  8:17 UTC (permalink / raw)
  To: Leon Romanovsky; +Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
> On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mod
 ules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in kernel
 -boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.

Nicolas


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                 ` <86a21008-c993-de29-2cb9-845af14c4cd5-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-28  9:05                   ` Leon Romanovsky
       [not found]                     ` <20170828090537.GG12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Leon Romanovsky @ 2017-08-28  9:05 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin
  Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 2694 bytes --]

On Mon, Aug 28, 2017 at 10:17:50AM +0200, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
> > On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
> 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in kernel-boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
> think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
> I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.
>

Can you please resend?
It is not readable.

Thanks

> Nicolas
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                     ` <20170828090537.GG12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-08-28  9:13                       ` Nicolas Morey-Chaisemartin
       [not found]                         ` <0754696d-42d5-5083-8ed0-435ab3f189de-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28  9:13 UTC (permalink / raw)
  To: Leon Romanovsky; +Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 28/08/2017 à 11:05, Leon Romanovsky a écrit :
> On Mon, Aug 28, 2017 at 10:17:50AM +0200, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
>>> On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.m
 odules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
>> 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in ker
 nel-boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
>> think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
>> I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.
>>
> Can you please resend?
> It is not readable.
>
> Thanks
>
Sorry. The latest Thunderbird seems to screw up things regularly now :s
The current udev system does not load the infiniband modules (ipoib, umad) for old mthca cards.

I've sent a PR that fixes this on github: https://github.com/linux-rdma/rdma-core/pull/193
I've added a second patch for qib. On my system (and in kernel tree) the module is called ib_qib so I think the udev rule as a typo there.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                         ` <0754696d-42d5-5083-8ed0-435ab3f189de-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-28  9:24                           ` Leon Romanovsky
       [not found]                             ` <20170828092406.GH12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
  2017-08-28 15:22                           ` Jason Gunthorpe
  1 sibling, 1 reply; 23+ messages in thread
From: Leon Romanovsky @ 2017-08-28  9:24 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin
  Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 3343 bytes --]

On Mon, Aug 28, 2017 at 11:13:07AM +0200, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 28/08/2017 à 11:05, Leon Romanovsky a écrit :
> > On Mon, Aug 28, 2017 at 10:17:50AM +0200, Nicolas Morey-Chaisemartin wrote:
> >>
> >> Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
> >>> On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
> >> 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in kernel-boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
> >> think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
> >> I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.
> >>
> > Can you please resend?
> > It is not readable.
> >
> > Thanks
> >
> Sorry. The latest Thunderbird seems to screw up things regularly now :s
> The current udev system does not load the infiniband modules (ipoib, umad) for old mthca cards.

Among us, Doug is the last who has such cards.

>
> I've sent a PR that fixes this on github: https://github.com/linux-rdma/rdma-core/pull/193
> I've added a second patch for qib. On my system (and in kernel tree) the module is called ib_qib so I think the udev rule as a typo there.

Thanks

>
> Nicolas
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                             ` <20170828092406.GH12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
@ 2017-08-28  9:36                               ` Nicolas Morey-Chaisemartin
  0 siblings, 0 replies; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28  9:36 UTC (permalink / raw)
  To: Leon Romanovsky; +Cc: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 28/08/2017 à 11:24, Leon Romanovsky a écrit :
> On Mon, Aug 28, 2017 at 11:13:07AM +0200, Nicolas Morey-Chaisemartin wrote:
>>
>> Le 28/08/2017 à 11:05, Leon Romanovsky a écrit :
>>> On Mon, Aug 28, 2017 at 10:17:50AM +0200, Nicolas Morey-Chaisemartin wrote:
>>>> Le 28/08/2017 à 08:07, Leon Romanovsky a écrit :
>>>>> On Mon, Aug 28, 2017 at 07:59:29AM +0200, Nicolas Morey-Chaisemartin wrote: >> >> >> Le 27/08/2017 à 23:47, Jason Gunthorpe a écrit : >>> On Thu, Aug 24, 2017 at 04:49:54PM +0200, Nicolas Morey-Chaisemartin wrote: >>> >>>> +install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf >>>> +sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service >>>> +chmod 0644 %{buildroot}%{_unitdir}/rdma.service >>>> +install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs >>>> +install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf >>>> +install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma
 .modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh >>>> +install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules >>>> +sed
>>>> 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf >>>> +sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel >>>> +install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf >>>> +install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk >>>> +install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh >>> Going forward suse may not want to include this boot stuff from RH, >>> unless historical versions of suse used it or something similar. The >>> new cross-distro stuff in k
 ernel-boot basically does the same thing. >>> >>> I'm hoping RH will discontinue their version in newer releases. >>> >>> Jason >> Do you mean that all these should not be used anymore? > > I
>>>> think so, from the spotted immediately - "fixup-mtrr" - is not needed > for sure. > >> The udev rules and the few new services are now sufficient ? > > This was the intention. > > I tried dropping those files from the package and it does not seem to be fully functionnal yet.
>>>> I'm running and a very old Mellanox card (mthca driver) and the rdma-load-modules@infiniband is not started. Thus ipoib and umad modules are missing.
>>>>
>>> Can you please resend?
>>> It is not readable.
>>>
>>> Thanks
>>>
>> Sorry. The latest Thunderbird seems to screw up things regularly now :s
>> The current udev system does not load the infiniband modules (ipoib, umad) for old mthca cards.
> Among us, Doug is the last who has such cards.
We also have a couple of them at SUSE lab for testing. Even if this HW is old and unsupported, the fix is simple enough to be worth applying IMHO :)

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]     ` <20170827214704.GC14542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  2017-08-28  5:59       ` Nicolas Morey-Chaisemartin
@ 2017-08-28 15:05       ` Nicolas Morey-Chaisemartin
       [not found]         ` <71835edf-cb2a-d4f8-627e-0f60ee772fb7-l3A5Bk7waGM@public.gmane.org>
  1 sibling, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28 15:05 UTC (permalink / raw)
  To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
  Cc: jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/

Do not use redhat services and scripts and use the new udev system

Signed-off-by: Nicolas Morey-Chaisemartin <NMoreyChaisemartin-IBi9RG/b67k@public.gmane.org>
---
Also sent as a PR on github: https://github.com/linux-rdma/rdma-core/pull/195

 suse/rdma-core.spec | 42 ------------------------------------------
 1 file changed, 42 deletions(-)

diff --git a/suse/rdma-core.spec b/suse/rdma-core.spec
index 76ca7286..64d43b23 100644
--- a/suse/rdma-core.spec
+++ b/suse/rdma-core.spec
@@ -356,24 +356,6 @@ mkdir -p %{buildroot}%{dracutlibdir}/modules.d/05rdma
 mkdir -p %{buildroot}%{sysmodprobedir}
 mkdir -p %{buildroot}%{_unitdir}
 
-install -D -m0644 redhat/rdma.conf %{buildroot}/%{_sysconfdir}/rdma/rdma.conf
-sed 's%/usr/libexec%/usr/lib%' redhat/rdma.service > %{buildroot}%{_unitdir}/rdma.service
-chmod 0644 %{buildroot}%{_unitdir}/rdma.service
-install -D -m0644 redhat/rdma.sriov-vfs %{buildroot}/%{_sysconfdir}/rdma/sriov-vfs
-install -D -m0644 redhat/rdma.mlx4.conf %{buildroot}/%{_sysconfdir}/rdma/mlx4.conf
-install -D -m0644 redhat/rdma.udev-ipoib-naming.rules %{buildroot}%{_udevrulesdir}/70-persistent-ipoib.rules
-sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
-chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
-install -D -m0644 redhat/rdma.udev-rules %{buildroot}%{_udevrulesdir}/98-rdma.rules
-sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.mlx4.sys.modprobe > %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
-chmod 0644 %{buildroot}%{sysmodprobedir}/50-libmlx4.conf
-
-sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.kernel-init > %{buildroot}%{_libexecdir}/rdma-init-kernel
-chmod 0755 %{buildroot}%{_libexecdir}/rdma-init-kernel
-install -D -m0755 redhat/rdma.sriov-init %{buildroot}%{_libexecdir}/rdma-set-sriov-vf
-install -D -m0644 redhat/rdma.fixup-mtrr.awk %{buildroot}%{_libexecdir}/rdma-fixup-mtrr.awk
-install -D -m0755 redhat/rdma.mlx4-setup.sh %{buildroot}%{_libexecdir}/mlx4-setup.sh
-
 mv %{buildroot}%{_sysconfdir}/modprobe.d/truescale.conf %{buildroot}%{_sysconfdir}/modprobe.d/50-truescale.conf
 %if 0%{?dma_coherent}
 mv %{buildroot}%{_sysconfdir}/modprobe.d/mlx4.conf %{buildroot}%{_sysconfdir}/modprobe.d/50-mlx4.conf
@@ -410,18 +392,6 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %post -n %rdmacm_lname -p /sbin/ldconfig
 %postun -n %rdmacm_lname -p /sbin/ldconfig
 
-%pre
-%service_add_pre rdma.service
-
-%post
-%service_add_post rdma.service
-
-%preun
-%service_del_preun -n rdma.service
-
-%postun
-%service_del_postun -n rdma.service
-
 #
 # ibacm
 #
@@ -491,36 +461,24 @@ rm -rf %{buildroot}/%{_sbindir}/srp_daemon.sh
 %dir %{_libexecdir}/udev/rules.d
 %dir %{_sysconfdir}/modprobe.d
 %doc %{_docdir}/%{name}-%{version}/README.md
-%config(noreplace) %{_sysconfdir}/rdma/mlx4.conf
 %config(noreplace) %{_sysconfdir}/rdma/modules/infiniband.conf
 %config(noreplace) %{_sysconfdir}/rdma/modules/iwarp.conf
 %config(noreplace) %{_sysconfdir}/rdma/modules/opa.conf
 %config(noreplace) %{_sysconfdir}/rdma/modules/rdma.conf
 %config(noreplace) %{_sysconfdir}/rdma/modules/roce.conf
-%config(noreplace) %{_sysconfdir}/rdma/rdma.conf
-%config(noreplace) %{_sysconfdir}/rdma/sriov-vfs
 %if 0%{?dma_coherent}
 %config(noreplace) %{_sysconfdir}/modprobe.d/50-mlx4.conf
 %endif
 %config(noreplace) %{_sysconfdir}/modprobe.d/50-truescale.conf
 %{_unitdir}/rdma-hw.target
 %{_unitdir}/rdma-load-modules@.service
-%{_unitdir}/rdma.service
 %dir %{dracutlibdir}
 %dir %{dracutlibdir}/modules.d
 %dir %{dracutlibdir}/modules.d/05rdma
-%{dracutlibdir}/modules.d/05rdma/module-setup.sh
-%{_udevrulesdir}/70-persistent-ipoib.rules
 %{_udevrulesdir}/75-rdma-description.rules
 %{_udevrulesdir}/90-rdma-hw-modules.rules
 %{_udevrulesdir}/90-rdma-ulp-modules.rules
 %{_udevrulesdir}/90-rdma-umad.rules
-%{_udevrulesdir}/98-rdma.rules
-%config %{sysmodprobedir}/50-libmlx4.conf
-%{_libexecdir}/rdma-init-kernel
-%{_libexecdir}/rdma-set-sriov-vf
-%{_libexecdir}/rdma-fixup-mtrr.awk
-%{_libexecdir}/mlx4-setup.sh
 %{_libexecdir}/truescale-serdes.cmds
 %license COPYING.*
 %{_sbindir}/rcrdma
-- 
2.14.1.252.gf15771ee3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]         ` <71835edf-cb2a-d4f8-627e-0f60ee772fb7-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-28 15:16           ` Jason Gunthorpe
       [not found]             ` <20170828151609.GA7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-28 15:16 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Mon, Aug 28, 2017 at 05:05:33PM +0200, Nicolas Morey-Chaisemartin wrote:

> -sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> -chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh

You probably still need something dracut related.

At a minimum you have to address the problem we saw in Debian: mlx5
and mlx4 need to have their rdma modules include in the initrd if
their core modules are included. (eg anything request_module'd from
the initrd must be present)

You may need to do more if you intend to support boot over ipoib, srp,
nfs-rdma, etc - I think the RH scripts aim to support.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                         ` <0754696d-42d5-5083-8ed0-435ab3f189de-l3A5Bk7waGM@public.gmane.org>
  2017-08-28  9:24                           ` Leon Romanovsky
@ 2017-08-28 15:22                           ` Jason Gunthorpe
       [not found]                             ` <20170828152254.GB7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  1 sibling, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-28 15:22 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin
  Cc: Leon Romanovsky, linux-rdma-u79uwXL29TY76Z2rM5mHXA, Adit Ranadive

On Mon, Aug 28, 2017 at 11:13:07AM +0200, Nicolas Morey-Chaisemartin wrote:

> Sorry. The latest Thunderbird seems to screw up things regularly now
> :s The current udev system does not load the infiniband modules
> (ipoib, umad) for old mthca cards.
> 
> I've sent a PR that fixes this on github:
> https://github.com/linux-rdma/rdma-core/pull/193 I've added a second
> patch for qib. On my system (and in kernel tree) the module is
> called ib_qib so I think the udev rule as a typo there.

Yes, this is right..

Adit: vmw_rdma is also missing, can you test it? This is probably
the fix:

diff --git a/kernel-boot/rdma-description.rules b/kernel-boot/rdma-description.rules
index f37e6a86f21efc..bb33dce40bd621 100644
--- a/kernel-boot/rdma-description.rules
+++ b/kernel-boot/rdma-description.rules
@@ -34,6 +34,7 @@ DRIVERS=="hns", ENV{ID_RDMA_ROCE}="1"
 DRIVERS=="mlx4_core", ENV{ID_RDMA_ROCE}="1"
 DRIVERS=="mlx5_core", ENV{ID_RDMA_ROCE}="1"
 DRIVERS=="qede", ENV{ID_RDMA_ROCE}="1"
+DRIVERS=="vmw_pvrdma", ENV{ID_RDMA_ROCE}="1"
 DEVPATH=="*/infiniband/rxe*", ATTR{parent}=="*", ENV{ID_RDMA_ROCE}="1"
 
 # Setup the usual ID information so that systemd will display a sane name for
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]             ` <20170828151609.GA7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-28 15:23               ` Nicolas Morey-Chaisemartin
       [not found]                 ` <b4b35cf1-ed07-dbee-37cc-15c00480ad04-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-28 15:23 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 28/08/2017 à 17:16, Jason Gunthorpe a écrit :
> On Mon, Aug 28, 2017 at 05:05:33PM +0200, Nicolas Morey-Chaisemartin wrote:
>
>> -sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>> -chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> You probably still need something dracut related.
>
> At a minimum you have to address the problem we saw in Debian: mlx5
> and mlx4 need to have their rdma modules include in the initrd if
> their core modules are included. (eg anything request_module'd from
> the initrd must be present)
>
> You may need to do more if you intend to support boot over ipoib, srp,
> nfs-rdma, etc - I think the RH scripts aim to support.
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
These were in your mail so I assumed they could be dropped :)
I'll keep the dracut stuff then.

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                 ` <b4b35cf1-ed07-dbee-37cc-15c00480ad04-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-28 15:31                   ` Jason Gunthorpe
       [not found]                     ` <20170828153146.GC7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-28 15:31 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Mon, Aug 28, 2017 at 05:23:25PM +0200, Nicolas Morey-Chaisemartin wrote:
> Le 28/08/2017 ?? 17:16, Jason Gunthorpe a ??crit??:
> > On Mon, Aug 28, 2017 at 05:05:33PM +0200, Nicolas Morey-Chaisemartin wrote:
> >
> >> -sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> >> -chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
> > You probably still need something dracut related.
> >
> > At a minimum you have to address the problem we saw in Debian: mlx5
> > and mlx4 need to have their rdma modules include in the initrd if
> > their core modules are included. (eg anything request_module'd from
> > the initrd must be present)
> >
> > You may need to do more if you intend to support boot over ipoib, srp,
> > nfs-rdma, etc - I think the RH scripts aim to support.

> These were in your mail so I assumed they could be dropped :)
> I'll keep the dracut stuff then.

I was not careful about what I quoted.. Just stuff in that overall area.

The existing dracut script seems to assume other things, so you may
need a new dracut script. If it is totally general then it can live in
kernel-boot..

You should also consider if you need the udev triggers, I don't know
what suse policy is. Look in debian/rdma-core.postinst and others.

Adding them allows the udev rules to trigger on package install and
makes everything start working without a reboot.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                             ` <20170828152254.GB7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-28 17:23                               ` Adit Ranadive
       [not found]                                 ` <ea729fa9-6f6e-9834-ff77-377b1e843f79-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Adit Ranadive @ 2017-08-28 17:23 UTC (permalink / raw)
  To: Jason Gunthorpe, Nicolas Morey-Chaisemartin
  Cc: Leon Romanovsky, linux-rdma-u79uwXL29TY76Z2rM5mHXA

On 8/28/17 8:22 AM, Jason Gunthorpe wrote:
> Adit: vmw_rdma is also missing, can you test it? This is probably
> the fix:
> 
> diff --git a/kernel-boot/rdma-description.rules b/kernel-boot/rdma-description.rules
> index f37e6a86f21efc..bb33dce40bd621 100644
> --- a/kernel-boot/rdma-description.rules
> +++ b/kernel-boot/rdma-description.rules
> @@ -34,6 +34,7 @@ DRIVERS=="hns", ENV{ID_RDMA_ROCE}="1"
>  DRIVERS=="mlx4_core", ENV{ID_RDMA_ROCE}="1"
>  DRIVERS=="mlx5_core", ENV{ID_RDMA_ROCE}="1"
>  DRIVERS=="qede", ENV{ID_RDMA_ROCE}="1"
> +DRIVERS=="vmw_pvrdma", ENV{ID_RDMA_ROCE}="1"
>  DEVPATH=="*/infiniband/rxe*", ATTR{parent}=="*", ENV{ID_RDMA_ROCE}="1"

Thanks. Do I need to generate rpms to test this to install the udev rules?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                                 ` <ea729fa9-6f6e-9834-ff77-377b1e843f79-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
@ 2017-08-28 17:29                                   ` Jason Gunthorpe
       [not found]                                     ` <20170828172954.GA21341-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-28 17:29 UTC (permalink / raw)
  To: Adit Ranadive
  Cc: Nicolas Morey-Chaisemartin, Leon Romanovsky,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Mon, Aug 28, 2017 at 10:23:56AM -0700, Adit Ranadive wrote:
> On 8/28/17 8:22 AM, Jason Gunthorpe wrote:
> > Adit: vmw_rdma is also missing, can you test it? This is probably
> > the fix:
> > 
> > diff --git a/kernel-boot/rdma-description.rules b/kernel-boot/rdma-description.rules
> > index f37e6a86f21efc..bb33dce40bd621 100644
> > +++ b/kernel-boot/rdma-description.rules
> > @@ -34,6 +34,7 @@ DRIVERS=="hns", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="mlx4_core", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="mlx5_core", ENV{ID_RDMA_ROCE}="1"
> >  DRIVERS=="qede", ENV{ID_RDMA_ROCE}="1"
> > +DRIVERS=="vmw_pvrdma", ENV{ID_RDMA_ROCE}="1"
> >  DEVPATH=="*/infiniband/rxe*", ATTR{parent}=="*", ENV{ID_RDMA_ROCE}="1"
> 
> Thanks. Do I need to generate rpms to test this to install the udev rules?

For best results, yes.. You have to disable the rdma.service that still comes in
the rpms.

After booting run

udevadm info /sys/class/infiniband/XX

where XX is the rdma name of a vmw_pvrdma device, and confirm the
ID_RDMA_ROCE is setup. Check the rest of the modules loaded and so forth.

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                     ` <20170828153146.GC7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-29  7:59                       ` Nicolas Morey-Chaisemartin
       [not found]                         ` <84031eb6-9ae5-71c6-8ba3-252204c3688d-l3A5Bk7waGM@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-29  7:59 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 28/08/2017 à 17:31, Jason Gunthorpe a écrit :
> On Mon, Aug 28, 2017 at 05:23:25PM +0200, Nicolas Morey-Chaisemartin wrote:
>> Le 28/08/2017 ?? 17:16, Jason Gunthorpe a ??crit??:
>>> On Mon, Aug 28, 2017 at 05:05:33PM +0200, Nicolas Morey-Chaisemartin wrote:
>>>
>>>> -sed 's%/usr/libexec%/usr/lib%g' redhat/rdma.modules-setup.sh > %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>>>> -chmod 0755 %{buildroot}%{dracutlibdir}/modules.d/05rdma/module-setup.sh
>>> You probably still need something dracut related.
>>>
>>> At a minimum you have to address the problem we saw in Debian: mlx5
>>> and mlx4 need to have their rdma modules include in the initrd if
>>> their core modules are included. (eg anything request_module'd from
>>> the initrd must be present)
>>>
>>> You may need to do more if you intend to support boot over ipoib, srp,
>>> nfs-rdma, etc - I think the RH scripts aim to support.
>> These were in your mail so I assumed they could be dropped :)
>> I'll keep the dracut stuff then.
> I was not careful about what I quoted.. Just stuff in that overall area.
>
> The existing dracut script seems to assume other things, so you may
> need a new dracut script. If it is totally general then it can live in
> kernel-boot..
>
> You should also consider if you need the udev triggers, I don't know
> what suse policy is. Look in debian/rdma-core.postinst and others.
>
> Adding them allows the udev rules to trigger on package install and
> makes everything start working without a reboot.


I looked around to all the scripts and I'm going some time to go through all these and decide which we need and which we don't.
Some of those were all upstreamed at once and I'm not sure what the bug they were fixing and if it is still needed.
I contacted Doug on the side. It would make sense to work with Red Hat to migrate to the udev system (vs rdma.service) and "cleanup" those scripts so they can be shared more easily.
This also means this won't be done before v15 is out. We should keep SUSE spec as is (it works) and work on the cleanup for v16.


Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                         ` <84031eb6-9ae5-71c6-8ba3-252204c3688d-l3A5Bk7waGM@public.gmane.org>
@ 2017-08-29 15:03                           ` Jason Gunthorpe
       [not found]                             ` <20170829150329.GA26051-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-29 15:03 UTC (permalink / raw)
  To: Nicolas Morey-Chaisemartin; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Tue, Aug 29, 2017 at 09:59:34AM +0200, Nicolas Morey-Chaisemartin wrote:

> I looked around to all the scripts and I'm going some time to go through all these and decide which we need and which we don't.
> Some of those were all upstreamed at once and I'm not sure what the
> bug they were fixing and if it is still needed.

Basically none of it is necessary today from a 'bug fix'
perspective, the bug fix stuff is all ancient history.

Here is my perspective on the RH directory:

rdma.conf
 - Obsoleted by /etc/rdma/modules/rdma/modules
   Except for 'tech preview' which is a RH concept.
rdma.fixup-mtrr.awk
 - Obsolete, supports ancient hardware, done in kernel now
rdma.ifdown-ib
rdma.ifup-ib
 - Looks like this supports RH's old 'network-scripts' system?
   Is it even compatible with suse?
rdma.kernel-init
rdma.service
rdma.udev-rules
 - This is the implementation of rdma.conf, it is obsoleted.
   The bug fix stuff is all for ancient hardware or done in
   the kernel now.
rdma.mlx4-setup.sh
rdma.mlx4.conf
rdma.mlx4.sys.modprobe
 - Mellanox says they now prefer it if the device's EEPROM is
   configured, instead of this approach. So this is old
rdma.modules-setup.sh
 - Dracut support to include more stuff in the initrd.
rdma.sriov-init
rdma.sriov-vfs
 - This creates SRIOV instances at boot. Maybe it should move
   to kernel-boot, but also unclear why we need it? doesn't
   libvirt do this nowadays?
rdma.udev-ipoib-naming.rules
 - This is a user example for udev rules..
   Could go into kernel-boot

If suse never shipped this stuff before then there is no reason
to rush to add it now..

> I contacted Doug on the side. It would make sense to work with Red
> Hat to migrate to the udev system (vs rdma.service) and "cleanup"
> those scripts so they can be shared more easily.  This also means
> this won't be done before v15 is out. We should keep SUSE spec as is
> (it works) and work on the cleanup for v16.

rdma.service is replaced by the stuff in kernel boot, and by my
eye the remainder is highly RH specific or I'm not certain what it is
for.. suse will probably need some distro specific things as well.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                             ` <20170829150329.GA26051-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-29 15:20                               ` Doug Ledford
       [not found]                                 ` <1504020051.52034.51.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  2017-08-29 15:38                               ` Nicolas Morey-Chaisemartin
  1 sibling, 1 reply; 23+ messages in thread
From: Doug Ledford @ 2017-08-29 15:20 UTC (permalink / raw)
  To: Jason Gunthorpe, Nicolas Morey-Chaisemartin
  Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Tue, 2017-08-29 at 09:03 -0600, Jason Gunthorpe wrote:
> On Tue, Aug 29, 2017 at 09:59:34AM +0200, Nicolas Morey-Chaisemartin
> wrote:
> 
> > I looked around to all the scripts and I'm going some time to go
> > through all these and decide which we need and which we don't.
> > Some of those were all upstreamed at once and I'm not sure what the
> > bug they were fixing and if it is still needed.
> 
> Basically none of it is necessary today from a 'bug fix'
> perspective, the bug fix stuff is all ancient history.
> 
> Here is my perspective on the RH directory:
> 
> rdma.conf
>  - Obsoleted by /etc/rdma/modules/rdma/modules
>    Except for 'tech preview' which is a RH concept.

Sounds right.

> rdma.fixup-mtrr.awk
>  - Obsolete, supports ancient hardware, done in kernel now

Yeah, this is droppable.  It was needed back in the SDR days for qib
hardware.

> rdma.ifdown-ib
> rdma.ifup-ib
>  - Looks like this supports RH's old 'network-scripts' system?
>    Is it even compatible with suse?

Yes, and probably not.  We have to keep it around because users have
the option of using the network scripts instead of NetworkManager.

> rdma.kernel-init
> rdma.service
> rdma.udev-rules
>  - This is the implementation of rdma.conf, it is obsoleted.
>    The bug fix stuff is all for ancient hardware or done in
>    the kernel now.

Correct.  The module loading should be obsoleted by the udev
autoloading work you just did and the PCI fixups in the script are even
more ancient and droppable than the MTRR fixups ;-)

> rdma.mlx4-setup.sh
> rdma.mlx4.conf
> rdma.mlx4.sys.modprobe
>  - Mellanox says they now prefer it if the device's EEPROM is
>    configured, instead of this approach. So this is old

Right, but it still needs to stick around for now.  Even though the
EEPROM approach is preferred, not all mlx4 level devices support it,
and given that mlx4 is still very much in use, we need to keep it.

> rdma.modules-setup.sh
>  - Dracut support to include more stuff in the initrd.

Right, which Red Hat (at least) must keep.

> rdma.sriov-init
> rdma.sriov-vfs
>  - This creates SRIOV instances at boot.

Correct.

>  Maybe it should move
>    to kernel-boot, but also unclear why we need it? doesn't
>    libvirt do this nowadays?

It needs to die.  For a very long time libvirt has not been smart
enough to deal with the dual ports on mlx4 hardware.  There has been
work upstream in libvirt to make this work.  The scripts here are
useless for any guests that are open to migration as they preconfigure
the devices and then you attach the device to the guest more or less
unmanaged.  Libvirt/qemu can never migrate the host because it doesn't
know how to set up the card on the new host the same way.  It's my hope
that the rdma tool will be expanded to support the different SRIOV
configuration methods (mlx4 and mlx5 are totally different)
transparently.  If/when that happens, it will be easy for libvirt to
standardize on that method and move this to "fully supported" status. 
Right now, this support is just to allow people to statically configure
SRIOV for use, but I don't consider something that can't migrate guests
production ready IMO.

> rdma.udev-ipoib-naming.rules
>  - This is a user example for udev rules..
>    Could go into kernel-boot

Right.  This is a totally generic udev consistent device naming
support.

-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                             ` <20170829150329.GA26051-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
  2017-08-29 15:20                               ` Doug Ledford
@ 2017-08-29 15:38                               ` Nicolas Morey-Chaisemartin
  1 sibling, 0 replies; 23+ messages in thread
From: Nicolas Morey-Chaisemartin @ 2017-08-29 15:38 UTC (permalink / raw)
  To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA



Le 29/08/2017 à 17:03, Jason Gunthorpe a écrit :
> On Tue, Aug 29, 2017 at 09:59:34AM +0200, Nicolas Morey-Chaisemartin wrote:
>
>> I looked around to all the scripts and I'm going some time to go through all these and decide which we need and which we don't.
>> Some of those were all upstreamed at once and I'm not sure what the
>> bug they were fixing and if it is still needed.
> Basically none of it is necessary today from a 'bug fix'
> perspective, the bug fix stuff is all ancient history.
>
> Here is my perspective on the RH directory:
>
> rdma.conf
>  - Obsoleted by /etc/rdma/modules/rdma/modules
>    Except for 'tech preview' which is a RH concept.
> rdma.fixup-mtrr.awk
>  - Obsolete, supports ancient hardware, done in kernel now
> rdma.ifdown-ib
> rdma.ifup-ib
>  - Looks like this supports RH's old 'network-scripts' system?
>    Is it even compatible with suse?
> rdma.kernel-init
> rdma.service
> rdma.udev-rules
>  - This is the implementation of rdma.conf, it is obsoleted.
>    The bug fix stuff is all for ancient hardware or done in
>    the kernel now.
> rdma.mlx4-setup.sh
> rdma.mlx4.conf
> rdma.mlx4.sys.modprobe
>  - Mellanox says they now prefer it if the device's EEPROM is
>    configured, instead of this approach. So this is old
> rdma.modules-setup.sh
>  - Dracut support to include more stuff in the initrd.
> rdma.sriov-init
> rdma.sriov-vfs
>  - This creates SRIOV instances at boot. Maybe it should move
>    to kernel-boot, but also unclear why we need it? doesn't
>    libvirt do this nowadays?
> rdma.udev-ipoib-naming.rules
>  - This is a user example for udev rules..
>    Could go into kernel-boot
>
> If suse never shipped this stuff before then there is no reason
> to rush to add it now..

We did for SLE12SP3 because it was a rushed job and we pretty much copied the redhat spec and fixed to match our packaging rules.
It appears we should be able to drop all these. We just need a new dracut file with the instmods but without all the redhat files.
It makes sense to keep the ipoib udev example too.
Not sure about the SRIOV files.



>> I contacted Doug on the side. It would make sense to work with Red
>> Hat to migrate to the udev system (vs rdma.service) and "cleanup"
>> those scripts so they can be shared more easily.  This also means
>> this won't be done before v15 is out. We should keep SUSE spec as is
>> (it works) and work on the cleanup for v16.
> rdma.service is replaced by the stuff in kernel boot, and by my
> eye the remainder is highly RH specific or I'm not certain what it is
> for.. suse will probably need some distro specific things as well.

It may come to that but we have nothing pending yet

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core] suse: switch fully to the new udev mechanism
       [not found]                                 ` <1504020051.52034.51.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2017-08-29 17:12                                   ` Jason Gunthorpe
  0 siblings, 0 replies; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-29 17:12 UTC (permalink / raw)
  To: Doug Ledford
  Cc: Nicolas Morey-Chaisemartin, linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Tue, Aug 29, 2017 at 11:20:51AM -0400, Doug Ledford wrote:

> > rdma.fixup-mtrr.awk
> >  - Obsolete, supports ancient hardware, done in kernel now
> 
> Yeah, this is droppable.  It was needed back in the SDR days for qib
> hardware.

PR #199 deletes this file

> > rdma.mlx4-setup.sh
> > rdma.mlx4.conf
> > rdma.mlx4.sys.modprobe
> >  - Mellanox says they now prefer it if the device's EEPROM is
> >    configured, instead of this approach. So this is old
> 
> Right, but it still needs to stick around for now.  Even though the
> EEPROM approach is preferred, not all mlx4 level devices support it,
> and given that mlx4 is still very much in use, we need to keep it.

The modprobe approach is not compatible with hotplug.  Instead, we
really want this to run from a udev rule, but the mlx4 driver does not
create a kobject from mlx_core, so there is nothing to trigger the
rule on :|

I guess a kernel patch will be needed here..

> >  Maybe it should move
> >    to kernel-boot, but also unclear why we need it? doesn't
> >    libvirt do this nowadays?
> 
> It needs to die.  For a very long time libvirt has not been smart
> enough to deal with the dual ports on mlx4 hardware.  There has been
> work upstream in libvirt to make this work.  The scripts here are
> useless for any guests that are open to migration as they preconfigure
> the devices and then you attach the device to the guest more or less
> unmanaged.  Libvirt/qemu can never migrate the host because it doesn't
> know how to set up the card on the new host the same way.  It's my hope
> that the rdma tool will be expanded to support the different SRIOV
> configuration methods (mlx4 and mlx5 are totally different)
> transparently.  If/when that happens, it will be easy for libvirt to
> standardize on that method and move this to "fully supported" status. 
> Right now, this support is just to allow people to statically configure
> SRIOV for use, but I don't consider something that can't migrate guests
> production ready IMO.

Okay, lets leave that as redhat/, but I thought Mellanox sorted this
all out with the ipoib netlink patches related to sriov? Sigh.

> > rdma.udev-ipoib-naming.rules
> >  - This is a user example for udev rules..
> >    Could go into kernel-boot
> 
> Right.  This is a totally generic udev consistent device naming
> support.

Done in PR #199

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                                     ` <20170828172954.GA21341-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
@ 2017-08-30  0:31                                       ` Adit Ranadive
       [not found]                                         ` <32d85325-7aa0-edfe-eaca-213102ea14bd-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
  0 siblings, 1 reply; 23+ messages in thread
From: Adit Ranadive @ 2017-08-30  0:31 UTC (permalink / raw)
  To: Jason Gunthorpe
  Cc: Nicolas Morey-Chaisemartin, Leon Romanovsky,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA

On 8/28/17 10:29 AM, Jason Gunthorpe wrote:
> On Mon, Aug 28, 2017 at 10:23:56AM -0700, Adit Ranadive wrote:
>> On 8/28/17 8:22 AM, Jason Gunthorpe wrote:
>>> Adit: vmw_rdma is also missing, can you test it? This is probably
>>> the fix:
>>>
>>> diff --git a/kernel-boot/rdma-description.rules b/kernel-boot/rdma-description.rules
>>> index f37e6a86f21efc..bb33dce40bd621 100644
>>> +++ b/kernel-boot/rdma-description.rules
>>> @@ -34,6 +34,7 @@ DRIVERS=="hns", ENV{ID_RDMA_ROCE}="1"
>>>  DRIVERS=="mlx4_core", ENV{ID_RDMA_ROCE}="1"
>>>  DRIVERS=="mlx5_core", ENV{ID_RDMA_ROCE}="1"
>>>  DRIVERS=="qede", ENV{ID_RDMA_ROCE}="1"
>>> +DRIVERS=="vmw_pvrdma", ENV{ID_RDMA_ROCE}="1"
>>>  DEVPATH=="*/infiniband/rxe*", ATTR{parent}=="*", ENV{ID_RDMA_ROCE}="1"
>>
>> Thanks. Do I need to generate rpms to test this to install the udev rules?
> 
> For best results, yes.. You have to disable the rdma.service that still comes in
> the rpms.
> 
> After booting run
> 
> udevadm info /sys/class/infiniband/XX
> 
> where XX is the rdma name of a vmw_pvrdma device, and confirm the
> ID_RDMA_ROCE is setup. Check the rest of the modules loaded and so forth.

Hmm, so I added that line to rdma-description.rules, generated and installed
the rpms. udevadm shows me this:

$> udevadm info /sys/class/infiniband/vmw_pvrdma0 | grep -i id_rdma
E: ID_RDMA_ROCE=1

I'm guessing thats the output you're looking for?

Sorry I'm not an expert on the udev stuff but what does the RDMA_ROCE environment
correspond to here - just the various modules to be loaded and/or something else?

Thanks,
Adit



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [PATCH rdma-core 1/2] suse: Add spec file for SUSE
       [not found]                                         ` <32d85325-7aa0-edfe-eaca-213102ea14bd-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
@ 2017-08-30  1:24                                           ` Jason Gunthorpe
  0 siblings, 0 replies; 23+ messages in thread
From: Jason Gunthorpe @ 2017-08-30  1:24 UTC (permalink / raw)
  To: Adit Ranadive
  Cc: Nicolas Morey-Chaisemartin, Leon Romanovsky,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA

On Tue, Aug 29, 2017 at 05:31:47PM -0700, Adit Ranadive wrote:
> > For best results, yes.. You have to disable the rdma.service that still comes in
> > the rpms.
> > 
> > After booting run
> > 
> > udevadm info /sys/class/infiniband/XX
> > 
> > where XX is the rdma name of a vmw_pvrdma device, and confirm the
> > ID_RDMA_ROCE is setup. Check the rest of the modules loaded and so forth.
> 
> Hmm, so I added that line to rdma-description.rules, generated and installed
> the rpms. udevadm shows me this:
> 
> $> udevadm info /sys/class/infiniband/vmw_pvrdma0 | grep -i id_rdma
> E: ID_RDMA_ROCE=1
> 
> I'm guessing thats the output you're looking for?

Yes, that is good

> Sorry I'm not an expert on the udev stuff but what does the RDMA_ROCE environment
> correspond to here - just the various modules to be loaded and/or something else?

These variables inside udev are used by other rules inside udev. If
anything sets ID_RDMA_ROCE it triggers other udev rules to tell
systemd to activate all the roce related rules.

I'll send a patch for adding the vmw_pvrdma

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2017-08-30  1:24 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-24 14:49 [PATCH rdma-core 1/2] suse: Add spec file for SUSE Nicolas Morey-Chaisemartin
     [not found] ` <abf2bc82-824b-a1d9-bc6b-a3a77045d633-l3A5Bk7waGM@public.gmane.org>
2017-08-27 21:47   ` Jason Gunthorpe
     [not found]     ` <20170827214704.GC14542-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-28  5:59       ` Nicolas Morey-Chaisemartin
     [not found]         ` <ecddc225-0dc5-c51f-535b-c2bee252d5ed-l3A5Bk7waGM@public.gmane.org>
2017-08-28  6:07           ` Leon Romanovsky
     [not found]             ` <20170828060758.GD12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28  8:17               ` Nicolas Morey-Chaisemartin
     [not found]                 ` <86a21008-c993-de29-2cb9-845af14c4cd5-l3A5Bk7waGM@public.gmane.org>
2017-08-28  9:05                   ` Leon Romanovsky
     [not found]                     ` <20170828090537.GG12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28  9:13                       ` Nicolas Morey-Chaisemartin
     [not found]                         ` <0754696d-42d5-5083-8ed0-435ab3f189de-l3A5Bk7waGM@public.gmane.org>
2017-08-28  9:24                           ` Leon Romanovsky
     [not found]                             ` <20170828092406.GH12880-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-08-28  9:36                               ` Nicolas Morey-Chaisemartin
2017-08-28 15:22                           ` Jason Gunthorpe
     [not found]                             ` <20170828152254.GB7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-28 17:23                               ` Adit Ranadive
     [not found]                                 ` <ea729fa9-6f6e-9834-ff77-377b1e843f79-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-08-28 17:29                                   ` Jason Gunthorpe
     [not found]                                     ` <20170828172954.GA21341-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-30  0:31                                       ` Adit Ranadive
     [not found]                                         ` <32d85325-7aa0-edfe-eaca-213102ea14bd-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2017-08-30  1:24                                           ` Jason Gunthorpe
2017-08-28 15:05       ` [PATCH rdma-core] suse: switch fully to the new udev mechanism Nicolas Morey-Chaisemartin
     [not found]         ` <71835edf-cb2a-d4f8-627e-0f60ee772fb7-l3A5Bk7waGM@public.gmane.org>
2017-08-28 15:16           ` Jason Gunthorpe
     [not found]             ` <20170828151609.GA7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-28 15:23               ` Nicolas Morey-Chaisemartin
     [not found]                 ` <b4b35cf1-ed07-dbee-37cc-15c00480ad04-l3A5Bk7waGM@public.gmane.org>
2017-08-28 15:31                   ` Jason Gunthorpe
     [not found]                     ` <20170828153146.GC7867-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-29  7:59                       ` Nicolas Morey-Chaisemartin
     [not found]                         ` <84031eb6-9ae5-71c6-8ba3-252204c3688d-l3A5Bk7waGM@public.gmane.org>
2017-08-29 15:03                           ` Jason Gunthorpe
     [not found]                             ` <20170829150329.GA26051-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-08-29 15:20                               ` Doug Ledford
     [not found]                                 ` <1504020051.52034.51.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2017-08-29 17:12                                   ` Jason Gunthorpe
2017-08-29 15:38                               ` Nicolas Morey-Chaisemartin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.