From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752865AbdCHMRn (ORCPT ); Wed, 8 Mar 2017 07:17:43 -0500 Received: from szxga03-in.huawei.com ([45.249.212.189]:3945 "EHLO dggrg03-dlp.huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752415AbdCHMRl (ORCPT ); Wed, 8 Mar 2017 07:17:41 -0500 Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page To: Jaegeuk Kim , , , References: <20170306215102.3807-1-jaegeuk@kernel.org> From: Chao Yu Message-ID: <8fa2118d-1da0-29f6-a755-fd661333d05d@huawei.com> Date: Wed, 8 Mar 2017 20:17:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20170306215102.3807-1-jaegeuk@kernel.org> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.58BFF640.0024,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 8f94d429a1c03f381f0e940ba9462854 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/3/7 5:51, Jaegeuk Kim wrote: > If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page > during f2fs_evict_inode(), which doesn't need to do. Hmm...should not allow other using of inode->i_ino in following codes of f2fs_evict_inode, right? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 24bb8213d974..ef8610bf950f 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -411,7 +411,10 @@ void f2fs_evict_inode(struct inode *inode) > stat_dec_inline_dir(inode); > stat_dec_inline_inode(inode); > > - invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, inode->i_ino); > + /* ino == 0, if f2fs_new_inode() was failed t*/ > + if (inode->i_ino) > + invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, > + inode->i_ino); > if (xnid) > invalidate_mapping_pages(NODE_MAPPING(sbi), xnid, xnid); > if (inode->i_nlink) { > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Yu Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to invalidate wrong node page Date: Wed, 8 Mar 2017 20:17:00 +0800 Message-ID: <8fa2118d-1da0-29f6-a755-fd661333d05d@huawei.com> References: <20170306215102.3807-1-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170306215102.3807-1-jaegeuk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net List-Id: linux-f2fs-devel.lists.sourceforge.net On 2017/3/7 5:51, Jaegeuk Kim wrote: > If f2fs_new_inode() is failed, the bad inode will invalidate 0'th node page > during f2fs_evict_inode(), which doesn't need to do. Hmm...should not allow other using of inode->i_ino in following codes of f2fs_evict_inode, right? Thanks, > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index 24bb8213d974..ef8610bf950f 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -411,7 +411,10 @@ void f2fs_evict_inode(struct inode *inode) > stat_dec_inline_dir(inode); > stat_dec_inline_inode(inode); > > - invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, inode->i_ino); > + /* ino == 0, if f2fs_new_inode() was failed t*/ > + if (inode->i_ino) > + invalidate_mapping_pages(NODE_MAPPING(sbi), inode->i_ino, > + inode->i_ino); > if (xnid) > invalidate_mapping_pages(NODE_MAPPING(sbi), xnid, xnid); > if (inode->i_nlink) { >