From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver Date: Thu, 25 Aug 2016 09:52:36 -0400 Message-ID: <8fa4e921-9dfc-bf2b-32c9-230136536f65@redhat.com> References: <1471985090-202472-1-git-send-email-salil.mehta@huawei.com> <20160824.215341.1803699371957253329.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng" Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Salil Mehta , David Miller Cc: "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linuxarm List-Id: linux-rdma@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng Content-Type: multipart/mixed; boundary="eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C" From: Doug Ledford To: Salil Mehta , David Miller Cc: "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Linuxarm Message-ID: <8fa4e921-9dfc-bf2b-32c9-230136536f65-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver References: <1471985090-202472-1-git-send-email-salil.mehta-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> <20160824.215341.1803699371957253329.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> In-Reply-To: --eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/25/2016 8:00 AM, Salil Mehta wrote: >=20 >=20 >> -----Original Message----- >> From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org] >> Sent: Thursday, August 25, 2016 5:54 AM >> To: Salil Mehta >> Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen)= ; >> mehta.salil.lnk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; >> netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Linuxarm >> Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to= >> the Hisilicon RoCE Driver >> >> From: Salil Mehta >> Date: Wed, 24 Aug 2016 04:44:48 +0800 >> >>> This patch is meant to add support of ACPI to the Hisilicon RoCE >> driver. >>> Following changes have been made in the driver(s): >>> >>> Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been >> done in >>> the RoCE reset function part of the HNS ethernet driver. Earlier >> it only >>> supported DT/syscon. >>> >>> Patch 2/2. HNS RoCE driver: changes done in RoCE driver are meant to >> detect >>> the type and then either use DT specific or ACPI spcific >> functions. Where >>> ever possible, this patch tries to make use of "Unified Device >> Property >>> Interface" APIs to support both DT and ACPI through single >> interface. >>> >>> NOTE 1: ACPI changes done in both of the drivers depend upon the ACPI= >> Table >>> (DSDT and IORT tables) changes part of UEFI/BIOS. These changes >> are NOT >>> part of this patch-set. >>> NOTE 2: Reset function in Patch 1/2 depends upon the reset function >> added in >>> ACPI tables(basically DSDT table) part of the UEFI/BIOS. Again, >> this >>> change is NOT reflected in this patch-set. >> >> I can't apply this series to my tree because the hns infiniband driver= >> doesn't exist in it. > Hi David, > I understand your point. This patch-set was primarily sent for Doug Led= ford > and is based on his internal repository (which has been rebased on the > net-next).=20 >=20 > Though we were hoping, if by any chance, we can expedite the acceptance= of the > below patch part of patch-set in the net-next. This might help Doug Led= ford as > well later on when he pushes the already accepted RoCE driver and ACPI = patches > to linux-next, >=20 > "[PATCH for-next 1/2] net: hns: Add support of ACPI to HNS driver RoCE = Reset > function" >=20 > Below HNS RoCE reset function patch has already been accepted and is pa= rt of your > net-next, > https://patchwork.kernel.org/patch/9287497/ >=20 > Above ACPI support of RoCE Reset patch cleanly applies over the already= accepted > patch in the link. It is not dependent on other accompanying RoCE drive= r ACPI > changes related patch or even the presence of the Infiniband/RoCE Drive= r in the > net-next repository. >=20 > Could you please suggest anything here? =20 >=20 > Thanks=20 > Salil >=20 I can take both. I already pulled net-next to get the initial hns roce reset patch from Dave, so these will apply cleanly with my tree and merge cleanly with Dave's due to the common ancestral base. The only problem is that if you intend to send any other patches that effect this code, then they would need to come through me until the 4.9 merge window is complete so that we don't have later merge conflicts. --=20 Doug Ledford GPG Key ID: 0E572FDD --eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C-- --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXvvgkAAoJELgmozMOVy/dVeEQAIYmmefFm+D3EcNj+/17XxDa D3QZLVuovP7cL7xhAdcpx55YxTdAPFVWfQguPDFlrHuXuC+faTHWfavGSppBwVvz lUU7mWLxw3I8McTLJ82XiNFSieAPn3vMZN5VKWMC9ZTOgX5Wh1PaRC2HB6fPJQQV LIIkD0UYUE0f8CG1Eg4ke3E+tgp/CP9bXZCyQLlTFXXbqKWsKdGQ+8HhkwTKIP3T 9SAUQS61nd6EspyPTmEOv+3yS2eGu88YGGDMGyRA5rM916xHurUcGwpmZTzqKm1X AtAvmxhkFebECKab3k5AZQhiKc04AxF/OpNbEfX/1wRc8kyEZV322d2H95KhBbHy IG1DvIax4IzevArVzwreSUEwU/HMU4xTM2xdhWDaAbE1WddFf9x4M4cPUiyQ5M+b 6AHYjx9QK8N/MwiC+SKDB1OjDs/z9rQIaOe/b3YUToaV2suxUGkxynjM8pEYQxRm WsvSWVHqizk/PMVQK716Hw8p/E8mbHFp4+wTm+ZLx41IRmDTkeW0/TMaRt4263sC g5m56Rff8TfFlO0D8qHxHzeSHSRGn2B5DsHgiq8BlVxMFa9/P38bRMvqcZUDDz88 FLTw0FcSrtxtkjJFkfs+4uRuGHq5owClloXOgMbgT5icgtgUtqL1WUHsQTBxO3Y1 XhpLC8ktXPjzt4ZsYQh9 =AB0u -----END PGP SIGNATURE----- --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934277AbcHYNwx (ORCPT ); Thu, 25 Aug 2016 09:52:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932484AbcHYNwv (ORCPT ); Thu, 25 Aug 2016 09:52:51 -0400 Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver To: Salil Mehta , David Miller References: <1471985090-202472-1-git-send-email-salil.mehta@huawei.com> <20160824.215341.1803699371957253329.davem@davemloft.net> Cc: "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk@gmail.com" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm From: Doug Ledford Message-ID: <8fa4e921-9dfc-bf2b-32c9-230136536f65@redhat.com> Date: Thu, 25 Aug 2016 09:52:36 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 25 Aug 2016 13:52:50 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng Content-Type: multipart/mixed; boundary="eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C" From: Doug Ledford To: Salil Mehta , David Miller Cc: "Huwei (Xavier)" , oulijun , "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk@gmail.com" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Message-ID: <8fa4e921-9dfc-bf2b-32c9-230136536f65@redhat.com> Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to the Hisilicon RoCE Driver References: <1471985090-202472-1-git-send-email-salil.mehta@huawei.com> <20160824.215341.1803699371957253329.davem@davemloft.net> In-Reply-To: --eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/25/2016 8:00 AM, Salil Mehta wrote: >=20 >=20 >> -----Original Message----- >> From: David Miller [mailto:davem@davemloft.net] >> Sent: Thursday, August 25, 2016 5:54 AM >> To: Salil Mehta >> Cc: dledford@redhat.com; Huwei (Xavier); oulijun; Zhuangyuzeng (Yisen)= ; >> mehta.salil.lnk@gmail.com; linux-rdma@vger.kernel.org; >> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm >> Subject: Re: [PATCH for-next 0/2] {IB,net}/hns: Add support of ACPI to= >> the Hisilicon RoCE Driver >> >> From: Salil Mehta >> Date: Wed, 24 Aug 2016 04:44:48 +0800 >> >>> This patch is meant to add support of ACPI to the Hisilicon RoCE >> driver. >>> Following changes have been made in the driver(s): >>> >>> Patch 1/2: HNS Ethernet Driver: changes to support ACPI have been >> done in >>> the RoCE reset function part of the HNS ethernet driver. Earlier >> it only >>> supported DT/syscon. >>> >>> Patch 2/2. HNS RoCE driver: changes done in RoCE driver are meant to >> detect >>> the type and then either use DT specific or ACPI spcific >> functions. Where >>> ever possible, this patch tries to make use of "Unified Device >> Property >>> Interface" APIs to support both DT and ACPI through single >> interface. >>> >>> NOTE 1: ACPI changes done in both of the drivers depend upon the ACPI= >> Table >>> (DSDT and IORT tables) changes part of UEFI/BIOS. These changes >> are NOT >>> part of this patch-set. >>> NOTE 2: Reset function in Patch 1/2 depends upon the reset function >> added in >>> ACPI tables(basically DSDT table) part of the UEFI/BIOS. Again, >> this >>> change is NOT reflected in this patch-set. >> >> I can't apply this series to my tree because the hns infiniband driver= >> doesn't exist in it. > Hi David, > I understand your point. This patch-set was primarily sent for Doug Led= ford > and is based on his internal repository (which has been rebased on the > net-next).=20 >=20 > Though we were hoping, if by any chance, we can expedite the acceptance= of the > below patch part of patch-set in the net-next. This might help Doug Led= ford as > well later on when he pushes the already accepted RoCE driver and ACPI = patches > to linux-next, >=20 > "[PATCH for-next 1/2] net: hns: Add support of ACPI to HNS driver RoCE = Reset > function" >=20 > Below HNS RoCE reset function patch has already been accepted and is pa= rt of your > net-next, > https://patchwork.kernel.org/patch/9287497/ >=20 > Above ACPI support of RoCE Reset patch cleanly applies over the already= accepted > patch in the link. It is not dependent on other accompanying RoCE drive= r ACPI > changes related patch or even the presence of the Infiniband/RoCE Drive= r in the > net-next repository. >=20 > Could you please suggest anything here? =20 >=20 > Thanks=20 > Salil >=20 I can take both. I already pulled net-next to get the initial hns roce reset patch from Dave, so these will apply cleanly with my tree and merge cleanly with Dave's due to the common ancestral base. The only problem is that if you intend to send any other patches that effect this code, then they would need to come through me until the 4.9 merge window is complete so that we don't have later merge conflicts. --=20 Doug Ledford GPG Key ID: 0E572FDD --eqLTcnJwi4cPl53M2MoOTq0lmUBp8kP1C-- --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXvvgkAAoJELgmozMOVy/dVeEQAIYmmefFm+D3EcNj+/17XxDa D3QZLVuovP7cL7xhAdcpx55YxTdAPFVWfQguPDFlrHuXuC+faTHWfavGSppBwVvz lUU7mWLxw3I8McTLJ82XiNFSieAPn3vMZN5VKWMC9ZTOgX5Wh1PaRC2HB6fPJQQV LIIkD0UYUE0f8CG1Eg4ke3E+tgp/CP9bXZCyQLlTFXXbqKWsKdGQ+8HhkwTKIP3T 9SAUQS61nd6EspyPTmEOv+3yS2eGu88YGGDMGyRA5rM916xHurUcGwpmZTzqKm1X AtAvmxhkFebECKab3k5AZQhiKc04AxF/OpNbEfX/1wRc8kyEZV322d2H95KhBbHy IG1DvIax4IzevArVzwreSUEwU/HMU4xTM2xdhWDaAbE1WddFf9x4M4cPUiyQ5M+b 6AHYjx9QK8N/MwiC+SKDB1OjDs/z9rQIaOe/b3YUToaV2suxUGkxynjM8pEYQxRm WsvSWVHqizk/PMVQK716Hw8p/E8mbHFp4+wTm+ZLx41IRmDTkeW0/TMaRt4263sC g5m56Rff8TfFlO0D8qHxHzeSHSRGn2B5DsHgiq8BlVxMFa9/P38bRMvqcZUDDz88 FLTw0FcSrtxtkjJFkfs+4uRuGHq5owClloXOgMbgT5icgtgUtqL1WUHsQTBxO3Y1 XhpLC8ktXPjzt4ZsYQh9 =AB0u -----END PGP SIGNATURE----- --E1PsQ8sJ5G4nBD34gvEUFE777x6OJ3xng--