[PATCH] nvme: schedule requeue whenever a LIVE state is entered

[sagi@grimberg.me (Sagi Grimberg)]

>>> When undergoing state transitions I/O might be requeued, hence
>>> we always have to schedule requeue_work whenever the nvme device
>>> is live, independent on whether the old state was live or not.
>>
>> Any reason why not simply update from live to live?
>>
> ?
> 
> I somewhat fail to parse the answer.
> Care to elaborate?

--
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 2839bb70badf..f0716f6ce41f 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -404,15 +404,12 @@ static inline bool nvme_state_is_live(enum 
nvme_ana_state state)
  static void nvme_update_ns_ana_state(struct nvme_ana_group_desc *desc,
                 struct nvme_ns *ns)
  {
-       enum nvme_ana_state old;
-
         mutex_lock(&ns->head->lock);
-       old = ns->ana_state;
         ns->ana_grpid = le32_to_cpu(desc->grpid);
         ns->ana_state = desc->state;
         clear_bit(NVME_NS_ANA_PENDING, &ns->flags);

-       if (nvme_state_is_live(ns->ana_state) && !nvme_state_is_live(old))
+       if (nvme_state_is_live(ns->ana_state))
                 nvme_mpath_set_live(ns);
         mutex_unlock(&ns->head->lock);
  }
--