All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Swetha Joshi <swethajoshi139@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Swetha <swjoshi@microsoft.com>
Subject: Re: [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled
Date: Mon, 24 May 2021 18:53:07 -0700	[thread overview]
Message-ID: <8fbdab13-ed0e-047a-7a67-2e30471a46b1@linaro.org> (raw)
In-Reply-To: <20210524225608.3191809-1-swethajoshi139@gmail.com>

On 5/24/21 3:56 PM, Swetha Joshi wrote:
> From: Swetha <swjoshi@microsoft.com>
> 
> Signed-off-by: Swetha <swjoshi@microsoft.com>

What are you trying to accomplish?
That's what belongs in the commit message that you omitted.

> +    bool acpi_enabled = false;
> +#ifdef CONFIG_ARM_VIRT
>       bool acpi_enabled = virt_is_acpi_enabled(vms);

Of course this doesn't compile, having declared acpi_enabled twice.  So you 
have clearly not tested this patch sufficiently.

The cc to qemu-trivial is unwarranted.


r~


  parent reply	other threads:[~2021-05-25  2:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 22:56 [PATCH] Adding ifdefs to call the respective routines only when their configs are enabled Swetha Joshi
2021-05-25  0:48 ` no-reply
2021-05-25  1:53 ` Richard Henderson [this message]
2021-05-25  2:14   ` Swetha Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fbdab13-ed0e-047a-7a67-2e30471a46b1@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=swethajoshi139@gmail.com \
    --cc=swjoshi@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.