From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B980FC433E4 for ; Fri, 24 Jul 2020 16:40:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0079206EB for ; Fri, 24 Jul 2020 16:40:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbgGXQkU (ORCPT ); Fri, 24 Jul 2020 12:40:20 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:42495 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbgGXQkU (ORCPT ); Fri, 24 Jul 2020 12:40:20 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jz0k4-0008Vq-23; Fri, 24 Jul 2020 16:40:16 +0000 To: "Moore, Robert" , Garrit Franke , "Wysocki, Rafael J" , "lenb@kernel.org" , "trivial@kernel.org" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "kernel-janitors@vger.kernel.org" References: <20200724162050.18077-2-garritfranke@gmail.com> From: Colin Ian King Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Subject: Re: [Devel] Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Message-ID: <8fc15ffe-9df7-d1f2-2e6a-194f6e8368cc@canonical.com> Date: Fri, 24 Jul 2020 17:40:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On 24/07/2020 17:29, Moore, Robert wrote: > Where is "BIT" defined? this is a linux macro, currently in include/vdso.bits.h, see also linux/bits.h for the BIT_ULL() unsigned long long variant too. > > > -----Original Message----- > From: Garrit Franke > Sent: Friday, July 24, 2020 9:21 AM > To: Moore, Robert ; Wysocki, Rafael J ; lenb@kernel.org; trivial@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; kernel-janitors@vger.kernel.org > Cc: Garrit Franke > Subject: [PATCH] trivial: acpi: replace some bitshifts with BIT macro > > Signed-off-by: Garrit Franke > --- > drivers/acpi/acpica/exfldio.c | 2 +- > drivers/acpi/acpica/utownerid.c | 6 +++--- > drivers/acpi/bus.c | 2 +- > drivers/acpi/sleep.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c index ade35ff1c7..92fc702456 100644 > --- a/drivers/acpi/acpica/exfldio.c > +++ b/drivers/acpi/acpica/exfldio.c > @@ -298,7 +298,7 @@ acpi_ex_register_overflow(union acpi_operand_object *obj_desc, u64 value) > return (FALSE); > } > > - if (value >= ((u64) 1 << obj_desc->common_field.bit_length)) { > + if (value >= ((u64) BIT(obj_desc->common_field.bit_length))) { > /* > * The Value is larger than the maximum value that can fit into > * the register. > diff --git a/drivers/acpi/acpica/utownerid.c b/drivers/acpi/acpica/utownerid.c index d3525ef8ed..c4e2db2f54 100644 > --- a/drivers/acpi/acpica/utownerid.c > +++ b/drivers/acpi/acpica/utownerid.c > @@ -74,13 +74,13 @@ acpi_status acpi_ut_allocate_owner_id(acpi_owner_id *owner_id) > * int. Some compilers or runtime error detection may flag this as > * an error. > */ > - if (!(acpi_gbl_owner_id_mask[j] & ((u32)1 << k))) { > + if (!(acpi_gbl_owner_id_mask[j] & (u32)BIT(k))) { > /* > * Found a free ID. The actual ID is the bit index plus one, > * making zero an invalid Owner ID. Save this as the last ID > * allocated and update the global ID mask. > */ > - acpi_gbl_owner_id_mask[j] |= ((u32)1 << k); > + acpi_gbl_owner_id_mask[j] |= (u32)BIT(k); > > acpi_gbl_last_owner_id_index = (u8)j; > acpi_gbl_next_owner_id_offset = (u8)(k + 1); @@ -171,7 +171,7 @@ void acpi_ut_release_owner_id(acpi_owner_id *owner_id_ptr) > /* Decode ID to index/offset pair */ > > index = ACPI_DIV_32(owner_id); > - bit = (u32)1 << ACPI_MOD_32(owner_id); > + bit = (u32)BIT(ACPI_MOD_32(owner_id)); > > /* Free the owner ID only if it is valid */ > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 54002670cb..39ead80c45 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -233,7 +233,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context) > goto out_kfree; > } > /* Need to ignore the bit0 in result code */ > - errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0); > + errors = *((u32 *)out_obj->buffer.pointer) & BIT(0); > if (errors) { > if (errors & OSC_REQUEST_ERROR) > acpi_print_osc_error(handle, context, diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index aff13bf4d9..38f5210313 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -880,7 +880,7 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func) { > union acpi_object *out_obj; > > - if (!(lps0_dsm_func_mask & (1 << func))) > + if (!(lps0_dsm_func_mask & BIT(func))) > return; > > out_obj = acpi_evaluate_dsm(lps0_device_handle, &lps0_dsm_guid, 1, func, NULL); > -- > 2.25.1 > _______________________________________________ > Devel mailing list -- devel@acpica.org > To unsubscribe send an email to devel-leave@acpica.org > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin Ian King Date: Fri, 24 Jul 2020 16:40:15 +0000 Subject: Re: [Devel] Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Message-Id: <8fc15ffe-9df7-d1f2-2e6a-194f6e8368cc@canonical.com> List-Id: References: <20200724162050.18077-2-garritfranke@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Moore, Robert" , Garrit Franke , "Wysocki, Rafael J" , "lenb@kernel.org" , "trivial@kernel.org" , "linux-acpi@vger.kernel.org" , "devel@acpica.org" , "kernel-janitors@vger.kernel.org" On 24/07/2020 17:29, Moore, Robert wrote: > Where is "BIT" defined? this is a linux macro, currently in include/vdso.bits.h, see also linux/bits.h for the BIT_ULL() unsigned long long variant too. > > > -----Original Message----- > From: Garrit Franke > Sent: Friday, July 24, 2020 9:21 AM > To: Moore, Robert ; Wysocki, Rafael J ; lenb@kernel.org; trivial@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; kernel-janitors@vger.kernel.org > Cc: Garrit Franke > Subject: [PATCH] trivial: acpi: replace some bitshifts with BIT macro > > Signed-off-by: Garrit Franke > --- > drivers/acpi/acpica/exfldio.c | 2 +- > drivers/acpi/acpica/utownerid.c | 6 +++--- > drivers/acpi/bus.c | 2 +- > drivers/acpi/sleep.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.c index ade35ff1c7..92fc702456 100644 > --- a/drivers/acpi/acpica/exfldio.c > +++ b/drivers/acpi/acpica/exfldio.c > @@ -298,7 +298,7 @@ acpi_ex_register_overflow(union acpi_operand_object *obj_desc, u64 value) > return (FALSE); > } > > - if (value >= ((u64) 1 << obj_desc->common_field.bit_length)) { > + if (value >= ((u64) BIT(obj_desc->common_field.bit_length))) { > /* > * The Value is larger than the maximum value that can fit into > * the register. > diff --git a/drivers/acpi/acpica/utownerid.c b/drivers/acpi/acpica/utownerid.c index d3525ef8ed..c4e2db2f54 100644 > --- a/drivers/acpi/acpica/utownerid.c > +++ b/drivers/acpi/acpica/utownerid.c > @@ -74,13 +74,13 @@ acpi_status acpi_ut_allocate_owner_id(acpi_owner_id *owner_id) > * int. Some compilers or runtime error detection may flag this as > * an error. > */ > - if (!(acpi_gbl_owner_id_mask[j] & ((u32)1 << k))) { > + if (!(acpi_gbl_owner_id_mask[j] & (u32)BIT(k))) { > /* > * Found a free ID. The actual ID is the bit index plus one, > * making zero an invalid Owner ID. Save this as the last ID > * allocated and update the global ID mask. > */ > - acpi_gbl_owner_id_mask[j] |= ((u32)1 << k); > + acpi_gbl_owner_id_mask[j] |= (u32)BIT(k); > > acpi_gbl_last_owner_id_index = (u8)j; > acpi_gbl_next_owner_id_offset = (u8)(k + 1); @@ -171,7 +171,7 @@ void acpi_ut_release_owner_id(acpi_owner_id *owner_id_ptr) > /* Decode ID to index/offset pair */ > > index = ACPI_DIV_32(owner_id); > - bit = (u32)1 << ACPI_MOD_32(owner_id); > + bit = (u32)BIT(ACPI_MOD_32(owner_id)); > > /* Free the owner ID only if it is valid */ > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 54002670cb..39ead80c45 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -233,7 +233,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct acpi_osc_context *context) > goto out_kfree; > } > /* Need to ignore the bit0 in result code */ > - errors = *((u32 *)out_obj->buffer.pointer) & ~(1 << 0); > + errors = *((u32 *)out_obj->buffer.pointer) & BIT(0); > if (errors) { > if (errors & OSC_REQUEST_ERROR) > acpi_print_osc_error(handle, context, diff --git a/drivers/acpi/sleep.c b/drivers/acpi/sleep.c index aff13bf4d9..38f5210313 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -880,7 +880,7 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func) { > union acpi_object *out_obj; > > - if (!(lps0_dsm_func_mask & (1 << func))) > + if (!(lps0_dsm_func_mask & BIT(func))) > return; > > out_obj = acpi_evaluate_dsm(lps0_device_handle, &lps0_dsm_guid, 1, func, NULL); > -- > 2.25.1 > _______________________________________________ > Devel mailing list -- devel@acpica.org > To unsubscribe send an email to devel-leave@acpica.org > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8287225612184512283==" MIME-Version: 1.0 From: Colin Ian King Subject: [Devel] Re: [PATCH] trivial: acpi: replace some bitshifts with BIT macro Date: Fri, 24 Jul 2020 17:40:15 +0100 Message-ID: <8fc15ffe-9df7-d1f2-2e6a-194f6e8368cc@canonical.com> In-Reply-To: BYAPR11MB325604ACC5F3BCCEB89A58AA87770@BYAPR11MB3256.namprd11.prod.outlook.com List-ID: To: devel@acpica.org --===============8287225612184512283== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 24/07/2020 17:29, Moore, Robert wrote: > Where is "BIT" defined? this is a linux macro, currently in include/vdso.bits.h, see also linux/bits.h for the BIT_ULL() unsigned long long variant too. > = > = > -----Original Message----- > From: Garrit Franke = > Sent: Friday, July 24, 2020 9:21 AM > To: Moore, Robert ; Wysocki, Rafael J ; lenb(a)kernel.org; trivial(a)kernel.org; linux-acpi(= a)vger.kernel.org; devel(a)acpica.org; kernel-janitors(a)vger.kernel.org > Cc: Garrit Franke > Subject: [PATCH] trivial: acpi: replace some bitshifts with BIT macro > = > Signed-off-by: Garrit Franke > --- > drivers/acpi/acpica/exfldio.c | 2 +- > drivers/acpi/acpica/utownerid.c | 6 +++--- > drivers/acpi/bus.c | 2 +- > drivers/acpi/sleep.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > = > diff --git a/drivers/acpi/acpica/exfldio.c b/drivers/acpi/acpica/exfldio.= c index ade35ff1c7..92fc702456 100644 > --- a/drivers/acpi/acpica/exfldio.c > +++ b/drivers/acpi/acpica/exfldio.c > @@ -298,7 +298,7 @@ acpi_ex_register_overflow(union acpi_operand_object *= obj_desc, u64 value) > return (FALSE); > } > = > - if (value >=3D ((u64) 1 << obj_desc->common_field.bit_length)) { > + if (value >=3D ((u64) BIT(obj_desc->common_field.bit_length))) { > /* > * The Value is larger than the maximum value that can fit into > * the register. > diff --git a/drivers/acpi/acpica/utownerid.c b/drivers/acpi/acpica/utowne= rid.c index d3525ef8ed..c4e2db2f54 100644 > --- a/drivers/acpi/acpica/utownerid.c > +++ b/drivers/acpi/acpica/utownerid.c > @@ -74,13 +74,13 @@ acpi_status acpi_ut_allocate_owner_id(acpi_owner_id *= owner_id) > * int. Some compilers or runtime error detection may flag this as > * an error. > */ > - if (!(acpi_gbl_owner_id_mask[j] & ((u32)1 << k))) { > + if (!(acpi_gbl_owner_id_mask[j] & (u32)BIT(k))) { > /* > * Found a free ID. The actual ID is the bit index plus one, > * making zero an invalid Owner ID. Save this as the last ID > * allocated and update the global ID mask. > */ > - acpi_gbl_owner_id_mask[j] |=3D ((u32)1 << k); > + acpi_gbl_owner_id_mask[j] |=3D (u32)BIT(k); > = > acpi_gbl_last_owner_id_index =3D (u8)j; > acpi_gbl_next_owner_id_offset =3D (u8)(k + 1); @@ -171,7 +171,7 @@ v= oid acpi_ut_release_owner_id(acpi_owner_id *owner_id_ptr) > /* Decode ID to index/offset pair */ > = > index =3D ACPI_DIV_32(owner_id); > - bit =3D (u32)1 << ACPI_MOD_32(owner_id); > + bit =3D (u32)BIT(ACPI_MOD_32(owner_id)); > = > /* Free the owner ID only if it is valid */ > = > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 54002670cb..39= ead80c45 100644 > --- a/drivers/acpi/bus.c > +++ b/drivers/acpi/bus.c > @@ -233,7 +233,7 @@ acpi_status acpi_run_osc(acpi_handle handle, struct a= cpi_osc_context *context) > goto out_kfree; > } > /* Need to ignore the bit0 in result code */ > - errors =3D *((u32 *)out_obj->buffer.pointer) & ~(1 << 0); > + errors =3D *((u32 *)out_obj->buffer.pointer) & BIT(0); > if (errors) { > if (errors & OSC_REQUEST_ERROR) > acpi_print_osc_error(handle, context, diff --git a/drivers/acpi/sleep= .c b/drivers/acpi/sleep.c index aff13bf4d9..38f5210313 100644 > --- a/drivers/acpi/sleep.c > +++ b/drivers/acpi/sleep.c > @@ -880,7 +880,7 @@ static void acpi_sleep_run_lps0_dsm(unsigned int func= ) { > union acpi_object *out_obj; > = > - if (!(lps0_dsm_func_mask & (1 << func))) > + if (!(lps0_dsm_func_mask & BIT(func))) > return; > = > out_obj =3D acpi_evaluate_dsm(lps0_device_handle, &lps0_dsm_guid, 1, fu= nc, NULL); > -- > 2.25.1 > _______________________________________________ > Devel mailing list -- devel(a)acpica.org > To unsubscribe send an email to devel-leave(a)acpica.org > %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s >=20 --===============8287225612184512283==--