From: sagi@grimberg.me (Sagi Grimberg)
Subject: [PATCH 2/3] nvme-fabrics: Allow ctrl loss timeout configuration
Date: Thu, 20 Apr 2017 13:20:10 +0300 [thread overview]
Message-ID: <8fcd2b81-15a8-d85d-0fcd-4f7cefaffbfa@grimberg.me> (raw)
In-Reply-To: <1c260723-1771-3518-87b1-60d95fa423d8@broadcom.com>
> I know this patch has been pulled in - but I think it very odd that we
> added a field (nr_reconnects) into the opts structure, that is not an
> connect option but is instead a dynamically-changing transport
> variable. As the change introduced a common transport variable beyond
> start options, the patch should have formally added a generic transport
> structure to the ctrl structure.
You're correct, I can move it to sit in nvme_ctrl.
next prev parent reply other threads:[~2017-04-20 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 22:42 [PATCH 0/3] Introduce fabrics controller loss timeout Sagi Grimberg
2017-03-18 22:42 ` [PATCH 1/3] nvme-rdma: get rid of local reconnect_delay Sagi Grimberg
2017-03-27 9:50 ` Christoph Hellwig
2017-03-18 22:42 ` [PATCH 2/3] nvme-fabrics: Allow ctrl loss timeout configuration Sagi Grimberg
2017-03-27 9:50 ` Christoph Hellwig
2017-04-17 22:29 ` James Smart
2017-04-20 10:20 ` Sagi Grimberg [this message]
2017-03-18 22:42 ` [PATCH 3/3] nvme-rdma: Support ctrl_loss_tmo Sagi Grimberg
2017-03-27 9:50 ` Christoph Hellwig
2017-04-25 0:46 ` James Smart
2017-05-03 8:05 ` Sagi Grimberg
2017-03-27 0:41 ` [PATCH 0/3] Introduce fabrics controller loss timeout Yi Zhang
2017-03-28 11:37 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fcd2b81-15a8-d85d-0fcd-4f7cefaffbfa@grimberg.me \
--to=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.