Re: [PATCH 1/2] xen/xsm: Introduce new boot parameter xsm

["Xin Li (Talons)" <xin.li@citrix.com>]

> -----Original Message-----
> From: George Dunlap
> Sent: Thursday, July 5, 2018 12:55 AM
> To: Jan Beulich <JBeulich@suse.com>
> Cc: Xin Li <talons.lee@gmail.com>; Andrew Cooper
> <Andrew.Cooper3@citrix.com>; Ming Lu <ming.lu@citrix.com>; Sergey Dyasli
> <sergey.dyasli@citrix.com>; Wei Liu <wei.liu2@citrix.com>; Xin Li (Talons)
> <xin.li@citrix.com>; George Dunlap <George.Dunlap@citrix.com>; Stefano
> Stabellini <sstabellini@kernel.org>; xen-devel <xen-devel@lists.xen.org>;
> Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>; Daniel de Graaf
> <dgdegra@tycho.nsa.gov>; Tim (Xen.org) <tim@xen.org>
> Subject: Re: [PATCH 1/2] xen/xsm: Introduce new boot parameter xsm
> 
> 
> 
> > On Jul 3, 2018, at 8:12 AM, Jan Beulich <JBeulich@suse.com> wrote:
> >
> > First of all - please indicate the version also in the subject, i.e.
> > here [PATCH v2 1/2] or some such.
> >
> >>>> On 03.07.18 at 03:26, <talons.lee@gmail.com> wrote:
> >> v2
> >> To further discuss:
> >> 1) is "dummy" a good command line option?
> >> other choices: basic", "trivial", or "simple"
> >
> > Indeed, but not limited to the named set.
> 
> I think I’d go with “standard” or “default”.  The “default” restrictions are by no
> means “dummy”, “trivial”, or “simple” — they’re carefully thought out for the
> most common Xen deployment.

"default" seems to be a good choice.
It matches the code logic.

    if ( !strcmp(s, "default") )
        xsm_bootparam = XSM_BOOTPARAM_DUMMY;

also update " docs/misc/xen-command-line.markdown"

> 
>  -George


Best regards

Xin(Talons) Li
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel