From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C487C433EF for ; Thu, 2 Dec 2021 16:41:39 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4AD7183763; Thu, 2 Dec 2021 17:41:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="pFfXbUbN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 50BC383777; Thu, 2 Dec 2021 17:41:34 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03on062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0a::62f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACA1683758 for ; Thu, 2 Dec 2021 17:41:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k80FzuJUv2fddtRvfF/+tpnyGgo0E3EWRi1IR2C2kRKIarySKm/6lJYHOuA8FXnVAAKfhU9B+SD2qjWLXb6a62SsV9TSbcGzjlz5unCSB+MuLB3xxuEWeW1iL/jiLmlMI9BxWEzmquV28bevMx1mu9tCQsEKgWD+DOEWMqY0JowYLN1UNQpINK7VWLl62h3c5o2ZXKx3TreqTrOs8rl0tcJIh3+64e3Ede77k67aasoeuTAarig2KV+9xmItN5hse4yxvQYTHInFzupohfA4u9XPwY4xR303OGZv9zowkOBtTWxQF/y2eiBfdF49BpB9TfSTkts6bZ8C1RcI1NgM+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wK1WfkVbcMuiDAfMI7+v/od2WezUVsMMHzjnvPOfEBc=; b=K/2NlkjEI3bcu78SNZd/Np/Te93MkILq+ouokSRm/K+e1aBwblBxOUOQMXUgHcTRPEq+BP0acRafPYKUswWsa8mDbmBbNvNcbsR7uf8d1X7uY67yfAOe3jV6DthMw5l1eeDP8SWO9p1fh8Eagq+88vMh4GlGx2mJvPufYy/zpeohplU2uCw/07J7mHDqlLtp4+mQiBQyfOWq//TuM9nLJnjXNbmbZwOw0KBYbR8QQ/stZ+A9bO2HoIc89sae55ugu4S6AailbbVrj5b4Bxp2tVkqMIyIegH6HxZuJwIxNMVFO9QJEob9+ikPguCJdSzD1M9GhJ2CQ2yIYAFRViXqzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wK1WfkVbcMuiDAfMI7+v/od2WezUVsMMHzjnvPOfEBc=; b=pFfXbUbNGZ5OZ2MwGhNUT8C4qSD7JDdPHO5ChaNozm7uqniIYY2LcKnn7AAiOwumkwuSu7ilBTdo/o1ILVeUZd44tdVqr15Y0PpsZ6+qJ8N4E74tVOInJcQUVLyacgzF+mjF1431YumvG1v3y4bpsp0E5LmkWliYvWmQumBWy4g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DB8PR03MB6330.eurprd03.prod.outlook.com (2603:10a6:10:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Thu, 2 Dec 2021 16:41:28 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9093:a60b:46b7:32ee]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::9093:a60b:46b7:32ee%4]) with mapi id 15.20.4734.024; Thu, 2 Dec 2021 16:41:28 +0000 From: Sean Anderson Subject: Re: [PATCH] mtd: sf: Set SF parameters as env variables To: Pratyush Yadav , Marek Vasut Cc: u-boot@lists.denx.de, Jagan Teki , Vignesh R References: <20210914032849.273625-1-marex@denx.de> <20210923185316.se55powofpm37mg3@ti.com> <55953baa-c585-f180-aff3-b68d3acee34b@denx.de> <20211007124010.3aibcajzt4ojwcqr@ti.com> Message-ID: <8fe29da5-5017-b222-4eb7-b28dbd061f82@seco.com> Date: Thu, 2 Dec 2021 11:41:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20211007124010.3aibcajzt4ojwcqr@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MN2PR19CA0009.namprd19.prod.outlook.com (2603:10b6:208:178::22) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 Received: from [172.27.1.65] (50.195.82.171) by MN2PR19CA0009.namprd19.prod.outlook.com (2603:10b6:208:178::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.22 via Frontend Transport; Thu, 2 Dec 2021 16:41:27 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5cb74d1f-4236-4306-720f-08d9b5b2969d X-MS-TrafficTypeDiagnostic: DB8PR03MB6330: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BobDGkBXn1+0C07CufD+X+GCe0LSquFZLgX/7kg5AC11aKfBMQWA+dhu8fplpk4YKSCkD847LwTZ/1uI0hnckgfFleJm+AcG68cNVaV03iQLmfmlG05vXBC149tQCdSshnHhMue/IQhcwloKGqYUrqewurbhAJ6SUCAKjN/wzEHqsSlhV4um8QUsFHJ5+LuXNJ6BnCyOHTrdGM5abcCSzHe1o2RlE/UsdcsjSZFNcuMmHL0nYNJSQ5HmfDiMz1rR59AgIhGS/3NJfqYLbxL/S0tPuUSu4ckYHs/8elPsoPzecROjZqAnze1FJczq2YlSOGDllg1k/WiMsgodjJLihnobFH6rUrYRYb0i8Tv6Cxqi7Hwf08/YMRrFhpSstuo/NXrDb8JK7j89a7TuvSIm9a/K3Olt+xv6q1WEW0cXBkNiY1Z1LThw1ngITQNTOTuhWfevEuKGCQm5H07ESSuPmTkkua1l3ZRFf1XCPaIR7bKqP2DZtUIgxrkX/DvWczx/tmPVfpVlrvwX63167EOSqREX5dg5ufxxGX62F3fwTXJENN+n1VJl6bm2YTNjZSngQuaVqakzWIgfzBcjdiEjgA5ggzvU8oJRmIrgwZG4e3veTrQkQxfOyMAY4u2suAEND6UP0MqboFaNNdfgxnYK4ORg+j9nCSYOKdIfENJAJlf7ZScREy/XsEgycvNFP/brqtTwu2/eMWEtMbDmoJTxDGAfWvFfwXEinKsWP17SPakJibjy/qajNSfFQPiVtyNPm88BoGLISLPtRmp0f/Wtxw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(52116002)(8676002)(86362001)(2906002)(54906003)(110136005)(2616005)(508600001)(38350700002)(6666004)(316002)(8936002)(31696002)(31686004)(38100700002)(16576012)(53546011)(66946007)(66556008)(26005)(36756003)(66476007)(83380400001)(186003)(4326008)(6486002)(956004)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkgzVjAySjBab2JpbHhIc2duYS92a2d0bVZGUUFhcWRrMEloRGhNRitCOWpG?= =?utf-8?B?RURlSktScnJwdmhVbzlCUzN6cWJOcVRZTU8zYmxLOHJzNkdHTG9kUGNWN2k3?= =?utf-8?B?VVhQeGlvV2NIRjBLbjhTWkFYUUhmcXJNejQyeVNYVUVFUWxVcFgrRnNXS1Bz?= =?utf-8?B?Q3J3OGZvSGVLbUcxNDZ0Y0JYQ0puZnNBOU9PeWt6UW1vSTI1OCt6NWFlMm9U?= =?utf-8?B?bXJ4RW1tSVhMaTBURnZSZE1Hb0N1Umw3MndhTUc3U2N1V054SllMN0hha1Fj?= =?utf-8?B?T1ZUTWs0VXFQeEpVWjlMcjZsTkltTlFtNXlYaXN4Mkt5c1pGcmZ1THVVTWQ2?= =?utf-8?B?cDhEUEdhOVJNaGJkVDNpYUgyaGV3cmcyeG5qbFdLR3I0cFB4SFY5MnFiK20v?= =?utf-8?B?eWxYa2poVHVoaW5pVGhWM05WZmdSVTltYjFkdkRac0Z5bFE3cXlYLzkwWnBw?= =?utf-8?B?V00rQnRCdFIrSTU0R3c4UFppZERJQ1c4cmdpZ0pPRXJlRmRtOG1zRnJTNHFR?= =?utf-8?B?MEdLb3hyd2ZQSm5PckhiRlRyZEZlQURyb3RQQUZzVndya0dUL25SVXBMUHVJ?= =?utf-8?B?ck1FQVdUT1E0VUQxY0dSSHo0N01sSzlrM0RETXFBdnJpWXBpampFejdTWE1l?= =?utf-8?B?bDJlYnJ1M2FFRndET1JRUUM5NDdXZjRjUW5NUWVzZ2RMekhzMHovVERIb01w?= =?utf-8?B?VVdmK0IvOHpSckpGVHd5YzRQTzlPRmlnV0JtS2ZmenpkR1RyMXlXZzg0cW9U?= =?utf-8?B?VkVINHpBaXZ2VXhkMUtZSVUwbjdEeU9EY1daVWw0aHhRVjhnRGw4MHZOZGlK?= =?utf-8?B?cU1QMTBlOTBwS3BSR2pqWEQxQmUwVTYwUFhHRFpDRFg3MkFXN1h3RzJRbEpz?= =?utf-8?B?WDU1WGZZSnJwWXRNNGtEVmlUMlFjMFpWam05bUNNVloxZkt4NGt3aVY0b1BI?= =?utf-8?B?RGZsVzRSdWY1b25FSC9BWldxRnhNOTYra25GNit5dVJoK3ZZNFo0Um1aTHdM?= =?utf-8?B?aUxoWCs5RjRESmFDUlp3Z1dZYWpUWElVTldRM2I4RHpDQkgwVVNKbjBSTDVz?= =?utf-8?B?MURZRDBhU3VpUzJxam5PSENBekt6eVRieHRsbmlqbDlYclVIY3FjN21icitK?= =?utf-8?B?RFBsVDBVUEhsdVQvelF3R0l3am9WeVRUOXRsODVFK1ptNWFGT2V2Z0FsdVA0?= =?utf-8?B?b3FxeFBxK2xBMTI5aFhnVlphTW8waUhhQWMxMXB5YmZnRG5lQ1ZTUmk0cklK?= =?utf-8?B?TXBJM0JDQngvalF0R04vVmM4UmFMbjdSRXJFOW5LRHphVk44U0FTTGF5ZmMr?= =?utf-8?B?RVlFdWV0WnB1NFZOc0hjNjY5MDlrdW1vb0VPN1VybjRZN2dsZXpPL3JlbFN6?= =?utf-8?B?aXRDUWZqRjJEemo4M2FJdWlmNDJ2bzJwNHlCWWIwbzVSV1RYRHhoUVJRblZL?= =?utf-8?B?SVV0QUtNSGZoK3JMT0hFaXUxanFsRTB3aGdvZktuMDZSbWkyOWdqY0lhV3Fv?= =?utf-8?B?dGxRU0N3emlIR2poTGZ6cEViYk42UXUrNFIwZ3ZiOGZpaVlCc2cyQlRYdWFh?= =?utf-8?B?eVprSnFLU1FxU3lHU2F0NmdpSjZFd0RubEx1d2kwTGM3dVp3OXpQb1lrb1di?= =?utf-8?B?cHFiQVNrOU81MGQ4MW43UTVoaEp1bWhCc3UwTkhPSlNGZWtoTi9keXV1bmlB?= =?utf-8?B?SjhGVlFDcDZuMms3WjZYRXovUWFlUk9GTlFWZ1AvTXArNXhuT0hsYkhzOFYz?= =?utf-8?B?MlZHTlc0SlJsTnBmRzRGSUVHbVNPdmZwQlFmd010MlFSTTk3dXMydTVnQ29u?= =?utf-8?B?SVkxY3o3c0dsZEh1Qy9STVR1UjZzNEZNZXYyRlJvcjF6WC9qaGZlOGhEc0Zj?= =?utf-8?B?QVZ6eU8xc0tVUUt4c285ZEJ2RG9sSzRJTnArazFQWWV5ZTJpNWhoTlk1WHBY?= =?utf-8?B?WE5NOWhUUndBZVUzZ3pQMHlwb0x4Q24wRk5Ub3pWUVF4ZWdJbjhHOUVOWExC?= =?utf-8?B?SFJYaCsybStiNjUzSE44NytkT3A5elZuTEszK3o1bWQzOWlxUDJjcFI2TmJH?= =?utf-8?B?NnRHLzVIdzZob0xTc0pjSitHeEwrbkZaMVdKZ0hHaS9KSWNBcnIxZWpuNmtX?= =?utf-8?B?L3ZmRFVWa2lISXkzak5UdzROS1ZscmNyNGc1VHNTSEpaRFRUWnE0M3RIU2NO?= =?utf-8?Q?Ndjh6x27aHY/dwvjk54eh00=3D?= X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cb74d1f-4236-4306-720f-08d9b5b2969d X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2021 16:41:28.7111 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 55AnLLkpuBGByrkAgjPR2zhj576r7StdARwk/BFe3T/s/vmecLWzG7q8EHYI/Y6qwRmi1keTO+Pj+ZPZ1IsTwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR03MB6330 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.38 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 10/7/21 8:40 AM, Pratyush Yadav wrote: > On 23/09/21 10:00PM, Marek Vasut wrote: >> On 9/23/21 8:53 PM, Pratyush Yadav wrote: >> > On 14/09/21 05:28AM, Marek Vasut wrote: >> > > Set the SF page size, erase block size and total size as an environment >> > > variable after "sf probe". This lets us discern boards with multiple >> > > distinct SPI flash options and also e.g. set mtdparts accordingly. >> > >> > I don't quite follow the rationale for making these environment >> > variables. Wouldn't you be better off finding this info out via mtd or >> > sf command? >> >> I need to use that info in a script, that's why these env vars. > > Ok. Honestly, it doesn't feel quite right to me. > > I haven't played with U-Boot's shell too much but is there no way to > assign variables from command outputs? For example, can we do something > like `foo=$(cat a.txt)`? If that is possible, maybe add some new > subcommands to "sf" that return this information? > There is not. IMO the current solution (exporting to environment variables in an ad-hoc manner) is rather ugly, but fixing it is difficult :) --Sean