[Buildroot] [PATCH] ltp-testsuite: add --with-open-posix-testsuite

[Arnout Vandecappelle <arnout@mind.be>]

On 03-05-18 18:03, Ciro Santilli wrote:
> The issues mentioned on the removed comments were resolved,
> tested in QEMU x86_64 and aarch64.

 Would be good to refer to the upstream commit that fixes it:
ca9561c124408ed0f5ed92c9ac7e092de05b5aed.


> Signed-off-by: Ciro Santilli <ciro.santilli@gmail.com>
> ---
> This patch supposes that the removed comments imply that a default
> --with-open-posix-testsuite
> is desirable (and I confirm that it does not take unreasoble build
> time or disk space),

 Indeed, no reason not to enable it.

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> and that there is no generic way to add autotools configs to packages:
> https://stackoverflow.com/questions/44341188/how-to-pass-extra-custom-configure-autotools-options-to-a-buildroot-package
> 
>  package/ltp-testsuite/ltp-testsuite.mk | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/package/ltp-testsuite/ltp-testsuite.mk
> b/package/ltp-testsuite/ltp-testsuite.mk
> index c47f587836..4584ca45da 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -9,17 +9,8 @@ LTP_TESTSUITE_SOURCE = ltp-full-$(LTP_TESTSUITE_VERSION).tar.xz
>  LTP_TESTSUITE_SITE =
> https://github.com/linux-test-project/ltp/releases/download/$(LTP_TESTSUITE_VERSION)
>  LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
>  LTP_TESTSUITE_LICENSE_FILES = COPYING
> -
> -# Do not enable Open POSIX testsuite as it doesn't cross-compile
> -# properly: t0 program is built for the host machine. Notice that due
> -# to a bug, --without-open-posix-testsuite actually enables the test
> -# suite.
> -# See https://github.com/linux-test-project/ltp/issues/143 (invalid
> -# autoconf test) and
> -# https://github.com/linux-test-project/ltp/issues/144 (Open POSIX
> -# testsuite not cross-compiling).
>  LTP_TESTSUITE_CONF_OPTS += \
> - --with-realtime-testsuite
> + --with-realtime-testsuite --with-open-posix-testsuite
> 
>  ifeq ($(BR2_LINUX_KERNEL),y)
>  LTP_TESTSUITE_DEPENDENCIES += linux
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF