From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 367F9C49361 for ; Fri, 18 Jun 2021 09:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0256A613CB for ; Fri, 18 Jun 2021 09:01:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231234AbhFRJD2 (ORCPT ); Fri, 18 Jun 2021 05:03:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48153 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230070AbhFRJD0 (ORCPT ); Fri, 18 Jun 2021 05:03:26 -0400 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1luANJ-0001MN-4o for linux-kernel@vger.kernel.org; Fri, 18 Jun 2021 09:01:17 +0000 Received: by mail-ed1-f70.google.com with SMTP id v12-20020aa7dbcc0000b029038fc8e57037so3222795edt.0 for ; Fri, 18 Jun 2021 02:01:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4Rpo5v0so+s5bFTiYG2x3xDNdr/p1fKsU61iXsP86UQ=; b=RDPJCqnYdP5XMoSw0FSZFzV7h6f4/1P4Gr+X98OaLnK0t6U2vLW052nIxbYAflFwbI foHTcmAO9BBjrGwOj92Hpg2FWi1oTnIGmUaeki54fRzpsSGExnShb1L7sNd360Hd5bNB MAdDvJ4/PmQ52h2PFTvhwz5qI3m8Bd6nD1gN8xhWZNXjDrn/Hdy93OrHp1zVq2YQK7Rc /EjywpPIwfHlpwIRcrlDI+gJJ7zvZa7+mJd7Wwl8++NxXtQYuWr7m+CUMaqSQVS/WVlK lMppTKdFB8t7GvNVm6nG9YEPH01FOwAVmN8Tw11yL0CEtnQPx6uz+JedCWBp29ziFjE8 HHtQ== X-Gm-Message-State: AOAM530B0we+hRxMw+Tj0psNPgaqMhC4zTOIVDkCU6KsWtr5SO/6iyJu K3PHDLfoRRGGW341iENymQXuB2NetUM95Hn7UAxHFibZPeF+MEgPveFPxJnZ7cgPhqSf5JwdCIG gjmHG5wMbeqRlmZKaxWIAcpdrpnMpaZJwTX3DBYMw6g== X-Received: by 2002:a17:906:2752:: with SMTP id a18mr10451913ejd.458.1624006876932; Fri, 18 Jun 2021 02:01:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2MB2+Q8e0FJ/0cH1Qq/fGA0AiH6hJVmgNkJ1FexQwOk2Rh7qUGVrnNY3ri6yOvmqlsOFFpw== X-Received: by 2002:a17:906:2752:: with SMTP id a18mr10451900ejd.458.1624006876745; Fri, 18 Jun 2021 02:01:16 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id de6sm402336edb.77.2021.06.18.02.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 02:01:16 -0700 (PDT) Subject: Re: [PATCH v2] NFC: nxp-nci: remove unnecessary label To: samirweng1979 , charles.gorand@effinnov.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wengjianfeng References: <20210618085226.18440-1-samirweng1979@163.com> From: Krzysztof Kozlowski Message-ID: <8ff9ac28-5d83-ebf8-a6b1-53a2a7b7d912@canonical.com> Date: Fri, 18 Jun 2021 11:01:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210618085226.18440-1-samirweng1979@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/06/2021 10:52, samirweng1979 wrote: > From: wengjianfeng > > Remove unnecessary label chunk_exit and return directly. > > Signed-off-by: wengjianfeng > --- > drivers/nfc/nxp-nci/firmware.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof > diff --git a/drivers/nfc/nxp-nci/firmware.c b/drivers/nfc/nxp-nci/firmware.c > index dae0c80..119bf30 100644 > --- a/drivers/nfc/nxp-nci/firmware.c > +++ b/drivers/nfc/nxp-nci/firmware.c > @@ -95,10 +95,8 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info) > int r; > > skb = nci_skb_alloc(info->ndev, info->max_payload, GFP_KERNEL); > - if (!skb) { > - r = -ENOMEM; > - goto chunk_exit; > - } > + if (!skb) > + return -ENOMEM; > > chunk_len = info->max_payload - NXP_NCI_FW_HDR_LEN - NXP_NCI_FW_CRC_LEN; > remaining_len = fw_info->frame_size - fw_info->written; > @@ -124,7 +122,6 @@ static int nxp_nci_fw_send_chunk(struct nxp_nci_info *info) > > kfree_skb(skb); > > -chunk_exit: > return r; > } > >