All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: intel-gfx@lists.freedesktop.org
Cc: jesse.barnes@intel.com
Subject: Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c
Date: Thu, 09 Sep 2010 00:26:32 +0100	[thread overview]
Message-ID: <8u3s8d$jh2dvh@orsmga001.jf.intel.com> (raw)
In-Reply-To: <20100908225217.6870.54888.stgit@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Thu, 09 Sep 2010 00:52:17 +0200, David Härdeman <david@hardeman.nu> wrote:
> This patch enables the sending of AVI infoframes in
> drivers/gpu/drm/i915/intel_hdmi.c.
> 
> My receiver currently loses sync when the HDMI output on my computer
> (DG45FC motherboard) is switched from 800x600 (the BIOS resolution) to
> 1920x1080 as part of the boot. Fixable by switching inputs on the receiver
> a couple of times.
> 
> With this patch, my receiver has not lost sync yet (> 40 tries).
> 
> I'm not sure that the general approach is sound, which is why I'm sending
> this out for some feedback and review (in particular, is the SDVOB and SDVOC
> handling in intel_hdmi_set_avi_infoframe() correct?).

Oh, more code duplication... I thought I recognised this, we do this for
SDVO HDMI but not integrated HDMI.

Can you move the dip_infoframe helper functions into intel_hdmi.c and call
them from intel_sdvo.c? And then we can take a closer look at sdvox.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2010-09-08 23:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-08 22:52 David Härdeman
2010-09-08 23:26 ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='8u3s8d$jh2dvh@orsmga001.jf.intel.com' \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jesse.barnes@intel.com \
    --subject='Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.