From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH] i915: enable AVI infoframe for intel_hdmi.c Date: Thu, 09 Sep 2010 00:26:32 +0100 Message-ID: <8u3s8d$jh2dvh@orsmga001.jf.intel.com> References: <20100908225217.6870.54888.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2033358323==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 78EDE9E733 for ; Wed, 8 Sep 2010 16:26:35 -0700 (PDT) In-Reply-To: <20100908225217.6870.54888.stgit@localhost.localdomain> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org Cc: jesse.barnes@intel.com List-Id: intel-gfx@lists.freedesktop.org --===============2033358323== Content-Type: text/plain On Thu, 09 Sep 2010 00:52:17 +0200, David Härdeman wrote: > This patch enables the sending of AVI infoframes in > drivers/gpu/drm/i915/intel_hdmi.c. > > My receiver currently loses sync when the HDMI output on my computer > (DG45FC motherboard) is switched from 800x600 (the BIOS resolution) to > 1920x1080 as part of the boot. Fixable by switching inputs on the receiver > a couple of times. > > With this patch, my receiver has not lost sync yet (> 40 tries). > > I'm not sure that the general approach is sound, which is why I'm sending > this out for some feedback and review (in particular, is the SDVOB and SDVOC > handling in intel_hdmi_set_avi_infoframe() correct?). Oh, more code duplication... I thought I recognised this, we do this for SDVO HDMI but not integrated HDMI. Can you move the dip_infoframe helper functions into intel_hdmi.c and call them from intel_sdvo.c? And then we can take a closer look at sdvox. -Chris -- Chris Wilson, Intel Open Source Technology Centre --===============2033358323== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2033358323==--