From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCBCC4361B for ; Wed, 9 Dec 2020 10:22:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9C2023B5D for ; Wed, 9 Dec 2020 10:22:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729825AbgLIKW0 (ORCPT ); Wed, 9 Dec 2020 05:22:26 -0500 Received: from 19.mo4.mail-out.ovh.net ([87.98.179.66]:41452 "EHLO 19.mo4.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727800AbgLIKWZ (ORCPT ); Wed, 9 Dec 2020 05:22:25 -0500 X-Greylist: delayed 1210 seconds by postgrey-1.27 at vger.kernel.org; Wed, 09 Dec 2020 05:22:24 EST Received: from player698.ha.ovh.net (unknown [10.108.57.44]) by mo4.mail-out.ovh.net (Postfix) with ESMTP id 81E6A25B0FA for ; Wed, 9 Dec 2020 10:43:22 +0100 (CET) Received: from RCM-web5.webmail.mail.ovh.net (82-65-25-201.subs.proxad.net [82.65.25.201]) (Authenticated sender: steve@sk2.org) by player698.ha.ovh.net (Postfix) with ESMTPSA id 1D42F18F600CF; Wed, 9 Dec 2020 09:43:17 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 09 Dec 2020 10:43:16 +0100 From: Stephen Kitt To: "Michael Kerrisk (man-pages)" , Christian Brauner Cc: linux-man , Alejandro Colomar , lkml Subject: Re: [patch] close_range.2: new page documenting close_range(2) In-Reply-To: <20201209094039.ksqlt7g5mq7mp4mq@wittgenstein> References: <20201208215133.30575-1-steve@sk2.org> <20201209094039.ksqlt7g5mq7mp4mq@wittgenstein> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <9020961b9cb4ebc61d6a07f603a226aa@sk2.org> X-Sender: steve@sk2.org X-Originating-IP: 82.65.25.201 X-Webmail-UserID: steve@sk2.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Ovh-Tracer-Id: 11257310219080977789 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrudejkedgtdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvufgjfhgfkfigihgtgfesthekjhdttderjeenucfhrhhomhepufhtvghphhgvnhcumfhithhtuceoshhtvghvvgesshhkvddrohhrgheqnecuggftrfgrthhtvghrnhepheeftedvhfevuedthedthfektdelleegtdevfeetveefhfekgedttdefgfetgfeunecukfhppedtrddtrddtrddtpdekvddrieehrddvhedrvddtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhhouggvpehsmhhtphdqohhuthdphhgvlhhopehplhgrhigvrheileekrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomhepshhtvghvvgesshhkvddrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 09/12/2020 10:40, Christian Brauner a écrit : > On Wed, Dec 09, 2020 at 09:50:38AM +0100, Michael Kerrisk (man-pages) > wrote: >> > +.PP >> > +.I flags >> > +can be set to >> > +.B CLOSE_RANGE_UNSHARE >> > +to unshare the range of file descriptors from any other processes, >> > +.I instead >> > +of closing them. >> >> Really "instead of closing them"? I had supposed that rather that this >> should be "before closing them". That's also how the kernel code reads >> to me, from a quick glance. > > It's also mentioned in the commit message. Basically setting > CLOSE_RANGE_UNSHARE is equivalent to: > > unshare(CLONE_FILES); > close_range(, ); Yes, I got that mixed up, thanks for the clarification! I'll send a v2 addressing the review comments later today. Regards, Stephen