From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhoucm1 Subject: Re: [PATCH 2/3] drm/amdgpu: fix and cleanup cpu visible VRAM handling Date: Tue, 10 Apr 2018 10:38:35 +0800 Message-ID: <9031c37a-3739-0364-c0db-96a4ef8611cc@amd.com> References: <20180409101900.2790-1-christian.koenig@amd.com> <20180409101900.2790-2-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180409101900.2790-2-christian.koenig-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org CgpPbiAyMDE45bm0MDTmnIgwOeaXpSAxODoxOCwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPiBU aGUgZGV0ZWN0aW9uIGlmIGEgQk8gd2FzIHBsYWNlZCBpbiBDUFUgdmlzaWJsZSBWUkFNIHdhcyBp bmNvcnJlY3QuCj4KPiBGaXggaXQgYW5kIG1lcmdlIGl0IHdpdGggdGhlIGNvcnJlY3QgZGV0ZWN0 aW9uIGluIGFtZGdwdV90dG0uYwo+Cj4gU2lnbmVkLW9mZi1ieTogQ2hyaXN0aWFuIEvDtm5pZyA8 Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgpSZXZpZXdlZC1ieTogQ2h1bm1pbmcgWmhvdSA8ZGF2 aWQxLnpob3VAYW1kLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfY3MuYyAgICAgfCAgNiArKy0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV9vYmplY3QuaCB8IDIxICsrKysrKysrKysrKysrKysrKysrKwo+ICAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jICAgIHwgMTkgKysrLS0tLS0tLS0tLS0tLS0t LQo+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkK Pgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfY3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9jcy5jCj4gaW5kZXggZGU2OWFiMTJi YjU1Li42OGFmMmY4NzhiYzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf Y3MuYwo+IEBAIC0zODIsOCArMzgyLDcgQEAgc3RhdGljIGludCBhbWRncHVfY3NfYm9fdmFsaWRh dGUoc3RydWN0IGFtZGdwdV9jc19wYXJzZXIgKnAsCj4gICAKPiAgIAlwLT5ieXRlc19tb3ZlZCAr PSBjdHguYnl0ZXNfbW92ZWQ7Cj4gICAJaWYgKGFkZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6ZSA8 IGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZSAmJgo+IC0JICAgIGJvLT50Ym8ubWVtLm1lbV90eXBl ID09IFRUTV9QTF9WUkFNICYmCj4gLQkgICAgYm8tPnRiby5tZW0uc3RhcnQgPCBhZGV2LT5nbWMu dmlzaWJsZV92cmFtX3NpemUgPj4gUEFHRV9TSElGVCkKPiArCSAgICBhbWRncHVfYm9faW5fY3B1 X3Zpc2libGVfdnJhbShibykpCj4gICAJCXAtPmJ5dGVzX21vdmVkX3ZpcyArPSBjdHguYnl0ZXNf bW92ZWQ7Cj4gICAKPiAgIAlpZiAodW5saWtlbHkociA9PSAtRU5PTUVNKSAmJiBkb21haW4gIT0g Ym8tPmFsbG93ZWRfZG9tYWlucyAmJgo+IEBAIC00MzcsOCArNDM2LDcgQEAgc3RhdGljIGJvb2wg YW1kZ3B1X2NzX3RyeV9ldmljdChzdHJ1Y3QgYW1kZ3B1X2NzX3BhcnNlciAqcCwKPiAgIAkJLyog R29vZCB3ZSBjYW4gdHJ5IHRvIG1vdmUgdGhpcyBCTyBzb21ld2hlcmUgZWxzZSAqLwo+ICAgCQl1 cGRhdGVfYnl0ZXNfbW92ZWRfdmlzID0KPiAgIAkJCWFkZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6 ZSA8IGFkZXYtPmdtYy5yZWFsX3ZyYW1fc2l6ZSAmJgo+IC0JCQliby0+dGJvLm1lbS5tZW1fdHlw ZSA9PSBUVE1fUExfVlJBTSAmJgo+IC0JCQliby0+dGJvLm1lbS5zdGFydCA8IGFkZXYtPmdtYy52 aXNpYmxlX3ZyYW1fc2l6ZSA+PiBQQUdFX1NISUZUOwo+ICsJCQlhbWRncHVfYm9faW5fY3B1X3Zp c2libGVfdnJhbShibyk7Cj4gICAJCWFtZGdwdV90dG1fcGxhY2VtZW50X2Zyb21fZG9tYWluKGJv LCBvdGhlcik7Cj4gICAJCXIgPSB0dG1fYm9fdmFsaWRhdGUoJmJvLT50Ym8sICZiby0+cGxhY2Vt ZW50LCAmY3R4KTsKPiAgIAkJcC0+Ynl0ZXNfbW92ZWQgKz0gY3R4LmJ5dGVzX21vdmVkOwo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmggYi9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfb2JqZWN0LmgKPiBpbmRleCBkZWIxMGVj ZDg5YTEuLjBlOTU1NTUyNjk1MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9hbWRncHVfb2JqZWN0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9h bWRncHVfb2JqZWN0LmgKPiBAQCAtMTkzLDYgKzE5MywyNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wg YW1kZ3B1X2JvX2dwdV9hY2Nlc3NpYmxlKHN0cnVjdCBhbWRncHVfYm8gKmJvKQo+ICAgCX0KPiAg IH0KPiAgIAo+ICsvKioKPiArICogYW1kZ3B1X2JvX2luX2NwdV92aXNpYmxlX3ZyYW0gLSBjaGVj ayBpZiBCTyBpcyAocGFydGx5KSBpbiB2aXNpYmxlIFZSQU0KPiArICovCj4gK3N0YXRpYyBpbmxp bmUgYm9vbCBhbWRncHVfYm9faW5fY3B1X3Zpc2libGVfdnJhbShzdHJ1Y3QgYW1kZ3B1X2JvICpi bykKPiArewo+ICsJc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYgPSBhbWRncHVfdHRtX2FkZXYo Ym8tPnRiby5iZGV2KTsKPiArCXVuc2lnbmVkIGZwZm4gPSBhZGV2LT5nbWMudmlzaWJsZV92cmFt X3NpemUgPj4gUEFHRV9TSElGVDsKPiArCXN0cnVjdCBkcm1fbW1fbm9kZSAqbm9kZSA9IGJvLT50 Ym8ubWVtLm1tX25vZGU7Cj4gKwl1bnNpZ25lZCBsb25nIHBhZ2VzX2xlZnQ7Cj4gKwo+ICsJaWYg KGJvLT50Ym8ubWVtLm1lbV90eXBlICE9IFRUTV9QTF9WUkFNKQo+ICsJCXJldHVybiBmYWxzZTsK PiArCj4gKwlmb3IgKHBhZ2VzX2xlZnQgPSBiby0+dGJvLm1lbS5udW1fcGFnZXM7IHBhZ2VzX2xl ZnQ7Cj4gKwkgICAgIHBhZ2VzX2xlZnQgLT0gbm9kZS0+c2l6ZSwgbm9kZSsrKQo+ICsJCWlmIChu b2RlLT5zdGFydCA8IGZwZm4pCj4gKwkJCXJldHVybiB0cnVlOwo+ICsKPiArCXJldHVybiBmYWxz ZTsKPiArfQo+ICsKPiAgIC8qKgo+ICAgICogYW1kZ3B1X2JvX2V4cGxpY2l0X3N5bmMgLSByZXR1 cm4gd2hldGhlciB0aGUgYm8gaXMgZXhwbGljaXRseSBzeW5jZWQKPiAgICAqLwo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiBpbmRleCBkMmFiNDA0OTRhNGMuLmFiODI5 ZmIzZTg0MCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVf dHRtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMKPiBA QCAtMjIyLDIwICsyMjIsOCBAQCBzdGF0aWMgdm9pZCBhbWRncHVfZXZpY3RfZmxhZ3Moc3RydWN0 IHR0bV9idWZmZXJfb2JqZWN0ICpibywKPiAgIAkJaWYgKCFhZGV2LT5tbWFuLmJ1ZmZlcl9mdW5j c19lbmFibGVkKSB7Cj4gICAJCQlhbWRncHVfdHRtX3BsYWNlbWVudF9mcm9tX2RvbWFpbihhYm8s IEFNREdQVV9HRU1fRE9NQUlOX0NQVSk7Cj4gICAJCX0gZWxzZSBpZiAoYWRldi0+Z21jLnZpc2li bGVfdnJhbV9zaXplIDwgYWRldi0+Z21jLnJlYWxfdnJhbV9zaXplICYmCj4gLQkJCSAgICEoYWJv LT5mbGFncyAmIEFNREdQVV9HRU1fQ1JFQVRFX0NQVV9BQ0NFU1NfUkVRVUlSRUQpKSB7Cj4gLQkJ CXVuc2lnbmVkIGZwZm4gPSBhZGV2LT5nbWMudmlzaWJsZV92cmFtX3NpemUgPj4gUEFHRV9TSElG VDsKPiAtCQkJc3RydWN0IGRybV9tbV9ub2RlICpub2RlID0gYm8tPm1lbS5tbV9ub2RlOwo+IC0J CQl1bnNpZ25lZCBsb25nIHBhZ2VzX2xlZnQ7Cj4gLQo+IC0JCQlmb3IgKHBhZ2VzX2xlZnQgPSBi by0+bWVtLm51bV9wYWdlczsKPiAtCQkJICAgICBwYWdlc19sZWZ0Owo+IC0JCQkgICAgIHBhZ2Vz X2xlZnQgLT0gbm9kZS0+c2l6ZSwgbm9kZSsrKSB7Cj4gLQkJCQlpZiAobm9kZS0+c3RhcnQgPCBm cGZuKQo+IC0JCQkJCWJyZWFrOwo+IC0JCQl9Cj4gLQo+IC0JCQlpZiAoIXBhZ2VzX2xlZnQpCj4g LQkJCQlnb3RvIGd0dDsKPiArCQkJICAgIShhYm8tPmZsYWdzICYgQU1ER1BVX0dFTV9DUkVBVEVf Q1BVX0FDQ0VTU19SRVFVSVJFRCkgJiYKPiArCQkJICAgYW1kZ3B1X2JvX2luX2NwdV92aXNpYmxl X3ZyYW0oYWJvKSkgewo+ICAgCj4gICAJCQkvKiBUcnkgZXZpY3RpbmcgdG8gdGhlIENQVSBpbmFj Y2Vzc2libGUgcGFydCBvZiBWUkFNCj4gICAJCQkgKiBmaXJzdCwgYnV0IG9ubHkgc2V0IEdUVCBh cyBidXN5IHBsYWNlbWVudCwgc28gdGhpcwo+IEBAIC0yNDQsMTIgKzIzMiwxMSBAQCBzdGF0aWMg dm9pZCBhbWRncHVfZXZpY3RfZmxhZ3Moc3RydWN0IHR0bV9idWZmZXJfb2JqZWN0ICpibywKPiAg IAkJCSAqLwo+ICAgCQkJYW1kZ3B1X3R0bV9wbGFjZW1lbnRfZnJvbV9kb21haW4oYWJvLCBBTURH UFVfR0VNX0RPTUFJTl9WUkFNIHwKPiAgIAkJCQkJCQkgQU1ER1BVX0dFTV9ET01BSU5fR1RUKTsK PiAtCQkJYWJvLT5wbGFjZW1lbnRzWzBdLmZwZm4gPSBmcGZuOwo+ICsJCQlhYm8tPnBsYWNlbWVu dHNbMF0uZnBmbiA9IGFkZXYtPmdtYy52aXNpYmxlX3ZyYW1fc2l6ZSA+PiBQQUdFX1NISUZUOwo+ ICAgCQkJYWJvLT5wbGFjZW1lbnRzWzBdLmxwZm4gPSAwOwo+ICAgCQkJYWJvLT5wbGFjZW1lbnQu YnVzeV9wbGFjZW1lbnQgPSAmYWJvLT5wbGFjZW1lbnRzWzFdOwo+ICAgCQkJYWJvLT5wbGFjZW1l bnQubnVtX2J1c3lfcGxhY2VtZW50ID0gMTsKPiAgIAkJfSBlbHNlIHsKPiAtZ3R0Ogo+ICAgCQkJ YW1kZ3B1X3R0bV9wbGFjZW1lbnRfZnJvbV9kb21haW4oYWJvLCBBTURHUFVfR0VNX0RPTUFJTl9H VFQpOwo+ICAgCQl9Cj4gICAJCWJyZWFrOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9hbWQtZ2Z4Cg==