From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFE4CEB64DA for ; Tue, 11 Jul 2023 02:06:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbjGKCG6 (ORCPT ); Mon, 10 Jul 2023 22:06:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229635AbjGKCG4 (ORCPT ); Mon, 10 Jul 2023 22:06:56 -0400 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B84290; Mon, 10 Jul 2023 19:06:55 -0700 (PDT) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4R0PP80QK5z1FDgN; Tue, 11 Jul 2023 10:06:20 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 11 Jul 2023 10:06:52 +0800 Subject: Re: linux-next: build warning after merge of the cgroup tree To: Tejun Heo , Stephen Rothwell CC: Linux Kernel Mailing List , Linux Next Mailing List References: <20230711111509.1045f32e@canb.auug.org.au> From: Miaohe Lin Message-ID: <9031f42f-6ff3-3e60-049b-fc1917915da9@huawei.com> Date: Tue, 11 Jul 2023 10:06:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/11 9:22, Tejun Heo wrote: > On Tue, Jul 11, 2023 at 11:15:09AM +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the cgroup tree, today's linux-next build (arm >> multi_v7_defconfig) produced this warning: >> >> kernel/cgroup/cgroup.c:503:36: warning: 'cgroup_tryget_css' defined but not used [-Wunused-function] >> 503 | static struct cgroup_subsys_state *cgroup_tryget_css(struct cgroup *cgrp, >> | ^~~~~~~~~~~~~~~~~ >> >> Introduced by commit >> >> 1299eb2b0ad5 ("cgroup: minor cleanup for cgroup_extra_stat_show()") > > Miaohe, can you send a patch to either add __maybe_unused to > cgroup_tryget_css() or also put it inside CONFIG_CGROUP_SCHED? Will do. Sorry for my mistake. Thanks.