From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver
	skeleton
Date: Wed, 11 Oct 2017 15:38:36 +0200
Message-ID: <9041127.34t6OW5FrT@xps>
References: <1507031500-11473-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-3-git-send-email-tdu@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, mw@semihalf.com, dima@marvell.com, nsamsono@marvell.com,
 Jianbo.liu@linaro.org, Jacek Siuda <jck@semihalf.com>
To: Tomasz Duszynski <tdu@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B21B32BF7
 for <dev@dpdk.org>; Wed, 11 Oct 2017 15:38:37 +0200 (CEST)
In-Reply-To: <1507561244-20115-3-git-send-email-tdu@semihalf.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

09/10/2017 17:00, Tomasz Duszynski:
>  #
> +# Compile Marvell PMD driver
> +#
> +CONFIG_RTE_LIBRTE_MRVL_PMD=n
> +CONFIG_RTE_LIBRTE_MRVL_DEBUG=n
> +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=41943040

We are trying to remove build-time configurations and behave like
a true library.

The DEBUG config options are now prohibited.
Where is it used in your code?
If it is used for logs, you should switch to the dynamic log config.

What is MUSDK_DMA_MEMSIZE?
If the value cannot change, it must be a constant in the code.
If it can change, it should be a run-time driver option.

Thank you and welcome!