From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B249BC433DF for ; Wed, 5 Aug 2020 16:05:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8003523125 for ; Wed, 5 Aug 2020 16:05:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LEDP+LXQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8003523125 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k3Lur-0006JW-Qk for qemu-devel@archiver.kernel.org; Wed, 05 Aug 2020 12:05:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k3Lu9-0005Zv-Ol for qemu-devel@nongnu.org; Wed, 05 Aug 2020 12:04:37 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50280 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k3Lu6-00075b-Kx for qemu-devel@nongnu.org; Wed, 05 Aug 2020 12:04:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596643473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l04uUf/vFWqOV5MveIWQq3yxlQ1gJsaCbcm9HRuY2Xo=; b=LEDP+LXQ3+ElJX8QE5zDPk0jG5s1pb6rmlRWYW5iXX8EYxhfd328QySbNfhbnIQFGj+inL Rn5fWPiYRv1XZZll2F09OWkL1mHS+pByxe1bSTMoEM+SXNoAsc2SLqseVFnlKrqxSNmvr9 EDWNT6sWPEolBzKJ24CEa6Vr7LZw+os= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-351-or16M2oDNGqaj71iktFHqg-1; Wed, 05 Aug 2020 12:04:29 -0400 X-MC-Unique: or16M2oDNGqaj71iktFHqg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 86D64106B242; Wed, 5 Aug 2020 16:04:28 +0000 (UTC) Received: from ibm-p8-OVS-01-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com (ovpn-117-179.rdu2.redhat.com [10.10.117.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DC925F21A; Wed, 5 Aug 2020 16:04:17 +0000 (UTC) Subject: Re: cleanups with long-term benefits (was Re: [PATCH] schemas: Add vim modeline) To: Markus Armbruster References: <20200729185024.121766-1-abologna@redhat.com> <87ime52wxd.fsf@dusky.pond.sub.org> <20200730093732.GB3477223@redhat.com> <87k0ylz0ep.fsf@dusky.pond.sub.org> <20200730132446.GL3477223@redhat.com> <875za33ku1.fsf@dusky.pond.sub.org> <20200731150738.GB3660103@redhat.com> <2cf1a431-9d2c-8ad6-446e-f10b36219764@redhat.com> <87d048i1m2.fsf@dusky.pond.sub.org> <83bbe0b0-c5e0-e3b7-5ba1-5946098370d5@redhat.com> <87ft94klyl.fsf@dusky.pond.sub.org> <490a0786-73f3-411e-4dfe-8c2ae90de251@redhat.com> <87y2mvhg3k.fsf@dusky.pond.sub.org> <87k0yeg7mc.fsf@dusky.pond.sub.org> <6e5df5fc-94f8-ee8e-0c14-f56135de25e4@redhat.com> <87o8np5ysp.fsf@dusky.pond.sub.org> From: John Snow Message-ID: <90445173-cc5c-e725-5782-5b1095af6e53@redhat.com> Date: Wed, 5 Aug 2020 12:04:16 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87o8np5ysp.fsf@dusky.pond.sub.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=207.211.31.120; envelope-from=jsnow@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/05 12:04:33 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , Jason Wang , Juan Quintela , qemu-devel@nongnu.org, Yuval Shaia , Gerd Hoffmann , Andrea Bolognani , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Paolo Bonzini , Michael Roth , "Dr. David Alan Gilbert" , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/5/20 3:36 AM, Markus Armbruster wrote: > John Snow writes: > >> On 8/4/20 4:03 AM, Markus Armbruster wrote: >>> The pain of tweaking the parser is likely dwarved several times over by >>> the pain of the flag day. >> >> You mention this often; I wonder if I misunderstand the critique, >> because the pain of a "flag day" for a new file format seems >> negligible to me. >> >> I don't think we edit these .json files very often. Generally, we add >> a new command when we need one. The edits are usually one or two lines >> plus docstrings. >> >> If anyone has patches in-flight, I genuinely doubt it will take more >> than a few minutes to rewrite for the new file format. >> >> No? > > You describe the the flag day's one-time pain. > > There's also the longer term pain of having to work around git-blame > unable to see beyond the flag day. > So it's not really the "flag day" we're worried about anymore, it's the ongoing ease-of-use for vcs history. > I'm not claiming the pain is prohibitive (if I thought it was, I > would've tried to strange this thread in its crib), I am claiming it'll > be much more painful (read: expensive) than a parser tweak. > I do use `git blame` quite a lot, but with a project as old as QEMU, most of my trips through history do involve jumping across a few refactor gaps as a normal part of that process. As Dan points out, I often have to back out and add refactorSHA^ to my invocation, and just keep hopping backwards until I find what I am truly after. It just feels like a fact of programmer life for me at this point. I've not used Paolo's invocation before, but it looks like it might be useful. I'll try to remember to try it out.